All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue
@ 2021-04-21 12:07 Amos Gross
  2021-04-29  9:08 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Amos Gross @ 2021-04-21 12:07 UTC (permalink / raw)
  To: gregkh; +Cc: linux-staging

Fixed warning from checkpatch for code block not being indented
correctly.

Signed-off-by: Amos Gross <email@amosgross.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 1ffd2ce68974..d53052e0696e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -790,7 +790,7 @@ static s32 xmitframe_addmic(struct adapter *padapter, struct xmit_frame *pxmitfr
 				if (pframe[1]&2)  /* From Ds == 1 */
 					rtw_secmicappend(&micdata, &pframe[24], 6);
 				else
-				rtw_secmicappend(&micdata, &pframe[10], 6);
+					rtw_secmicappend(&micdata, &pframe[10], 6);
 			} else {	/* ToDS == 0 */
 				rtw_secmicappend(&micdata, &pframe[4], 6);   /* DA */
 				if (pframe[1]&2)  /* From Ds == 1 */
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue
  2021-04-21 12:07 [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue Amos Gross
@ 2021-04-29  9:08 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2021-04-29  9:08 UTC (permalink / raw)
  To: Amos Gross; +Cc: gregkh, linux-staging

On Wed, Apr 21, 2021 at 12:07:31PM +0000, Amos Gross wrote:
> Fixed warning from checkpatch for code block not being indented
> correctly.
> 
> Signed-off-by: Amos Gross <email@amosgross.com>

This isn't a bug fix but I always like to see a Fixes tag for these or
some kind of explanation about why it's wrong in the first place.  In
this case it's just that the indenting has never been correct since the
driver was first merged.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-29  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 12:07 [PATCH] Staging: rtl8723bs: rtw_xmit: fixed tabbing issue Amos Gross
2021-04-29  9:08 ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.