From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF322F82 for ; Thu, 29 Apr 2021 13:55:56 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13T9rjSf187179; Thu, 29 Apr 2021 10:08:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=RhR1xbKgQZabcBpM0ZPa86+NpTyKGU7t9CqRoOe65cY=; b=m9u0elMcbxEn5/HarR5N9RBuP4G9vJEmSWrfGgChCe8nBzJY0mQ4yUiJU4WZ+RsKeTbU 3sVrrFtEdQXHMQ7U/bWHSnavtxAYeeWg2ESPWRf8poanZqH0lMulpHzgwkJDk6nwxFVW 0c/gqzwbWsh+0BIw5E+CERHuC/ynpX0EuU0IFK63TiobwhsmjfU4gHTSx6haBIlgiOJh QWrcabygV8zP21zaI/N51rPSwK8rh3wZWPrxJqXIV8vZbS27iHOWgtjrxoiCHc5Sxdpl wVQlPNwwqqDXPr9e3oMWgD8CnmJ2HQLBN9yLnXf6Ckg4KjqfKu2V7zE15Sb7wzDjQ+oH +g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 385ahbuty4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 10:08:19 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 13T9tsww124394; Thu, 29 Apr 2021 10:08:19 GMT Received: from pps.reinject (localhost [127.0.0.1]) by aserp3020.oracle.com with ESMTP id 384b5a238q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 10:08:19 +0000 Received: from aserp3020.oracle.com (aserp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 13TA62mT176918; Thu, 29 Apr 2021 10:08:18 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 384b5a237u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Apr 2021 10:08:18 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 13TA8G6M020884; Thu, 29 Apr 2021 10:08:16 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 29 Apr 2021 03:08:15 -0700 Date: Thu, 29 Apr 2021 13:08:09 +0300 From: Dan Carpenter To: Deepak R Varma Cc: Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mh12gx2825@gmail.com Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Message-ID: <20210429100808.GZ1981@kadam> References: X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-GUID: EK4M0k6gYkIgZwQ5Z98dreIdNf-IHnuO X-Proofpoint-ORIG-GUID: EK4M0k6gYkIgZwQ5Z98dreIdNf-IHnuO X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9968 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104290068 On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote: > @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, > } > > /* > - // set analog/digital gain > + * set analog/digital gain > switch(AnalogGain) > { > case 0: How on earth does this compile? > @@ -1069,8 +1073,10 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd, regards, dan carpenter