From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852CFC433B4 for ; Thu, 29 Apr 2021 23:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B34861445 for ; Thu, 29 Apr 2021 23:04:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229656AbhD2XFB (ORCPT ); Thu, 29 Apr 2021 19:05:01 -0400 Received: from mga18.intel.com ([134.134.136.126]:53418 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhD2XFA (ORCPT ); Thu, 29 Apr 2021 19:05:00 -0400 IronPort-SDR: YRtt4Ji4waPgevN+XEdxW0ncTrnQNi5s3ZQ45zk1iShK0Y3rbUMGpdSoIGnPDUK63dkoowJx8a F4qt3K8K2a/g== X-IronPort-AV: E=McAfee;i="6200,9189,9969"; a="184615119" X-IronPort-AV: E=Sophos;i="5.82,260,1613462400"; d="scan'208";a="184615119" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 16:04:12 -0700 IronPort-SDR: 6+FwaPgiFdigqVtSY3veAlz0a/L6X+7mTvM8vf6oRT4RNwDeO+lAraUZj3kCeuhQYs8D+PBo/e GhmaUBR1K+6A== X-IronPort-AV: E=Sophos;i="5.82,260,1613462400"; d="scan'208";a="466541563" Received: from tassilo.jf.intel.com ([10.54.74.11]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 16:04:12 -0700 Date: Thu, 29 Apr 2021 16:04:11 -0700 From: Andi Kleen To: Thomas Gleixner Cc: paulmck@kernel.org, Feng Tang , kernel test robot , 0day robot , John Stultz , Stephen Boyd , Jonathan Corbet , Mark Rutland , Marc Zyngier , Xing Zhengjun , LKML , lkp@lists.01.org, kernel-team@fb.com, neeraju@codeaurora.org, zhengjun.xing@intel.com, x86@kernel.org, Paolo Bonzini Subject: Re: [clocksource] 8c30ace35d: WARNING:at_kernel/time/clocksource.c:#clocksource_watchdog Message-ID: <20210429230411.GK4032392@tassilo.jf.intel.com> References: <87y2d3mo2q.ffs@nanos.tec.linutronix.de> <87a6pimt1f.ffs@nanos.tec.linutronix.de> <20210428183118.GR975577@paulmck-ThinkPad-P17-Gen-1> <878s517axu.ffs@nanos.tec.linutronix.de> <20210429142641.GU975577@paulmck-ThinkPad-P17-Gen-1> <87lf91f177.ffs@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lf91f177.ffs@nanos.tec.linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The idea is to leave the watchdog code in kernel/time/clocksource.c, > > but to move the fault injection into kernel/time/clocksourcefault.c or > > some such. In this new file, new clocksource structures are created that > > use some existing timebase/clocksource under the covers. These then > > inject delays based on module parameters (one senstive to CPU number, > > the other unconditional). They register these clocksources using the > > normal interfaces, and verify that they are eventually marked unstable > > when the fault-injection parameters warrant it. This is combined with > > the usual checking of the console log. > > > > Or am I missing your point? > > That's what I meant. I still think all this stuff should be in the fault injection framework, like other fault injections, to have a consistent discoverable interface. I actually checked now and the standard fault injection supports boot arguments, so needing it at boot time shouldn't be a barrier. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1476874312332415531==" MIME-Version: 1.0 From: Andi Kleen To: lkp@lists.01.org Subject: Re: [clocksource] 8c30ace35d: WARNING:at_kernel/time/clocksource.c:#clocksource_watchdog Date: Thu, 29 Apr 2021 16:04:11 -0700 Message-ID: <20210429230411.GK4032392@tassilo.jf.intel.com> In-Reply-To: <87lf91f177.ffs@nanos.tec.linutronix.de> List-Id: --===============1476874312332415531== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > > The idea is to leave the watchdog code in kernel/time/clocksource.c, > > but to move the fault injection into kernel/time/clocksourcefault.c or > > some such. In this new file, new clocksource structures are created th= at > > use some existing timebase/clocksource under the covers. These then > > inject delays based on module parameters (one senstive to CPU number, > > the other unconditional). They register these clocksources using the > > normal interfaces, and verify that they are eventually marked unstable > > when the fault-injection parameters warrant it. This is combined with > > the usual checking of the console log. > > > > Or am I missing your point? > = > That's what I meant. I still think all this stuff should be in the fault injection framework, like other fault injections, to have a consistent discoverable interface. = I actually checked now and the standard fault injection supports boot argum= ents, so needing it at boot time shouldn't be a barrier. -Andi --===============1476874312332415531==--