From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A689C433B4 for ; Fri, 30 Apr 2021 07:26:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68FAB613C5 for ; Fri, 30 Apr 2021 07:26:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230445AbhD3H1I (ORCPT ); Fri, 30 Apr 2021 03:27:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhD3H1F (ORCPT ); Fri, 30 Apr 2021 03:27:05 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D71C06174A for ; Fri, 30 Apr 2021 00:26:16 -0700 (PDT) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcNXO-00024H-S6; Fri, 30 Apr 2021 09:26:10 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lcNXN-0003hA-6G; Fri, 30 Apr 2021 09:26:09 +0200 Date: Fri, 30 Apr 2021 09:26:09 +0200 From: Oleksij Rempel To: Geert Uytterhoeven Cc: Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Fugang Duan , Sascha Hauer , netdev , Linux ARM , Linux Kernel Mailing List , NXP Linux Team , Fabio Estevam , David Jander , Russell King , Philippe Schenker Subject: Re: [PATCH net-next v3 3/6] net: add generic selftest support Message-ID: <20210430072609.GA6711@pengutronix.de> References: <20210419130106.6707-1-o.rempel@pengutronix.de> <20210419130106.6707-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:20:01 up 60 days, 16:55, 117 users, load average: 0.30, 0.35, 0.31 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Fri, Apr 30, 2021 at 08:45:05AM +0200, Geert Uytterhoeven wrote: > Hi Oleksij, > > On Mon, Apr 19, 2021 at 3:13 PM Oleksij Rempel wrote: > > Port some parts of the stmmac selftest and reuse it as basic generic selftest > > library. This patch was tested with following combinations: > > - iMX6DL FEC -> AT8035 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 > > - AR9331 ag71xx -> AR9331 PHY > > - AR9331 ag71xx -> AR9331 switch -> AR9331 PHY > > > > Signed-off-by: Oleksij Rempel > > Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add > generic selftest support") upstream. > > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -429,6 +429,10 @@ config GRO_CELLS > > config SOCK_VALIDATE_XMIT > > bool > > > > +config NET_SELFTESTS > > + def_tristate PHYLIB > > Why does this default to enabled if PHYLIB=y? > Usually we allow the user to make selftests modular, independent of the > feature under test, but I may misunderstand the purpose of this test. > > Thanks for your clarification! There is nothing against making optional. Should I do it? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B3AC433ED for ; Fri, 30 Apr 2021 07:27:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 385CC613B3 for ; Fri, 30 Apr 2021 07:27:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 385CC613B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Kl8M219wpObwlnB4a/XxBf+BaNiHo7ajNnvGK0yNaho=; b=F8rliW6yEqBmfNmIJIsVdB+Ys nqABoa8yGRVE/Tr1K8MZg0YdKChbfbDVl3Mg6JhEQCzPcslnzgpTu9qie6lC8ttTASccTiVNP/+tx CT2Zj1tgNmqaCCH0HODT2BAa5jZ/MjgAGvxSzmYW9XsNCZk9gVJq4wNSIUKLU3WQTI3ikwI2DcweF y/9Zp3LVp2ah/L9/vKED+XTSRXG9M5GG7j1yBKlpuKG++FM8CFHu68s2OvKZPZ0xPsZUsv2NHXf7L W085Ypo/+p58NCA6kXTLm1JZmz3hct0mJoq51rxWj02Gi1jpdji/W4yfCUoaOLqNP40mToBF3taOZ WbLOPKFJQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lcNXb-007QMj-1a; Fri, 30 Apr 2021 07:26:23 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNXX-007QMT-Go for linux-arm-kernel@desiato.infradead.org; Fri, 30 Apr 2021 07:26:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tVA/djDpV+pUVZWAJNcNwbLHuCfPB2BiHSMUs3cm7Oo=; b=1jddMZxhQsqENlnzCQMnuD70m7 +OZOya91ASNJyv8pP3jLwqKmaWTi+oJ16FMDigwzycfkrH94de+0Q9guZg1FcJnrCzXer6olu1QKJ eczG5QnjQnXZfM2WMwv3xgFvCiM/f/t/5ciDGT/VvHtN9kEHMNfvHIC6qmMbdtcKsJiwtnKQmmk/N RVjiej/YNQjZko4RBYS75/NBDSJZNGnA9vUh9Ed2II0c2+u0EiAN6APOOKgYYKEFOLMnrl/pJYZSA 6fx6/nrAO478TPN5W0zmdDGRERxedusBpMT4OT/Wl/05JfbNk3T9cCm8CRjHaA3TvjeBumg1LmQdJ lkaHYmQQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lcNXU-001CJR-Na for linux-arm-kernel@lists.infradead.org; Fri, 30 Apr 2021 07:26:18 +0000 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lcNXO-00024H-S6; Fri, 30 Apr 2021 09:26:10 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lcNXN-0003hA-6G; Fri, 30 Apr 2021 09:26:09 +0200 Date: Fri, 30 Apr 2021 09:26:09 +0200 From: Oleksij Rempel To: Geert Uytterhoeven Cc: Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Fugang Duan , Sascha Hauer , netdev , Linux ARM , Linux Kernel Mailing List , NXP Linux Team , Fabio Estevam , David Jander , Russell King , Philippe Schenker Subject: Re: [PATCH net-next v3 3/6] net: add generic selftest support Message-ID: <20210430072609.GA6711@pengutronix.de> References: <20210419130106.6707-1-o.rempel@pengutronix.de> <20210419130106.6707-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:20:01 up 60 days, 16:55, 117 users, load average: 0.30, 0.35, 0.31 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210430_002616_792980_616765F2 X-CRM114-Status: GOOD ( 24.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Geert, On Fri, Apr 30, 2021 at 08:45:05AM +0200, Geert Uytterhoeven wrote: > Hi Oleksij, > > On Mon, Apr 19, 2021 at 3:13 PM Oleksij Rempel wrote: > > Port some parts of the stmmac selftest and reuse it as basic generic selftest > > library. This patch was tested with following combinations: > > - iMX6DL FEC -> AT8035 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 > > - AR9331 ag71xx -> AR9331 PHY > > - AR9331 ag71xx -> AR9331 switch -> AR9331 PHY > > > > Signed-off-by: Oleksij Rempel > > Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add > generic selftest support") upstream. > > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -429,6 +429,10 @@ config GRO_CELLS > > config SOCK_VALIDATE_XMIT > > bool > > > > +config NET_SELFTESTS > > + def_tristate PHYLIB > > Why does this default to enabled if PHYLIB=y? > Usually we allow the user to make selftests modular, independent of the > feature under test, but I may misunderstand the purpose of this test. > > Thanks for your clarification! There is nothing against making optional. Should I do it? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel