* [stffrdhrn:litex-gpio-fix 20/26] drivers/irqchip/irq-litex-vexriscv.c:29:10: error: implicit declaration of function 'csr_read'; did you mean 'acpi_read'?
@ 2021-04-30 0:17 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-30 0:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4048 bytes --]
Hi Filip,
FYI, the error/warning still remains.
tree: https://github.com/stffrdhrn/linux.git litex-gpio-fix
head: 6f903ad53b35652c15f91265053f437a6b6f17f0
commit: 3ba07109cc9be241f4b59401e028a6b93161ed78 [20/26] LiteX: support for VexRiscV interrupt controller
config: openrisc-randconfig-s032-20210429 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/stffrdhrn/linux/commit/3ba07109cc9be241f4b59401e028a6b93161ed78
git remote add stffrdhrn https://github.com/stffrdhrn/linux.git
git fetch --no-tags stffrdhrn litex-gpio-fix
git checkout 3ba07109cc9be241f4b59401e028a6b93161ed78
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_getie':
>> drivers/irqchip/irq-litex-vexriscv.c:29:10: error: implicit declaration of function 'csr_read'; did you mean 'acpi_read'? [-Werror=implicit-function-declaration]
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~~~
| acpi_read
>> drivers/irqchip/irq-litex-vexriscv.c:29:19: error: 'sstatus' undeclared (first use in this function); did you mean 'si_status'?
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~~
| si_status
drivers/irqchip/irq-litex-vexriscv.c:29:19: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/irqchip/irq-litex-vexriscv.c:29:30: error: 'IE_SIE' undeclared (first use in this function)
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_setie':
>> drivers/irqchip/irq-litex-vexriscv.c:35:3: error: implicit declaration of function 'csr_write'; did you mean 'acpi_write'? [-Werror=implicit-function-declaration]
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~~~~
| acpi_write
drivers/irqchip/irq-litex-vexriscv.c:35:13: error: 'sstatus' undeclared (first use in this function); did you mean 'si_status'?
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~~
| si_status
drivers/irqchip/irq-litex-vexriscv.c:35:22: error: 'IE_SIE' undeclared (first use in this function)
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~
>> drivers/irqchip/irq-litex-vexriscv.c:37:3: error: implicit declaration of function 'csr_clear'; did you mean 'cpumask_clear'? [-Werror=implicit-function-declaration]
37 | csr_clear(sstatus, IE_SIE);
| ^~~~~~~~~
| cpumask_clear
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_getie':
drivers/irqchip/irq-litex-vexriscv.c:30:1: error: control reaches end of non-void function [-Werror=return-type]
30 | }
| ^
cc1: some warnings being treated as errors
vim +29 drivers/irqchip/irq-litex-vexriscv.c
26
27 static unsigned int litex_vexriscv_irq_getie(void)
28 {
> 29 return (csr_read(sstatus) & IE_SIE) != 0;
30 }
31
32 static void litex_vexriscv_irq_setie(unsigned int ie)
33 {
34 if (ie)
> 35 csr_write(sstatus, IE_SIE);
36 else
> 37 csr_clear(sstatus, IE_SIE);
38 }
39
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30651 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [stffrdhrn:litex-gpio-fix 20/26] drivers/irqchip/irq-litex-vexriscv.c:29:10: error: implicit declaration of function 'csr_read'; did you mean 'acpi_read'?
@ 2021-04-29 19:58 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-04-29 19:58 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 7101 bytes --]
tree: https://github.com/stffrdhrn/linux.git litex-gpio-fix
head: 6f903ad53b35652c15f91265053f437a6b6f17f0
commit: 3ba07109cc9be241f4b59401e028a6b93161ed78 [20/26] LiteX: support for VexRiscV interrupt controller
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/stffrdhrn/linux/commit/3ba07109cc9be241f4b59401e028a6b93161ed78
git remote add stffrdhrn https://github.com/stffrdhrn/linux.git
git fetch --no-tags stffrdhrn litex-gpio-fix
git checkout 3ba07109cc9be241f4b59401e028a6b93161ed78
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_getie':
>> drivers/irqchip/irq-litex-vexriscv.c:29:10: error: implicit declaration of function 'csr_read'; did you mean 'acpi_read'? [-Werror=implicit-function-declaration]
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~~~
| acpi_read
>> drivers/irqchip/irq-litex-vexriscv.c:29:19: error: 'sstatus' undeclared (first use in this function); did you mean 'kstatfs'?
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~~
| kstatfs
drivers/irqchip/irq-litex-vexriscv.c:29:19: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/irqchip/irq-litex-vexriscv.c:29:30: error: 'IE_SIE' undeclared (first use in this function)
29 | return (csr_read(sstatus) & IE_SIE) != 0;
| ^~~~~~
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_setie':
>> drivers/irqchip/irq-litex-vexriscv.c:35:3: error: implicit declaration of function 'csr_write'; did you mean 'acpi_write'? [-Werror=implicit-function-declaration]
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~~~~
| acpi_write
drivers/irqchip/irq-litex-vexriscv.c:35:13: error: 'sstatus' undeclared (first use in this function); did you mean 'kstatfs'?
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~~
| kstatfs
drivers/irqchip/irq-litex-vexriscv.c:35:22: error: 'IE_SIE' undeclared (first use in this function)
35 | csr_write(sstatus, IE_SIE);
| ^~~~~~
>> drivers/irqchip/irq-litex-vexriscv.c:37:3: error: implicit declaration of function 'csr_clear'; did you mean 'cap_clear'? [-Werror=implicit-function-declaration]
37 | csr_clear(sstatus, IE_SIE);
| ^~~~~~~~~
| cap_clear
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_intc_handle_irq':
>> drivers/irqchip/irq-litex-vexriscv.c:123:4: error: implicit declaration of function 'handle_domain_irq'; did you mean 'handle_bad_irq'? [-Werror=implicit-function-declaration]
123 | handle_domain_irq(root_domain, i, regs);
| ^~~~~~~~~~~~~~~~~
| handle_bad_irq
drivers/irqchip/irq-litex-vexriscv.c: In function 'litex_vexriscv_irq_getie':
drivers/irqchip/irq-litex-vexriscv.c:30:1: error: control reaches end of non-void function [-Werror=return-type]
30 | }
| ^
cc1: some warnings being treated as errors
vim +29 drivers/irqchip/irq-litex-vexriscv.c
26
27 static unsigned int litex_vexriscv_irq_getie(void)
28 {
> 29 return (csr_read(sstatus) & IE_SIE) != 0;
30 }
31
32 static void litex_vexriscv_irq_setie(unsigned int ie)
33 {
34 if (ie)
> 35 csr_write(sstatus, IE_SIE);
36 else
> 37 csr_clear(sstatus, IE_SIE);
38 }
39
40 static unsigned int litex_vexriscv_irq_getmask(void)
41 {
42 u32 mask;
43
44 __asm__ __volatile__ ("csrr %0, %1" : "=r"(mask) : "i"(IRQ_MASK));
45 return mask;
46 }
47
48 static void litex_vexriscv_irq_setmask(unsigned int mask)
49 {
50 __asm__ volatile ("csrw %0, %1" :: "i"(IRQ_MASK), "r"(mask));
51 }
52
53 static unsigned int litex_vexriscv_irq_pending(void)
54 {
55 u32 pending;
56
57 __asm__ __volatile__ ("csrr %0, %1" : "=r"(pending) : "i"(IRQ_PENDING));
58 return pending;
59 }
60
61 static int litex_vexriscv_intc_map(struct irq_domain *d, unsigned int irq,
62 irq_hw_number_t hw)
63 {
64 struct litex_vexriscv_intc *intc = d->host_data;
65
66 pr_debug("irqchip: LiteX Vexriscv irqmap: %d\n", irq);
67 irq_set_chip_and_handler(irq, &intc->chip, intc->handle);
68 irq_set_status_flags(irq, intc->flags);
69
70 pr_debug("irqchip: mapcount: %d\n", d->mapcount);
71
72 return 0;
73 }
74
75 static void litex_vexriscv_intc_mask(struct irq_data *data)
76 {
77 unsigned int mask = litex_vexriscv_irq_getmask();
78 unsigned int irqbit = BIT(data->hwirq);
79
80 pr_debug("irqchip: LiteX VexRiscv irqchip mask: 0x%08x -> 0x%08x",
81 mask, mask & ~irqbit);
82 mask &= ~irqbit;
83 litex_vexriscv_irq_setmask(mask);
84
85 if (!mask)
86 litex_vexriscv_irq_setie(0);
87 }
88
89 static void litex_vexriscv_intc_unmask(struct irq_data *data)
90 {
91 unsigned int mask = litex_vexriscv_irq_getmask();
92 unsigned int irqbit = BIT(data->hwirq);
93
94 pr_debug("irqchip: LiteX VexRiscv irqchip mask: 0x%08x -> 0x%08x",
95 mask, mask | irqbit);
96 mask |= irqbit;
97 litex_vexriscv_irq_setmask(mask);
98
99 if (!litex_vexriscv_irq_getie())
100 litex_vexriscv_irq_setie(1);
101 }
102
103 static void litex_vexriscv_intc_ack(struct irq_data *data)
104 {
105 /* no need to ack IRQs */
106 }
107
108 static void litex_vexriscv_intc_handle_irq(struct pt_regs *regs)
109 {
110 unsigned int irq;
111 int i;
112
113 irq = litex_vexriscv_irq_pending() & litex_vexriscv_irq_getmask();
114 pr_debug("irqchip: Litex Vexriscv irqchip mask: 0x%08x pending: 0x%08x",
115 litex_vexriscv_irq_getmask(),
116 litex_vexriscv_irq_pending());
117
118 for (i = 0; i < IRQ_VEC_SZ; i++) {
119 pr_debug("irqchip: i %d, irq 0x%08x, trying 0x%08lx\n", i, irq, BIT(i));
120
121 if (irq & BIT(i)) {
122 pr_debug("irqchip: handling@i = %d\n", i);
> 123 handle_domain_irq(root_domain, i, regs);
124 }
125 }
126 }
127
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65657 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-30 0:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 0:17 [stffrdhrn:litex-gpio-fix 20/26] drivers/irqchip/irq-litex-vexriscv.c:29:10: error: implicit declaration of function 'csr_read'; did you mean 'acpi_read'? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-04-29 19:58 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.