From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 743A5C433ED for ; Fri, 30 Apr 2021 11:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42F816145D for ; Fri, 30 Apr 2021 11:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231615AbhD3LYl (ORCPT ); Fri, 30 Apr 2021 07:24:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:57218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhD3LYj (ORCPT ); Fri, 30 Apr 2021 07:24:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6ECE261458; Fri, 30 Apr 2021 11:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619781831; bh=X+CDJhE8KfboV+3/jr0bHess9R7lNxucFQ1ERm6TnLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XG6EX9X7TZi4D5vnQLpE7gW4B0aJD7CxwgzqwLdHGo+ahuEHLDNddejZb6UQhx5YF VdxLJewb6a9DvT2h8n3ctq6pBTR2wghrUDZ9kbsIAyX1rqHI0m6pyk1umsb5/NtBhx 3d3LmQNfio1O1OCVamZI57hpa0kX3C8b6TZ0waHurlbnaC8/pzR77x35CwPVVor1Vh b2cBeX/Z6Ejocrgnohm1lyz0HJyFzTzDA/BQ4E6VZbhYGR9nhbIjTFToFJyRjbkMtC spXCXIwue2Fq0naix4mawTqgzEvrI3TPPxWz+04bmlvtepuYdkMFGhPpB80ky3y0G+ IwfjLB/PvI1fQ== Date: Fri, 30 Apr 2021 12:23:19 +0100 From: Mark Brown To: trix@redhat.com Cc: srinivas.kandagatla@linaro.org, bgoswami@codeaurora.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: codecs: lpass-wsa-macro: make sure array index is set Message-ID: <20210430112319.GB5981@sirena.org.uk> References: <20210429173642.3230615-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko" Content-Disposition: inline In-Reply-To: <20210429173642.3230615-1-trix@redhat.com> X-Cookie: QOTD: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 29, 2021 at 10:36:42AM -0700, trix@redhat.com wrote: > The happens because 'ec_tx' is never initialized and there is > no default in the switch statement that sets ec_tx. Because there > are only two cases for the switch, convert it to an if-else. Add a default case that errors, that way if someone adds a new option things are less painful. --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCL6KcACgkQJNaLcl1U h9CHXQf/cWdl/E0EgzkmkslN9kdNSVSNk0J8PaNu6KP5kS0/hGhz2SxN0xkAxKQB 9gC0od5C5pSH3EnOu6YVt69YsNaZg0M3bZQYPA0UU4ePNI7zeCu1kgzudggcymvQ QFaG6zyxP856E+Mak2llLI1WbuB/AGv54CPOwUHCy2WSsJMYs5WyoTruNEwVpmsl S4O//D9Vz6+EqPhPCEaRJlCeZunhUAcCSuDgEv1Kob85SAsfz/G9r2GLylIME2pH kYy9iQ2sYkEyVnGss+vb2nxW47s2x6d0BuATY7cS8/oI7xDa0GFKDqV4rhTuFRLc 6nEN0mBEPz139jjDvDLmJVaWUN04TA== =9LpP -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF47C433ED for ; Fri, 30 Apr 2021 11:24:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99A866145D for ; Fri, 30 Apr 2021 11:24:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99A866145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 438F51666; Fri, 30 Apr 2021 13:24:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 438F51666 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1619781892; bh=X+CDJhE8KfboV+3/jr0bHess9R7lNxucFQ1ERm6TnLs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q60jSay5OdIFTgXaUHbdjgdnqaeeQk83lz8xaS5g7nFV0ob1iQCrbD02+JqnhCoNa PWCfu7HmoMo6T8//lUuPMi91IWO1mk6/1gBtkW8g7vHDjyXxBJXFV75u9CJBVVy8Zk XwE69cHIKoDxdViJ4ip1X65PIDALlZIP3E0mlgTo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9A2BBF80165; Fri, 30 Apr 2021 13:24:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 678BCF8016C; Fri, 30 Apr 2021 13:23:59 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 36B2FF800D3 for ; Fri, 30 Apr 2021 13:23:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 36B2FF800D3 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XG6EX9X7" Received: by mail.kernel.org (Postfix) with ESMTPSA id 6ECE261458; Fri, 30 Apr 2021 11:23:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619781831; bh=X+CDJhE8KfboV+3/jr0bHess9R7lNxucFQ1ERm6TnLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XG6EX9X7TZi4D5vnQLpE7gW4B0aJD7CxwgzqwLdHGo+ahuEHLDNddejZb6UQhx5YF VdxLJewb6a9DvT2h8n3ctq6pBTR2wghrUDZ9kbsIAyX1rqHI0m6pyk1umsb5/NtBhx 3d3LmQNfio1O1OCVamZI57hpa0kX3C8b6TZ0waHurlbnaC8/pzR77x35CwPVVor1Vh b2cBeX/Z6Ejocrgnohm1lyz0HJyFzTzDA/BQ4E6VZbhYGR9nhbIjTFToFJyRjbkMtC spXCXIwue2Fq0naix4mawTqgzEvrI3TPPxWz+04bmlvtepuYdkMFGhPpB80ky3y0G+ IwfjLB/PvI1fQ== Date: Fri, 30 Apr 2021 12:23:19 +0100 From: Mark Brown To: trix@redhat.com Subject: Re: [PATCH] ASoC: codecs: lpass-wsa-macro: make sure array index is set Message-ID: <20210430112319.GB5981@sirena.org.uk> References: <20210429173642.3230615-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko" Content-Disposition: inline In-Reply-To: <20210429173642.3230615-1-trix@redhat.com> X-Cookie: QOTD: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-kernel@vger.kernel.org, tiwai@suse.com, lgirdwood@gmail.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 29, 2021 at 10:36:42AM -0700, trix@redhat.com wrote: > The happens because 'ec_tx' is never initialized and there is > no default in the switch statement that sets ec_tx. Because there > are only two cases for the switch, convert it to an if-else. Add a default case that errors, that way if someone adds a new option things are less painful. --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmCL6KcACgkQJNaLcl1U h9CHXQf/cWdl/E0EgzkmkslN9kdNSVSNk0J8PaNu6KP5kS0/hGhz2SxN0xkAxKQB 9gC0od5C5pSH3EnOu6YVt69YsNaZg0M3bZQYPA0UU4ePNI7zeCu1kgzudggcymvQ QFaG6zyxP856E+Mak2llLI1WbuB/AGv54CPOwUHCy2WSsJMYs5WyoTruNEwVpmsl S4O//D9Vz6+EqPhPCEaRJlCeZunhUAcCSuDgEv1Kob85SAsfz/G9r2GLylIME2pH kYy9iQ2sYkEyVnGss+vb2nxW47s2x6d0BuATY7cS8/oI7xDa0GFKDqV4rhTuFRLc 6nEN0mBEPz139jjDvDLmJVaWUN04TA== =9LpP -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko--