Hi Michel, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/x86/mm] [also build test ERROR on arm64/for-next/core linus/master v5.12] [cannot apply to hnaz-linux-mm/master next-20210430] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git a500fc918f7b8dc3dff2e6c74f3e73e856c18248 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/284898f9c11d755d2b231794fc7529d562f8e918 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michel-Lespinasse/Speculative-page-faults-anon-vmas-only/20210501-035602 git checkout 284898f9c11d755d2b231794fc7529d562f8e918 # save the attached .config to linux build tree make W=1 W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/mm.h: In function 'pte_map_lock': include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/highmem.h:14, from include/linux/pagemap.h:11, from include/linux/blkdev.h:14, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/highmem-internal.h: At top level: >> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic' 98 | static inline void *kmap_atomic(struct page *page) | ^~~~~~~~~~~ In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/mm.h: In function 'pte_map_lock': include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/highmem.h:14, from include/linux/pagemap.h:11, from include/linux/blkdev.h:14, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/highmem-internal.h: At top level: >> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic' 98 | static inline void *kmap_atomic(struct page *page) | ^~~~~~~~~~~ In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:116: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1233: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/mm.h: In function 'pte_map_lock': include/linux/pgtable.h:79:12: error: implicit declaration of function 'kmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration] 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ In file included from include/linux/highmem.h:14, from include/linux/pagemap.h:11, from include/linux/blkdev.h:14, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/highmem-internal.h: At top level: >> include/linux/highmem-internal.h:98:21: error: conflicting types for 'kmap_atomic' 98 | static inline void *kmap_atomic(struct page *page) | ^~~~~~~~~~~ In file included from include/linux/mm.h:33, from include/linux/kallsyms.h:12, from include/linux/bpf.h:20, from include/linux/bpf-cgroup.h:5, from include/linux/cgroup-defs.h:22, from include/linux/cgroup.h:28, from include/linux/memcontrol.h:13, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/pgtable.h:79:12: note: previous implicit declaration of 'kmap_atomic' was here 79 | ((pte_t *)kmap_atomic(pmd_page(*(dir))) + \ | ^~~~~~~~~~~ include/linux/mm.h:2205:17: note: in expansion of macro 'pte_offset_map' 2205 | pte_t *__pte = pte_offset_map(pmd, address); \ | ^~~~~~~~~~~~~~ include/linux/mm.h:3174:13: note: in expansion of macro 'pte_offset_map_lock' 3174 | vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address, | ^~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:116: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1233: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/kmap_atomic +98 include/linux/highmem-internal.h 13f876ba77ebd5 Thomas Gleixner 2020-11-03 97 13f876ba77ebd5 Thomas Gleixner 2020-11-03 @98 static inline void *kmap_atomic(struct page *page) 13f876ba77ebd5 Thomas Gleixner 2020-11-03 99 { 13f876ba77ebd5 Thomas Gleixner 2020-11-03 100 return kmap_atomic_prot(page, kmap_prot); 13f876ba77ebd5 Thomas Gleixner 2020-11-03 101 } 13f876ba77ebd5 Thomas Gleixner 2020-11-03 102 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org