From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C5BC433ED for ; Sat, 1 May 2021 13:12:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EFB661480 for ; Sat, 1 May 2021 13:12:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232198AbhEANL5 (ORCPT ); Sat, 1 May 2021 09:11:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:48686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbhEANL5 (ORCPT ); Sat, 1 May 2021 09:11:57 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E494B61462; Sat, 1 May 2021 13:11:05 +0000 (UTC) Date: Sat, 1 May 2021 09:11:04 -0400 From: Steven Rostedt To: Cc: , , , , , , , , , , , , Subject: Re: [PATCH 1/2] tracing: Add a trace for task_exit Message-ID: <20210501091104.418765bd@oasis.local.home> In-Reply-To: <4bb24db4-f720-f5e7-9054-36bdeaee1d79@sony.com> References: <20210430142223.25500-1-peter.enderborg@sony.com> <20210430142223.25500-2-peter.enderborg@sony.com> <4bb24db4-f720-f5e7-9054-36bdeaee1d79@sony.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 1 May 2021 09:29:41 +0000 wrote: > On 4/30/21 7:48 PM, Eric W. Biederman wrote: > > Peter Enderborg writes: > > > >> This is the peer functions to task_rename and task_newtask. > >> With this we get hole "life-cycle" of task and can easily > >> see short livied task and their exit status. > > This patch is incorrect. The location you are dealing with is not part > > of task exit. The location you have instrumented is part of reaping a > > task which can come arbitrarily long after the task exits. > > That is what it aiming. When using this as tool for userspace you > would like to know when the task is done. When it no longer > holds any thing that might have any impact. If you think the > exit imply something more specific I can change the name. > > I thought exit was a good name, it is in in exit.c. > > Will the name task_done, task_finished or task_reaped work for you? I think "task_reaped" is probably the best name, and the most descriptive of what happened. -- Steve