From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 2/3] package/libtomcrypt: compile with -fPIC to enable linking to dynamic libraries/exectuables
Date: Sun, 2 May 2021 12:15:59 +0200 [thread overview]
Message-ID: <20210502121559.4be14012@gmx.net> (raw)
In-Reply-To: <d32ab74d-8bfb-34b0-0767-884ece0bb087@mind.be>
Hello Arnout,
On Sat, 1 May 2021 15:19:37 +0200, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 12/04/2021 21:55, Peter Seiderer wrote:
> > Fixes:
> >
> > .../x86_64-buildroot-linux-gnu/bin/ld: .../host/x86_64-buildroot-linux-gnu/sysroot/usr/lib/libtomcrypt.a(md5.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> > package/libtomcrypt/libtomcrypt.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/libtomcrypt/libtomcrypt.mk b/package/libtomcrypt/libtomcrypt.mk
> > index fa6dde64cd..b6ad77daec 100644
> > --- a/package/libtomcrypt/libtomcrypt.mk
> > +++ b/package/libtomcrypt/libtomcrypt.mk
> > @@ -17,7 +17,7 @@ LIBTOMCRYPT_DEPENDENCIES = libtommath
> > # 0001-fix-CVE-2019-17362.patch
> > LIBTOMCRYPT_IGNORE_CVES += CVE-2019-17362
> >
> > -LIBTOMCRYPT_CFLAGS = -I./src/headers $(TARGET_CFLAGS) -DLTC_SOURCE -DLTM_DESC
> > +LIBTOMCRYPT_CFLAGS = -I./src/headers $(TARGET_CFLAGS) -fPIC -DLTC_SOURCE -DLTM_DESC
>
> On some architectures, -fPIC is incompatible with static builds. So this should
> probably only be done in non-static builds.
O.k., will fix it...., thanks for review!
Regards,
Peter
>
> Marked as Changes Requested.
>
> Regards,
> Arnout
>
> >
> > define LIBTOMCRYPT_BUILD_CMDS
> > $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(LIBTOMCRYPT_CFLAGS)"
> >
next prev parent reply other threads:[~2021-05-02 10:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 19:55 [Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support Peter Seiderer
2021-04-12 19:55 ` [Buildroot] [PATCH v1 2/3] package/libtomcrypt: compile with -fPIC to enable linking to dynamic libraries/exectuables Peter Seiderer
2021-04-12 20:15 ` Thomas Petazzoni
2021-04-12 20:40 ` Peter Seiderer
2021-05-01 13:19 ` Arnout Vandecappelle
2021-05-02 10:15 ` Peter Seiderer [this message]
2021-04-12 19:55 ` [Buildroot] [PATCH v1 3/3] package/libtomcrypt: update home page URL to https Peter Seiderer
2021-05-01 13:19 ` Arnout Vandecappelle
2021-05-07 7:33 ` Peter Korsgaard
2021-04-12 20:14 ` [Buildroot] [PATCH v1 1/3] package/libtomcrypt: add pkgconfig support Thomas Petazzoni
2021-04-12 21:15 ` Peter Seiderer
2021-05-01 13:18 ` Arnout Vandecappelle
2021-05-02 10:27 ` Peter Seiderer
2021-05-03 7:58 ` Arnout Vandecappelle
2021-05-03 19:38 ` Peter Seiderer
2021-05-04 7:28 ` Arnout Vandecappelle
2021-05-06 19:45 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210502121559.4be14012@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.