From: Khaled Romdhani <khaledromdhani216@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] fs/btrfs: Fix uninitialized variable
Date: Mon, 3 May 2021 11:13:12 +0100 [thread overview]
Message-ID: <20210503101312.GA27593@ard0534> (raw)
In-Reply-To: <20210503072322.GK1981@kadam>
On Mon, May 03, 2021 at 10:23:22AM +0300, Dan Carpenter wrote:
> On Sat, May 01, 2021 at 11:50:46PM +0100, Khaled ROMDHANI wrote:
> > Fix the warning: variable 'zone' is used
> > uninitialized whenever '?:' condition is true.
> >
> > Fix that by preventing the code to reach
> > the last assertion. If the variable 'mirror'
> > is invalid, the assertion fails and we return
> > immediately.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
> > ---
>
> This is not how you send a v4 patch... v2 patches have to apply to the
> original code and not on top of the patched code.
>
> I sort of think you should find a different thing to work on. This code
> works fine as-is. Just leave it and try to find a real bug and fix that
> instead.
>
> regards,
> dan carpenter
>
Sorry, I was wrong and I shall send a proper V4.
Yes, this code works fine just a warning caught by Coverity scan analysis.
So the idea behind the patch is to fix the warning. To do that and as suggested by
David Sterba, it would be rather to add a default case. So we fix the warning
through the enhancement of the switch statement (some sort of 2*1).
Yes, I will always try to find other bugs. It is a pleasure for me to do that.
Thanks.
next prev parent reply other threads:[~2021-05-03 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-01 22:50 [PATCH] fs/btrfs: Fix uninitialized variable Khaled ROMDHANI
2021-05-02 10:17 ` Christophe JAILLET
2021-05-03 8:49 ` Khaled Romdhani
2021-05-03 7:23 ` Dan Carpenter
2021-05-03 10:13 ` Khaled Romdhani [this message]
2021-05-03 11:55 ` Dan Carpenter
2021-05-03 11:58 ` Colin Ian King
2021-05-17 10:51 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503101312.GA27593@ard0534 \
--to=khaledromdhani216@gmail.com \
--cc=clm@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.