From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94F3C433B4 for ; Mon, 3 May 2021 13:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DCB261283 for ; Mon, 3 May 2021 13:37:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234328AbhECNiI (ORCPT ); Mon, 3 May 2021 09:38:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:36896 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233550AbhECNiH (ORCPT ); Mon, 3 May 2021 09:38:07 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 34E1CB08C; Mon, 3 May 2021 13:37:13 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id C8051DA783; Mon, 3 May 2021 15:34:47 +0200 (CEST) Date: Mon, 3 May 2021 15:34:47 +0200 From: David Sterba To: Anand Jain Cc: fdmanana@gmail.com, linux-btrfs , Chris Murphy Subject: Re: [PATCH] btrfs: fix unmountable seed device after fstrim Message-ID: <20210503133447.GH7604@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , fdmanana@gmail.com, linux-btrfs , Chris Murphy References: <8a545d8d-0bdd-4cf5-1a65-fbdbeecb9b33@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a545d8d-0bdd-4cf5-1a65-fbdbeecb9b33@oracle.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Apr 30, 2021 at 08:48:56PM +0800, Anand Jain wrote: > On 30/4/21 8:14 pm, Filipe Manana wrote: > > On Fri, Apr 30, 2021 at 1:03 PM Anand Jain wrote: > > > > The fix looks good. Don't feel forced to address the style comments > > above, consider them more a recommendation for the future. > > > > Yep. Thanks. > Also, I have missed the re-roll count and its log here. > I will just mention that here. > v2: > Fix commit changelog. > Drop a code comment. > If David needs, I don't mind resending with these changes. Not needed, I'm often adjusting changelog formatting so I'd do the suggested fixups anyway. Patch added to misc-next, thanks.