From: Rob Herring <robh@kernel.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: ata: Add device tree binding fir Mikrotik RB532 PATA controller
Date: Mon, 3 May 2021 14:28:05 -0500 [thread overview]
Message-ID: <20210503192805.GA2232229@robh.at.kernel.org> (raw)
In-Reply-To: <20210428163336.73125-3-tsbogend@alpha.franken.de>
On Wed, Apr 28, 2021 at 06:33:36PM +0200, Thomas Bogendoerfer wrote:
> Add YAML devicetree binding for Mikrotik RB532 PATA controller.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
> .../bindings/ata/mikrotek,rb532-pata.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/mikrotek,rb532-pata.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/mikrotek,rb532-pata.yaml b/Documentation/devicetree/bindings/ata/mikrotek,rb532-pata.yaml
> new file mode 100644
> index 000000000000..f74880c4fd82
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/mikrotek,rb532-pata.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/mikrotek,rb532-pata.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mikrotek RB532 PATA Controller bindings
We have a common binding for this (ata/pata-common.yaml). Really, all
you'd gain is how to support 2 devices is defined. Should you use that?
Is CompactFlash only a single device, I don't remember. If so, is that a
limitation for the board or could 2 devices be supported?
> +
> +maintainers:
> + - Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> +
> +properties:
> + compatible:
> + const: mikrotik,rb532-pata
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + gpio:
'<name>-gpios' is the preferred form (even for singular).
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - gpio
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + cf@18a10000 {
> + compatible = "mikrotik,rb532-pata";
> + reg = <0x18a10000 0xc04>;
> +
> + gpio = <&gpio0 13 0>;
> +
> + interrupt-parent = <&gpio0>;
> + interrupts = <13 0>;
> + };
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-05-03 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 16:33 [PATCH v2 1/3] ata: pata_rb532: Make driver COMPILE_TESTable Thomas Bogendoerfer
2021-04-28 16:33 ` [PATCH v2 2/3] ata: pata_rb532: Add device tree support Thomas Bogendoerfer
2021-04-28 16:33 ` [PATCH v2 3/3] dt-bindings: ata: Add device tree binding fir Mikrotik RB532 PATA controller Thomas Bogendoerfer
2021-05-03 19:28 ` Rob Herring [this message]
2021-05-03 20:58 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503192805.GA2232229@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.