All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	linux-integrity@vger.kernel.org
Cc: Elvira Khabirova <lineprinter0@gmail.com>
Subject: [PATCH v2 0/3] ima-evm-utils: Add --keyid option
Date: Tue,  4 May 2021 07:33:54 +0300	[thread overview]
Message-ID: <20210504043357.4093409-1-vt@altlinux.org> (raw)

Allow user to set signature's keyid using `--keyid' option. Keyid should
correspond to SKID in certificate, when keyid is calculated using SHA-1
in libimaevm it may mismatch keyid extracted by the kernel from SKID of
certificate (the way public key is presented to the kernel), thus making
signatures not verifiable. This may happen when certificate is using non
SHA-1 SKID (see rfc7093) or just 'unique number' (see rfc5280 4.2.1.2).
As a last resort user may specify arbitrary keyid using the new option.
Third option is to read keyid from the cert appended to the key file.

These commits create backward compatible ABI change for libimaevm,
because of adding additional parameter to imaevm_params - older
libimaevm can work with newer client.

Changes from v1:
- Extract keyid from cert associated to key file.
- Use sizeof instead of constant.

Changes since rfc version:
- `imaevm_params.keyid' now stored as native integer (instead of network
  order). Suggested by Stefan Berger.
  - Added support for `--keyid=@filename'.

Vitaly Chikunov (3):
  ima-evm-utils: Allow manual setting keyid for signing
  ima-evm-utils: Allow manual setting keyid from a cert file
  ima-evm-utils: Read keyid from the cert appended to the key file

 README                 |  4 +++
 src/evmctl.c           | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/imaevm.h           |  1 +
 src/libimaevm.c        | 52 ++++++++++++++++++++++++++++--
 tests/sign_verify.test |  2 ++
 5 files changed, 142 insertions(+), 3 deletions(-)

-- 
2.11.0


             reply	other threads:[~2021-05-04  4:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04  4:33 Vitaly Chikunov [this message]
2021-05-04  4:33 ` [PATCH v2 1/3] ima-evm-utils: Allow manual setting keyid for signing Vitaly Chikunov
2021-05-04 12:51   ` Stefan Berger
2021-05-04 23:18     ` Vitaly Chikunov
2021-05-04 23:43       ` Dmitry V. Levin
2021-05-06  1:15         ` Vitaly Chikunov
2021-05-04  4:33 ` [PATCH v2 2/3] ima-evm-utils: Allow manual setting keyid from a cert file Vitaly Chikunov
2021-05-04 13:04   ` Stefan Berger
2021-05-04 23:21     ` Vitaly Chikunov
2021-05-04 13:28   ` Stefan Berger
2021-05-04  4:33 ` [PATCH v2 3/3] ima-evm-utils: Read keyid from the cert appended to the key file Vitaly Chikunov
2021-05-04 13:38   ` Stefan Berger
2021-05-04 22:27     ` Vitaly Chikunov
2021-05-05  1:04       ` Stefan Berger
2021-05-05  1:15         ` Vitaly Chikunov
2021-05-05  5:15           ` Vitaly Chikunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210504043357.4093409-1-vt@altlinux.org \
    --to=vt@altlinux.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=lineprinter0@gmail.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.