All of lore.kernel.org
 help / color / mirror / Atom feed
From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: u-boot@lists.denx.de
Subject: [RFC 4/7] pinctrl: mscc: Fix multiple definition error
Date: Tue, 4 May 2021 09:51:57 +0200	[thread overview]
Message-ID: <20210504075157.rkp5rmh2247xyosx@soft-dev3-1.localhost> (raw)
In-Reply-To: <20210503204859.18756-5-trini@konsulko.com>

The 05/03/2021 16:48, Tom Rini wrote:
> 
> With gcc-11 we get a multiple errors here as the declarations for
> mscc_pinctrl_ops and mscc_gpio_ops are missing an extern.

Reviewed-by: Horatiu Vultur <horatiu.vultur@microchip.com>

> 
> CC: Gregory CLEMENT <gregory.clement@bootlin.com>
> Cc: Lars Povlsen <lars.povlsen@microchip.com>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  drivers/pinctrl/mscc/mscc-common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/mscc/mscc-common.h b/drivers/pinctrl/mscc/mscc-common.h
> index 3c5c1faf840f..49c84a9f410b 100644
> --- a/drivers/pinctrl/mscc/mscc-common.h
> +++ b/drivers/pinctrl/mscc/mscc-common.h
> @@ -61,6 +61,6 @@ int mscc_pinctrl_probe(struct udevice *dev, int num_func,
>                        const struct mscc_pin_data *mscc_pins, int num_pins,
>                        char * const *function_names,
>                        const unsigned long *mscc_gpios);
> -const struct pinctrl_ops mscc_pinctrl_ops;
> +extern const struct pinctrl_ops mscc_pinctrl_ops;
> 
> -const struct dm_gpio_ops mscc_gpio_ops;
> +extern const struct dm_gpio_ops mscc_gpio_ops;
> --
> 2.17.1
> 

-- 
/Horatiu

  reply	other threads:[~2021-05-04  7:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 20:48 [RFC 0/7] Update CI to using GCC 11.0 / LLVM-11 Tom Rini
2021-05-03 20:48 ` [RFC 1/7] ARM: mvebu: a38x: Correct mismatched bound warnings Tom Rini
2021-07-07 17:33   ` Tom Rini
2021-07-14 20:52   ` Pali Rohár
2021-07-15  7:59     ` Stefan Roese
2021-07-15 13:07       ` [EXT] " Kostya Porotchkin
2021-05-03 20:48 ` [RFC 2/7] freescale: Drop unnecessary cpld_data_t non-typedef Tom Rini
2021-07-07 17:34   ` Tom Rini
2021-05-03 20:48 ` [RFC 3/7] eb_cpu5282: Declare diplay_width / display_height as externs Tom Rini
2021-07-07 17:34   ` Tom Rini
2021-05-03 20:48 ` [RFC 4/7] pinctrl: mscc: Fix multiple definition error Tom Rini
2021-05-04  7:51   ` Horatiu Vultur [this message]
2021-05-04 18:57   ` Daniel Schwierzeck
2021-07-07 17:34   ` Tom Rini
2021-05-03 20:48 ` [RFC 5/7] Makefile: Disable gcc-10.0 warnings Tom Rini
2021-07-07 17:34   ` Tom Rini
2021-05-03 20:48 ` [RFC 6/7] bootstage: Eliminate when not enabled Tom Rini
2021-07-07 17:34   ` Tom Rini
2021-05-03 20:48 ` [RFC 7/7] TEST: Move to gcc-11.0 prerelease and LLVM-11 Tom Rini
2021-06-16 19:58   ` [RFCv2] " Tom Rini
2021-06-16 20:00   ` [RFCv3] Azure/GitLab: Move to gcc-11.1.0 " Tom Rini
2021-06-17  8:27     ` Bin Meng
2021-06-17 12:31       ` Tom Rini
2021-06-17 14:09         ` Bin Meng
2021-06-17 14:14           ` Tom Rini
2021-06-17 14:24             ` Bin Meng
2021-06-17 14:45               ` Tom Rini
2021-06-17 14:51                 ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210504075157.rkp5rmh2247xyosx@soft-dev3-1.localhost \
    --to=horatiu.vultur@microchip.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.