From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7556AC43461 for ; Wed, 5 May 2021 12:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 508EB61132 for ; Wed, 5 May 2021 12:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233396AbhEEMhd (ORCPT ); Wed, 5 May 2021 08:37:33 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3031 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhEEMh2 (ORCPT ); Wed, 5 May 2021 08:37:28 -0400 Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FZwwq3HLLz6rlcd; Wed, 5 May 2021 20:28:27 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 5 May 2021 14:36:29 +0200 Received: from localhost (10.52.120.138) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 13:36:28 +0100 Date: Wed, 5 May 2021 13:34:50 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: , , Ezequiel Garcia , Hans Verkuil , "Krzysztof Kozlowski" , Mauro Carvalho Chehab , Sylwester Nawrocki , , , , Subject: Re: [PATCH 24/25] media: exynos-gsc: fix pm_runtime_get_sync() usage count Message-ID: <20210505133450.00001fda@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.120.138] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 May 2021 11:42:14 +0200 Mauro Carvalho Chehab wrote: > The pm_runtime_get_sync() internally increments the > dev->power.usage_count without decrementing it, even on errors. > Replace it by the new pm_runtime_resume_and_get(), introduced by: > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > in order to properly decrement the usage counter, avoiding > a potential PM usage counter leak. > > As a bonus, as pm_runtime_get_sync() always return 0 on > success, the logic can be simplified. > > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron > --- > drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c > index 27a3c92c73bc..f1cf847d1cc2 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c > +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c > @@ -56,10 +56,8 @@ static void __gsc_m2m_job_abort(struct gsc_ctx *ctx) > static int gsc_m2m_start_streaming(struct vb2_queue *q, unsigned int count) > { > struct gsc_ctx *ctx = q->drv_priv; > - int ret; > > - ret = pm_runtime_get_sync(&ctx->gsc_dev->pdev->dev); > - return ret > 0 ? 0 : ret; > + return pm_runtime_resume_and_get(&ctx->gsc_dev->pdev->dev); > } > > static void __gsc_m2m_cleanup_queue(struct gsc_ctx *ctx) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F4BFC433B4 for ; Wed, 5 May 2021 12:38:05 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6C4561132 for ; Wed, 5 May 2021 12:38:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6C4561132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=Huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tX9bgsDdj24Ci8F/KCGEHsM6KGcD6+jH/I3M/UGSE9c=; b=ooPv0Pe2c1HWo8RRWFJip/htI HwYHI29RprcjkgURdo4+AtcnvqOxc6/NFfZnAPyy03Ejqha70xPTTacTzpvb2/F348S/rjB+Ra4eY 98UpqB8oENnjr2/41nLKxJhHMpx45EvaV+n0llFiLkDqyXPl7nziW1VNfpwL9/ILZnWnsmoJa4yyt XvxXT4RuclqPZSbuzefspV0k1HNFJQisaMGQAZUQ3W3FnXNe37OlQpwo+WG33S9VVn8jGvh/p8WUR /KpPGIB4ATyjCmzuQObD6sNWWm5F63oVlXj99O0PUIpFVWyeAkXfqK+YFspDk0AeM02nmTmzD96NR SBQa01MWQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leGlb-001DUh-0v; Wed, 05 May 2021 12:36:39 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leGlW-001DSc-3o for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 12:36:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=GHgzkU5Nu+2XbYFOqFkzLIb5LVt4qRfqH7iAZsJtGtw=; b=3SKX4X2TGps9wiQZoiisnhUgoD 95yYSrvmxVS8TPrg16xL9EHUgI/6SpF76BYf5FcS6F773lPqOdZiGSLGFX8dabdqU64Nf+ZhcwD/Z x7oMudre/AnJnxuggdRDr/cF3QrWzYGH2Fp/lqpJswyq50LHz/N/FmlyqHobTMDTu0uhU7mtiH76o PTST4tCQ83qOO6+VchXJdPu6zInVMEnvD3po9KMhyfx6L2849FMZ+sRsec1oCzQIXUMFB2tl++UTK Q9ATxmSNbfZD8Yu0Nr2JfkfEW5J8rN+7HudDgnMV6WPvpRe5scCWC32YolcRbzQF8gEp/HJrQGmRV PO6aKa5w==; Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leGlT-004kfN-Bn for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 12:36:32 +0000 Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FZwwq3HLLz6rlcd; Wed, 5 May 2021 20:28:27 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 5 May 2021 14:36:29 +0200 Received: from localhost (10.52.120.138) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 5 May 2021 13:36:28 +0100 Date: Wed, 5 May 2021 13:34:50 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: , , Ezequiel Garcia , Hans Verkuil , "Krzysztof Kozlowski" , Mauro Carvalho Chehab , Sylwester Nawrocki , , , , Subject: Re: [PATCH 24/25] media: exynos-gsc: fix pm_runtime_get_sync() usage count Message-ID: <20210505133450.00001fda@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.52.120.138] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_053631_581527_7D5BDE1B X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 5 May 2021 11:42:14 +0200 Mauro Carvalho Chehab wrote: > The pm_runtime_get_sync() internally increments the > dev->power.usage_count without decrementing it, even on errors. > Replace it by the new pm_runtime_resume_and_get(), introduced by: > commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") > in order to properly decrement the usage counter, avoiding > a potential PM usage counter leak. > > As a bonus, as pm_runtime_get_sync() always return 0 on > success, the logic can be simplified. > > Reviewed-by: Sylwester Nawrocki > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Jonathan Cameron > --- > drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c > index 27a3c92c73bc..f1cf847d1cc2 100644 > --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c > +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c > @@ -56,10 +56,8 @@ static void __gsc_m2m_job_abort(struct gsc_ctx *ctx) > static int gsc_m2m_start_streaming(struct vb2_queue *q, unsigned int count) > { > struct gsc_ctx *ctx = q->drv_priv; > - int ret; > > - ret = pm_runtime_get_sync(&ctx->gsc_dev->pdev->dev); > - return ret > 0 ? 0 : ret; > + return pm_runtime_resume_and_get(&ctx->gsc_dev->pdev->dev); > } > > static void __gsc_m2m_cleanup_queue(struct gsc_ctx *ctx) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel