From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B336C433B4 for ; Wed, 5 May 2021 16:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E502613C7 for ; Wed, 5 May 2021 16:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233739AbhEEQFg (ORCPT ); Wed, 5 May 2021 12:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:48638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233502AbhEEQFe (ORCPT ); Wed, 5 May 2021 12:05:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B6893613B3; Wed, 5 May 2021 16:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620230677; bh=cTM8g/gKs3w7f3SKpfx5R9tQ4aTb7xARUcSs/9imTcI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XuD8VZzVX2EySNepWfffqri6VedVVZQGkeTDWQIzwXT+4xV3nRr7KQ3BaL8uBhOj2 oRdBt1iLLzQwLBt5vpJXTK60/knqkx87AJdwTvw1lhwhqWUMNTpUZnNmwtwgsvS+z/ hm2TUwUqepC+tiHwpX+VVcBc92bVuLPh53jiyy/sx3yJ7k+iY7i1PDH84ZqXKAij8z GbbUxf/HFT/GAqn9QTlgyR/vASAO3uu1lqHbO38tlWasAhe82wMc6XUmMUUMBD5uIi vRcezoa9KzvwWeN7ANAJHZ2HSiaprrmRSxELqbpibgeaL9SDVOdvgm5k9+A2/IdX1Y H8yRQSEHJwW3w== Date: Wed, 5 May 2021 18:04:33 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: <20210505180433.550178c8@thinkpad> In-Reply-To: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 May 2021 14:22:49 +0200 Andrew Lunn wrote: > On Thu, Apr 29, 2021 at 10:36:31AM +0200, Pali Roh=C3=A1r wrote: > > From: Marek Beh=C3=BAn > >=20 > > The status decoding function mox_get_status() currently contains a dead > > code path: if the error status is not MBOX_STS_SUCCESS, it always > > returns -EIO, so the comparison to MBOX_STS_FAIL is never executed and > > we don't get the actual error code sent by the firmware. > >=20 > > Fix this. > >=20 > > Signed-off-by: Marek Beh=C3=BAn > > Fixes: 389711b37493 ("firmware: Add Turris Mox rWTM firmware driver") = =20 >=20 > You have put a fixes tag here, meaning you want it in stable? How does > dead code elimination fulfil the stable requirements? >=20 > Do any of these changes contain real fixes? >=20 > Andrew Andrew, this is not dead code elimination. Rather it is that there is dead code path due to an incorrect check. By correcting the check, the dead code path becomes alive and starts reporting errors correctly. This fix is nedeed in stable so that stable will report errors correctly. Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBEEBC433ED for ; Wed, 5 May 2021 16:07:01 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B2946109E for ; Wed, 5 May 2021 16:07:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B2946109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N2vcm5QjEkxrmXZguZB0bOvJpji6l87McfwFdF7a8bQ=; b=q7OQ+j4QblC2A7SI0iGwHQHT1 ckhhgUQmBqdhEtAe/qVkCUTiBRWWwE81Cg6Yh6oaZS8kYo4oJiwBVHuWRTPgu4MmYEn/uAb49bQaa 5tu4X4Z8kqywyUHSZMAz4W3cpyDcK6qJndCVvbjFF2eaTDvYI99uxYU58hIdIKKHiLUxn1MtS0Ig3 qVN4aWdtPSVGI3jS00G/MxV6iCO3gnhvz1n4k1zE2mNOTYKfA1wsotZSvjPATt57wNtX1981NNY5v mF+w0IiIsU2WN1GYS5ZfkSWmjLbHYxXz/kqYzmKv3+IzP/JXQItyLHFYC5Wd/kYbSz6TG4dflaYzJ wqXhU9jXw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leK0z-001bkN-Q2; Wed, 05 May 2021 16:04:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leK0v-001bk9-J4 for linux-arm-kernel@desiato.infradead.org; Wed, 05 May 2021 16:04:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Sender:Reply-To:Content-ID:Content-Description; bh=r8/7ZtCLL1Va6vp5ewQew1YGByJVrv6DRDDNA1R0ZM4=; b=NacdAJ1bzx54UKXyoO72d2cDQH hcPopY6qhvmsYN7gyOYVepG5FkQmy9A7JXSCq/ZqJr12xvglVae/7p16ukBT1boD1QU+ywH7uFN7b Qmn2hxhbxFJH8donaVQzOQSDIb0FIP3aJudYw0g4iqqivIdOzmOjGz3BUC7CaTDSv3Xk4KiXu9ni5 HH0Mmsz0c5ZrIgQwfrOg4iEg+dvT+2iv8Fbt4MOhL154yPBY9imCDLRwd8H84sjqAWdz5t1f1vMqi wueQJJT0sQu4cpR28+vxFVXRZgF9bGoX1ILGg4PRFYlXbHy9sNLpRjA3uESiXBDYtTSEUJoVxfoHp anSOEh4g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leK0s-004uSR-Vw for linux-arm-kernel@lists.infradead.org; Wed, 05 May 2021 16:04:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B6893613B3; Wed, 5 May 2021 16:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620230677; bh=cTM8g/gKs3w7f3SKpfx5R9tQ4aTb7xARUcSs/9imTcI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XuD8VZzVX2EySNepWfffqri6VedVVZQGkeTDWQIzwXT+4xV3nRr7KQ3BaL8uBhOj2 oRdBt1iLLzQwLBt5vpJXTK60/knqkx87AJdwTvw1lhwhqWUMNTpUZnNmwtwgsvS+z/ hm2TUwUqepC+tiHwpX+VVcBc92bVuLPh53jiyy/sx3yJ7k+iY7i1PDH84ZqXKAij8z GbbUxf/HFT/GAqn9QTlgyR/vASAO3uu1lqHbO38tlWasAhe82wMc6XUmMUUMBD5uIi vRcezoa9KzvwWeN7ANAJHZ2HSiaprrmRSxELqbpibgeaL9SDVOdvgm5k9+A2/IdX1Y H8yRQSEHJwW3w== Date: Wed, 5 May 2021 18:04:33 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Andrew Lunn Cc: Pali =?UTF-8?B?Um9ow6Fy?= , Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 mvebu + mvebu/dt64 1/6] firmware: turris-mox-rwtm: fix reply status decoding function Message-ID: <20210505180433.550178c8@thinkpad> In-Reply-To: References: <20210308153703.23097-1-kabel@kernel.org> <20210429083636.22560-1-pali@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210505_090439_075769_185BC7EF X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAzIE1heSAyMDIxIDE0OjIyOjQ5ICswMjAwCkFuZHJldyBMdW5uIDxhbmRyZXdAbHVu bi5jaD4gd3JvdGU6Cgo+IE9uIFRodSwgQXByIDI5LCAyMDIxIGF0IDEwOjM2OjMxQU0gKzAyMDAs IFBhbGkgUm9ow6FyIHdyb3RlOgo+ID4gRnJvbTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJuZWwu b3JnPgo+ID4gCj4gPiBUaGUgc3RhdHVzIGRlY29kaW5nIGZ1bmN0aW9uIG1veF9nZXRfc3RhdHVz KCkgY3VycmVudGx5IGNvbnRhaW5zIGEgZGVhZAo+ID4gY29kZSBwYXRoOiBpZiB0aGUgZXJyb3Ig c3RhdHVzIGlzIG5vdCBNQk9YX1NUU19TVUNDRVNTLCBpdCBhbHdheXMKPiA+IHJldHVybnMgLUVJ Tywgc28gdGhlIGNvbXBhcmlzb24gdG8gTUJPWF9TVFNfRkFJTCBpcyBuZXZlciBleGVjdXRlZCBh bmQKPiA+IHdlIGRvbid0IGdldCB0aGUgYWN0dWFsIGVycm9yIGNvZGUgc2VudCBieSB0aGUgZmly bXdhcmUuCj4gPiAKPiA+IEZpeCB0aGlzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYXJlayBC ZWjDum4gPGthYmVsQGtlcm5lbC5vcmc+Cj4gPiBGaXhlczogMzg5NzExYjM3NDkzICgiZmlybXdh cmU6IEFkZCBUdXJyaXMgTW94IHJXVE0gZmlybXdhcmUgZHJpdmVyIikgIAo+IAo+IFlvdSBoYXZl IHB1dCBhIGZpeGVzIHRhZyBoZXJlLCBtZWFuaW5nIHlvdSB3YW50IGl0IGluIHN0YWJsZT8gSG93 IGRvZXMKPiBkZWFkIGNvZGUgZWxpbWluYXRpb24gZnVsZmlsIHRoZSBzdGFibGUgcmVxdWlyZW1l bnRzPwo+IAo+IERvIGFueSBvZiB0aGVzZSBjaGFuZ2VzIGNvbnRhaW4gcmVhbCBmaXhlcz8KPiAK PiAgICBBbmRyZXcKCkFuZHJldywgdGhpcyBpcyBub3QgZGVhZCBjb2RlIGVsaW1pbmF0aW9uLiBS YXRoZXIgaXQgaXMgdGhhdCB0aGVyZSBpcwpkZWFkIGNvZGUgcGF0aCBkdWUgdG8gYW4gaW5jb3Jy ZWN0IGNoZWNrLiBCeSBjb3JyZWN0aW5nIHRoZSBjaGVjaywgdGhlCmRlYWQgY29kZSBwYXRoIGJl Y29tZXMgYWxpdmUgYW5kIHN0YXJ0cyByZXBvcnRpbmcgZXJyb3JzIGNvcnJlY3RseS4KVGhpcyBm aXggaXMgbmVkZWVkIGluIHN0YWJsZSBzbyB0aGF0IHN0YWJsZSB3aWxsIHJlcG9ydCBlcnJvcnMK Y29ycmVjdGx5LgoKTWFyZWsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK