From: Michal Kubecek <mkubecek@suse.cz>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: netdev@vger.kernel.org, atenart@kernel.org
Subject: Re: [PATCH net] ethtool: fix missing NLM_F_MULTI flag when dumping
Date: Wed, 5 May 2021 23:09:19 +0200 [thread overview]
Message-ID: <20210505210919.ronrecenr3qrfuuf@lion.mk-sys.cz> (raw)
In-Reply-To: <20210504224714.7632-1-ffmancera@riseup.net>
On Wed, May 05, 2021 at 12:47:14AM +0200, Fernando Fernandez Mancera wrote:
> When dumping the ethtool information from all the interfaces, the
> netlink reply should contain the NLM_F_MULTI flag. This flag allows
> userspace tools to identify that multiple messages are expected.
>
> Link: https://bugzilla.redhat.com/1953847
> Fixes: 365f9ae ("ethtool: fix genlmsg_put() failure handling in ethnl_default_dumpit()")
For the record, the issue was not introduced by this commit, this commit
only moved the genlmsg_put() call from ethnl_default_dumpit() into
ethnl_default_dump_one() but genlmsg_put() was called with zero flags
since the code was introduced by commit 728480f12442 ("ethtool: default
handlers for GET requests").
But as the patch has been applied already, it doesn't matter any more.
Michal
> Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
> ---
> net/ethtool/netlink.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
> index 290012d0d11d..88d8a0243f35 100644
> --- a/net/ethtool/netlink.c
> +++ b/net/ethtool/netlink.c
> @@ -387,7 +387,8 @@ static int ethnl_default_dump_one(struct sk_buff *skb, struct net_device *dev,
> int ret;
>
> ehdr = genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq,
> - ðtool_genl_family, 0, ctx->ops->reply_cmd);
> + ðtool_genl_family, NLM_F_MULTI,
> + ctx->ops->reply_cmd);
> if (!ehdr)
> return -EMSGSIZE;
>
> --
> 2.20.1
>
prev parent reply other threads:[~2021-05-05 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 22:47 [PATCH net] ethtool: fix missing NLM_F_MULTI flag when dumping Fernando Fernandez Mancera
2021-05-05 19:50 ` patchwork-bot+netdevbpf
2021-05-05 21:09 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505210919.ronrecenr3qrfuuf@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=atenart@kernel.org \
--cc=ffmancera@riseup.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.