All of
 help / color / mirror / Atom feed
From: Nathan Chancellor <>
To: Thomas Gleixner <>,
	Ingo Molnar <>, Borislav Petkov <>,, Kees Cook <>
Cc: Arnd Bergmann <>,
	Nick Desaulniers <>,,,
	Nathan Chancellor <>,
	kernel test robot <>
Subject: [PATCH] Handle decrypted data section with !SMP
Date: Wed,  5 May 2021 17:14:11 -0700	[thread overview]
Message-ID: <> (raw)

With x86_64_defconfig and the following configs, there is an orphan
section warning:


ld: warning: orphan section `.data..decrypted' from `arch/x86/kernel/cpu/vmware.o' being placed in section `.data..decrypted'
ld: warning: orphan section `.data..decrypted' from `arch/x86/kernel/kvm.o' being placed in section `.data..decrypted'

These sections are created with DEFINE_PER_CPU_DECRYPTED, which
ultimately turns into __PCPU_ATTRS, which in turn has a section
attribute with a value of PER_CPU_BASE_SECTION + the section name. When
CONFIG_SMP is not set, the base section is .data and that is not
currently handled in any linker script.

Add .data..decrypted to PERCPU_DECRYPTED_SECTION, which is included in
PERCPU_INPUT -> PERCPU_SECTION, which is include in the x86 linker
script when either CONFIG_X86_64 or CONFIG_SMP is unset, taking care of
the warning.

Fixes: ac26963a1175 ("percpu: Introduce DEFINE_PER_CPU_DECRYPTED")
Reported-by: kernel test robot <>
Signed-off-by: Nathan Chancellor <>

I took the simple fix route with this patch since I highly doubt someone
is actually running a CONFIG_AMD_MEM_ENCRYPT=y + CONFIG_SMP=n kernel. If
this section should actually be in .data, I can respin.

 include/asm-generic/ | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/asm-generic/ b/include/asm-generic/
index 40a9c101565e..17325416e2de 100644
--- a/include/asm-generic/
+++ b/include/asm-generic/
@@ -960,6 +960,7 @@
 	. = ALIGN(PAGE_SIZE);						\
+	*(.data..decrypted)						\
 	*(.data..percpu..decrypted)					\

base-commit: 8404c9fbc84b741f66cff7d4934a25dd2c344452

             reply	other threads:[~2021-05-06  0:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  0:14 Nathan Chancellor [this message]
2021-05-06 18:15 ` [PATCH] Handle decrypted data section with !SMP Nick Desaulniers
2021-06-04 18:03 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.