From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3275AC433B4 for ; Thu, 6 May 2021 15:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6B28613BA for ; Thu, 6 May 2021 15:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235209AbhEFPgG (ORCPT ); Thu, 6 May 2021 11:36:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:45970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235368AbhEFPdq (ORCPT ); Thu, 6 May 2021 11:33:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA209613F5; Thu, 6 May 2021 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315168; bh=u1gZ4iCJ8EZuBq5+caF8WVSL+jyHUTpCgbqmTBAr8V8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oFxyk95u1LyOsMCxTvvj4v2FldyAmFLbYC+G5ZQUrf/8Oy6C4dBjQRshqVOcaJpa1 klQB3MKtwfzwXlRdVNPPoaWwfgzwpSAw4G70CyI2iDJnlcoe2+6b6eka574kPB8pzV Xx72qrVdMlzTcxcPycxRnXnPTk2Fc5s4V/MbLbQ7qEDTORl+/KEMs26dWYrfoXnds2 o72XlXW3fgi4p5CgxtAMtsYDOYuadBgvTpKNk39zm+GbdPz/QhsilUYN7hLp9J6nDD CKd2cu5Ch49OZbOAbRfSSVDxFSW2ifiT77d9s1eVsc2jmqLm3337CyRns3bRN1MZgX 0V1+ETSGO/hVg== Received: by pali.im (Postfix) id 819311208; Thu, 6 May 2021 17:32:46 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/42] PCI: aardvark: Fix PCIe Max Payload Size setting Date: Thu, 6 May 2021 17:31:20 +0200 Message-Id: <20210506153153.30454-10-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change PCIe Max Payload Size setting in PCIe Device Control register to 512 bytes to align with PCIe Link Initialization sequence as defined in Marvell Armada 3700 Functional Specification. According to the specification, maximal Max Payload Size supported by this device is 512 bytes. Without this kernel prints suspicious line: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 16384, max 512) With this change it changes to: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 512, max 512) Signed-off-by: Pali Rohár Reviewed-by: Marek Behún Cc: stable@vger.kernel.org --- drivers/pci/controller/pci-aardvark.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index edeacd95297e..873efd79fffb 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -351,8 +351,9 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie) reg = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL); reg &= ~PCI_EXP_DEVCTL_RELAX_EN; reg &= ~PCI_EXP_DEVCTL_NOSNOOP_EN; + reg &= ~PCI_EXP_DEVCTL_PAYLOAD; reg &= ~PCI_EXP_DEVCTL_READRQ; - reg |= PCI_EXP_DEVCTL_PAYLOAD; /* Set max payload size */ + reg |= PCI_EXP_DEVCTL_PAYLOAD_512B; reg |= PCI_EXP_DEVCTL_READRQ_512B; advk_writel(pcie, reg, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A721C433B4 for ; Thu, 6 May 2021 15:38:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C78C5610A1 for ; Thu, 6 May 2021 15:38:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C78C5610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q0F74lVRLDh7fYneuoYAIG+Ul2yAID3/JqNETWh0wBQ=; b=JXwcPL1wSlBW8lnSaJcn4/7hA g7vbSq55ApcAo5YBouznZjvu/f+3NI0ZKkrOroVToBpkEi0/fzFYeZ4WcvPBOoNZJXxS0DAF7frxx tZ7uOqjo8mpeTBTC21ylHLf/OrSsALIT4I3e8f9Wvujx7P5cOsR64ef4KIQU5xwunONvk689YBc+T hFxE6DxleAshAVyCmmqLMnF5Teic+gyzrzl7RWSUM2VAZUBlXULP8LMrsNYtJQPY+r6br/1i6seKD 0uU4vQsUZ1pdYFuQ2qqJSwcLoGnLrMhrjxmy5oll7YGrnS8uMzWMDGZ3FKivFrOvoWLE/Z/kEsSmd KoJJJnakQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leg3A-004bHd-Ni; Thu, 06 May 2021 15:36:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzj-004a4J-Dj for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 15:32:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=KQv4wWaGTMgReekL3lhCKOxcCkvUXbzNA+I0qZY8+Cw=; b=g5f0vfur1S361yCjDMNiYp4IAd X2hulA8M8Tjsy4vq9v8pL76/sfvUBFy/7rHgRdp1ncXitYFB+7cOjlFGczgU0swLOIIKGg8MzGl6H HKqtixGrDGZBpVjZst9e0nT7zBx0XNnkiJHgqT69cc261tD6S5VTCex0p0REfGokHvVNbGzLoSWwB DZGMUU/mIQTxBSavIGWp+gvu4Ur+9978Q4InTxmOd2/Sh9WIU3eWE21kHbfUU6/jKpT2MqvKHUuJj 9sIvIrV9NYIw+i7rjuLeKS7591TedEQZm1yihTL4qgDp8MPUgCzRu+ThEnk79s6Xa+a9LY+10kVOh 4rtARMrg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lefzf-0069ha-7n for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 15:32:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id EA209613F5; Thu, 6 May 2021 15:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620315168; bh=u1gZ4iCJ8EZuBq5+caF8WVSL+jyHUTpCgbqmTBAr8V8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oFxyk95u1LyOsMCxTvvj4v2FldyAmFLbYC+G5ZQUrf/8Oy6C4dBjQRshqVOcaJpa1 klQB3MKtwfzwXlRdVNPPoaWwfgzwpSAw4G70CyI2iDJnlcoe2+6b6eka574kPB8pzV Xx72qrVdMlzTcxcPycxRnXnPTk2Fc5s4V/MbLbQ7qEDTORl+/KEMs26dWYrfoXnds2 o72XlXW3fgi4p5CgxtAMtsYDOYuadBgvTpKNk39zm+GbdPz/QhsilUYN7hLp9J6nDD CKd2cu5Ch49OZbOAbRfSSVDxFSW2ifiT77d9s1eVsc2jmqLm3337CyRns3bRN1MZgX 0V1+ETSGO/hVg== Received: by pali.im (Postfix) id 819311208; Thu, 6 May 2021 17:32:46 +0200 (CEST) From: =?UTF-8?q?Pali=20Roh=C3=A1r?= To: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas Cc: Russell King , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/42] PCI: aardvark: Fix PCIe Max Payload Size setting Date: Thu, 6 May 2021 17:31:20 +0200 Message-Id: <20210506153153.30454-10-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210506153153.30454-1-pali@kernel.org> References: <20210506153153.30454-1-pali@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_083251_393800_7BF03C5F X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Q2hhbmdlIFBDSWUgTWF4IFBheWxvYWQgU2l6ZSBzZXR0aW5nIGluIFBDSWUgRGV2aWNlIENvbnRy b2wgcmVnaXN0ZXIgdG8gNTEyCmJ5dGVzIHRvIGFsaWduIHdpdGggUENJZSBMaW5rIEluaXRpYWxp emF0aW9uIHNlcXVlbmNlIGFzIGRlZmluZWQgaW4gTWFydmVsbApBcm1hZGEgMzcwMCBGdW5jdGlv bmFsIFNwZWNpZmljYXRpb24uIEFjY29yZGluZyB0byB0aGUgc3BlY2lmaWNhdGlvbiwKbWF4aW1h bCBNYXggUGF5bG9hZCBTaXplIHN1cHBvcnRlZCBieSB0aGlzIGRldmljZSBpcyA1MTIgYnl0ZXMu CgpXaXRob3V0IHRoaXMga2VybmVsIHByaW50cyBzdXNwaWNpb3VzIGxpbmU6CgogICAgcGNpIDAw MDA6MDE6MDAuMDogVXBzdHJlYW0gYnJpZGdlJ3MgTWF4IFBheWxvYWQgU2l6ZSBzZXQgdG8gMjU2 ICh3YXMgMTYzODQsIG1heCA1MTIpCgpXaXRoIHRoaXMgY2hhbmdlIGl0IGNoYW5nZXMgdG86Cgog ICAgcGNpIDAwMDA6MDE6MDAuMDogVXBzdHJlYW0gYnJpZGdlJ3MgTWF4IFBheWxvYWQgU2l6ZSBz ZXQgdG8gMjU2ICh3YXMgNTEyLCBtYXggNTEyKQoKU2lnbmVkLW9mZi1ieTogUGFsaSBSb2jDoXIg PHBhbGlAa2VybmVsLm9yZz4KUmV2aWV3ZWQtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVs Lm9yZz4KQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKLS0tCiBkcml2ZXJzL3BjaS9jb250cm9s bGVyL3BjaS1hYXJkdmFyay5jIHwgMyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3Bj aS1hYXJkdmFyay5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwppbmRl eCBlZGVhY2Q5NTI5N2UuLjg3M2VmZDc5ZmZmYiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29u dHJvbGxlci9wY2ktYWFyZHZhcmsuYworKysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1h YXJkdmFyay5jCkBAIC0zNTEsOCArMzUxLDkgQEAgc3RhdGljIHZvaWQgYWR2a19wY2llX3NldHVw X2h3KHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUpCiAJcmVnID0gYWR2a19yZWFkbChwY2llLCBQQ0lF X0NPUkVfUENJRVhQX0NBUCArIFBDSV9FWFBfREVWQ1RMKTsKIAlyZWcgJj0gflBDSV9FWFBfREVW Q1RMX1JFTEFYX0VOOwogCXJlZyAmPSB+UENJX0VYUF9ERVZDVExfTk9TTk9PUF9FTjsKKwlyZWcg Jj0gflBDSV9FWFBfREVWQ1RMX1BBWUxPQUQ7CiAJcmVnICY9IH5QQ0lfRVhQX0RFVkNUTF9SRUFE UlE7Ci0JcmVnIHw9IFBDSV9FWFBfREVWQ1RMX1BBWUxPQUQ7IC8qIFNldCBtYXggcGF5bG9hZCBz aXplICovCisJcmVnIHw9IFBDSV9FWFBfREVWQ1RMX1BBWUxPQURfNTEyQjsKIAlyZWcgfD0gUENJ X0VYUF9ERVZDVExfUkVBRFJRXzUxMkI7CiAJYWR2a193cml0ZWwocGNpZSwgcmVnLCBQQ0lFX0NP UkVfUENJRVhQX0NBUCArIFBDSV9FWFBfREVWQ1RMKTsKIAotLSAKMi4yMC4xCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=