From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDACCC433B4 for ; Thu, 6 May 2021 23:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA6326121F for ; Thu, 6 May 2021 23:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230464AbhEFXLO (ORCPT ); Thu, 6 May 2021 19:11:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:44406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbhEFXLJ (ORCPT ); Thu, 6 May 2021 19:11:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AC94E6105A; Thu, 6 May 2021 23:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620342611; bh=pGwapwfIwZOhQarw96L9tvVjL5uL4dSL5MqgEDL7QV4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VS40+lW6QNMPALXuZKJZKkfsBtDahDjCHJwNqZN03r9k6KqwKZ+xuvARenFSzbPD8 2le/gXGEBrCurSqiQzGSplBT9ZoiQREwp5u3HXehJ0GBFE1lLn24VZe99Psx4F+2GL po33WChdPWTjY/tASJDhYyGILjoJwgIB9THQNwwuqkUdEsCjBfaHy3VXj23jzua583 uLeOaFRu5Mx0UauIOmXTJ1NruJe+dHW1rE9hvbtR6/Wf5dOrFfbFIK7bhrjdyEt1Gx W3WkzxrhPqbagLj2WtWXEepVAGVp3VIhaqWfHMEI1COk4Bryru5O0REmMKmCBbtYMW DEyf4K3ARYSlQ== Date: Thu, 6 May 2021 18:10:09 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/42] PCI: pci-bridge-emul: Add PCIe Root Capabilities Register Message-ID: <20210506231009.GA1444269@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210506153153.30454-6-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 06, 2021 at 05:31:16PM +0200, Pali Rohár wrote: > This is 16-bit register at offset 0x1E. Rename current 'rsvd' struct member > to 'rootcap'. "The 16-bit Root Capabilities register is at offset 0x1e in the PCIe Capability." Please make the commit log complete in itself. In some contexts, the subject line is not visible at the same time. It's fine to repeat the subject in the commit log. > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún > Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space common logic") > Cc: stable@vger.kernel.org # e0d9d30b7354 ("PCI: pci-bridge-emul: Fix big-endian support") I'm not sure how people would deal with *two* SHA1s. This patch adds functionality, so it's not really fixing a bug in 23a5fba4d941. I see that e0d9d30b7354 came along later and did "s/u16 rsvd/__le16 rsvd/". But it seems like a lot to expect for distros and stable kernel maintainers to interpret this. Personally I think I would omit both Fixes: and the stable tag since these two patches (05 and 06) are just adding functionality. > --- > drivers/pci/pci-bridge-emul.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-bridge-emul.h b/drivers/pci/pci-bridge-emul.h > index b31883022a8e..49bbd37ee318 100644 > --- a/drivers/pci/pci-bridge-emul.h > +++ b/drivers/pci/pci-bridge-emul.h > @@ -54,7 +54,7 @@ struct pci_bridge_emul_pcie_conf { > __le16 slotctl; > __le16 slotsta; > __le16 rootctl; > - __le16 rsvd; > + __le16 rootcap; > __le32 rootsta; > __le32 devcap2; > __le16 devctl2; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85413C433B4 for ; Thu, 6 May 2021 23:12:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2298610E9 for ; Thu, 6 May 2021 23:12:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2298610E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=NUhkYTPV4PcQg/6bMZJkKdXtw8rMl+reuLR4TyAfA0c=; b=l/VQia7jrYih3tcSKUr9Qdz/V MNV9oPxlOOHAIXK2Mt4ZGkwUFYixaihu/GNlUFfbEL533JpvctJrcOYw9/oEC06BhSpVnkPPOND2t s8C5Tm5xEGRCHINnIqa/o+sdfR+zO2ytgYmJSNjtcM9CP+Y2pa24a4jNauWnSAKdf4VyzTub5V0e9 3T7g6hCA5+5tQMr9+1nPvvZpSgm33HgNhmDovanDuYp5YUK0RWfMN9mO2tqE1BqCgk8wYM9jTkcO3 GgOsuyuoxNcb153qyUeIrchKqhjyXYZhsHd1QdXwRtEYesej17jie2jFiJf2dOXYCN9D4RU5XPIJX mJH5W4SZQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1len8L-005Xwz-Rs; Thu, 06 May 2021 23:10:18 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1len8I-005Xwb-Pk for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 23:10:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To :Content-ID:Content-Description:References; bh=X7izR75q2GwR0oLQJvVxvETfgTMUAzAm6NgacU7pRTU=; b=ZTM59zrkKurKK/+3THId2ktJL0 q3GLGW71I4XHt+NgjtEYCpAvsMBJo5sbWoCmEhoW1EhzPv1KpbCXlOt+wgxR2wko8c9cI7wVS79Os ZBG5igEolOOnUN1oMOy1IPZgdbbETpJi06sQQdHIYrFQPTjbfh6I/hbnkpHkN85YhZWMrgwdcUSji 5zjnB5ZvDV/0Z8AM64VhpQe6Z252jRAbF1Q6eMJd2vcCijPT1jhZ/Y5w0baZOsK/B3nDNuUDFzz8P O9S68YHMURmNMa1FyNAOLlyPKgAZoRd+4HeJjcX8RhQ1hOJ0zvKAmFowDVA4hrGFTTC0mXwEO/yXF epON9w8g==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1len8F-006RWr-Bp for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 23:10:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id AC94E6105A; Thu, 6 May 2021 23:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620342611; bh=pGwapwfIwZOhQarw96L9tvVjL5uL4dSL5MqgEDL7QV4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VS40+lW6QNMPALXuZKJZKkfsBtDahDjCHJwNqZN03r9k6KqwKZ+xuvARenFSzbPD8 2le/gXGEBrCurSqiQzGSplBT9ZoiQREwp5u3HXehJ0GBFE1lLn24VZe99Psx4F+2GL po33WChdPWTjY/tASJDhYyGILjoJwgIB9THQNwwuqkUdEsCjBfaHy3VXj23jzua583 uLeOaFRu5Mx0UauIOmXTJ1NruJe+dHW1rE9hvbtR6/Wf5dOrFfbFIK7bhrjdyEt1Gx W3WkzxrhPqbagLj2WtWXEepVAGVp3VIhaqWfHMEI1COk4Bryru5O0REmMKmCBbtYMW DEyf4K3ARYSlQ== Date: Thu, 6 May 2021 18:10:09 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/42] PCI: pci-bridge-emul: Add PCIe Root Capabilities Register Message-ID: <20210506231009.GA1444269@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210506153153.30454-6-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_161011_447249_AE920086 X-CRM114-Status: GOOD ( 19.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 06, 2021 at 05:31:16PM +0200, Pali Roh=E1r wrote: > This is 16-bit register at offset 0x1E. Rename current 'rsvd' struct memb= er > to 'rootcap'. "The 16-bit Root Capabilities register is at offset 0x1e in the PCIe Capability." Please make the commit log complete in itself. In some contexts, the subject line is not visible at the same time. It's fine to repeat the subject in the commit log. > Signed-off-by: Pali Roh=E1r > Reviewed-by: Marek Beh=FAn > Fixes: 23a5fba4d941 ("PCI: Introduce PCI bridge emulated config space com= mon logic") > Cc: stable@vger.kernel.org # e0d9d30b7354 ("PCI: pci-bridge-emul: Fix big= -endian support") I'm not sure how people would deal with *two* SHA1s. This patch adds functionality, so it's not really fixing a bug in 23a5fba4d941. I see that e0d9d30b7354 came along later and did "s/u16 rsvd/__le16 rsvd/". But it seems like a lot to expect for distros and stable kernel maintainers to interpret this. Personally I think I would omit both Fixes: and the stable tag since these two patches (05 and 06) are just adding functionality. > --- > drivers/pci/pci-bridge-emul.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/pci/pci-bridge-emul.h b/drivers/pci/pci-bridge-emul.h > index b31883022a8e..49bbd37ee318 100644 > --- a/drivers/pci/pci-bridge-emul.h > +++ b/drivers/pci/pci-bridge-emul.h > @@ -54,7 +54,7 @@ struct pci_bridge_emul_pcie_conf { > __le16 slotctl; > __le16 slotsta; > __le16 rootctl; > - __le16 rsvd; > + __le16 rootcap; > __le32 rootsta; > __le32 devcap2; > __le16 devctl2; > -- = > 2.20.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel