Hi Robert, I love your patch! Yet something to improve: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on hwmon/hwmon-next gpio/for-next v5.12 next-20210506] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Robert-Marko/mfd-Add-Delta-TN48M-CPLD-driver/20210430-203709 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/4a3a37836c56a383a726a52892d69bfdd1cf5d4c git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Robert-Marko/mfd-Add-Delta-TN48M-CPLD-driver/20210430-203709 git checkout 4a3a37836c56a383a726a52892d69bfdd1cf5d4c # save the attached .config to linux build tree make W=1 W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/mfd/tn48m-cpld.c: In function 'hardware_version_show': >> drivers/mfd/tn48m-cpld.c:36:10: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration] 36 | switch (FIELD_GET(HARDWARE_VERSION_MASK, regval)) { | ^~~~~~~~~ cc1: some warnings being treated as errors vim +/FIELD_GET +36 drivers/mfd/tn48m-cpld.c 27 28 static int hardware_version_show(struct seq_file *s, void *data) 29 { 30 struct tn48m_data *priv = s->private; 31 unsigned int regval; 32 char *buf; 33 34 regmap_read(priv->regmap, HARDWARE_VERSION_ID, ®val); 35 > 36 switch (FIELD_GET(HARDWARE_VERSION_MASK, regval)) { 37 case HARDWARE_VERSION_EVT1: 38 buf = "EVT1"; 39 break; 40 case HARDWARE_VERSION_EVT2: 41 buf = "EVT2"; 42 break; 43 case HARDWARE_VERSION_DVT: 44 buf = "DVT"; 45 break; 46 case HARDWARE_VERSION_PVT: 47 buf = "PVT"; 48 break; 49 default: 50 buf = "Unknown"; 51 break; 52 } 53 54 seq_printf(s, "%s\n", buf); 55 56 return 0; 57 } 58 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org