From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDA2C43461 for ; Fri, 7 May 2021 00:55:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DAF860E0B for ; Fri, 7 May 2021 00:55:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233911AbhEGA4U (ORCPT ); Thu, 6 May 2021 20:56:20 -0400 Received: from mail-ot1-f52.google.com ([209.85.210.52]:39728 "EHLO mail-ot1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbhEGA4S (ORCPT ); Thu, 6 May 2021 20:56:18 -0400 Received: by mail-ot1-f52.google.com with SMTP id 65-20020a9d03470000b02902808b4aec6dso6581466otv.6; Thu, 06 May 2021 17:55:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LOi26ePLcMhTv9NBLT2b9h8iasffGUoNExW6gEB59Hg=; b=nkZPUIgYWEnvyDe8ZKAwFGnqhTuwIZBstfOuvoMmLC/7BMdYFENqOh18wPjuUZ+R5+ FRuGUAegWiA175Z00mYQvHg2OgaQ/toD/KJbkx04aLxFd4sf5sL0nXqptzTQuWbYzgKe HUOaMyoqnJ9oI0LbKNNyHRscimMOkZSpNO9/yqY70cOJXXEahcUk53WmlWievkM8ZvlD JoiO27X6tNluin+rT1GgsDHvx/OxCgJuxfuARu58ne2ooF1oD+atcdpMJQZQhfWxRYm7 ERCS3JxeMFZqckcsuz/k1JMyN4X0+WK5VdHskbL6u3cjfcgYphIXO/ogwHTsuZ7hzk0X SXqg== X-Gm-Message-State: AOAM533ibCcWjZPVPNxUBB+UJ012+wviYX/AJLTIKW8OUt9eiBad9u21 2OiEvuadVeR67YOQC1e++o7E4EXUwQ== X-Google-Smtp-Source: ABdhPJxeyomDM66blWkjlzllouut9B4dA4muWExmIjhFAk5mmRPq+Z8eGugC9Zp/pbuJPuBLvSakTA== X-Received: by 2002:a9d:6244:: with SMTP id i4mr5796115otk.182.1620348919518; Thu, 06 May 2021 17:55:19 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g9sm805749oop.30.2021.05.06.17.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 17:55:18 -0700 (PDT) Received: (nullmailer pid 1101099 invoked by uid 1000); Fri, 07 May 2021 00:55:17 -0000 Date: Thu, 6 May 2021 19:55:17 -0500 From: Rob Herring To: Alain Volmat Cc: wsa@kernel.org, mark.rutland@arm.com, pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com Subject: Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Message-ID: <20210507005517.GA1098665@robh.at.kernel.org> References: <1620220479-2647-1-git-send-email-alain.volmat@foss.st.com> <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) This needs to be added to i2c-bus.yaml too. Acked-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index df41f72afc87..b864916e087f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. > > - smbus > states that additional SMBus restrictions and features apply to this bus. > - Examples of features are SMBusHostNotify and SMBusAlert. Examples of > - restrictions are more reserved addresses and timeout definitions. > + An example of feature is SMBusHostNotify. Examples of restrictions are > + more reserved addresses and timeout definitions. > + > +- smbus-alert > + states that the optional SMBus-Alert feature apply to this bus. > > Required properties (per child device) > -------------------------------------- > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714D4C433ED for ; Fri, 7 May 2021 00:57:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1C2B610CE for ; Fri, 7 May 2021 00:57:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1C2B610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=i7uF7Wo6tHoUB4ge43gaNn9E/YQUDj3wY4qaw0L1ry4=; b=UHnwOM1rfbywf6snilT4YhSIU KfOwptByG9MIcbRHdRItOTZl7rX3yH733UL4zXaBLDfIl9rauZNcKsPHFczcLrlMsoFPgY/c9PidL 88nKQ2q0mw+WHUeRy+GxkS2g7fETolpGqe2tStLIk/KoIl6Xs+fJgbmTbVvpMgQb/mD2sIdW2iUhv aYCXeAgo8pRsoB9UfbuluPCLgbE0cy19nFvzywJQtJdwljVwnRzL+aNe0qc4x38uu5nwXbQ0Bd4E6 QlSMkZ0LXTxoynFRIaIV+RwwXaxmtNS5NZYkepAIwrHEEd23YUQnUBY33LdzLYaipIib8zuG3hT0Y Z+CZ2rCQw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leom8-005h50-Or; Fri, 07 May 2021 00:55:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leom4-005h4k-Fk for linux-arm-kernel@desiato.infradead.org; Fri, 07 May 2021 00:55:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LOi26ePLcMhTv9NBLT2b9h8iasffGUoNExW6gEB59Hg=; b=aSGaU6jrvhCTFdJYfqGMWPDmqO +H1N3FY1TUfXMvrTme8jR+952i/5RKY1pnUn/6midQBhLJa70OiQSOPNC62l4Sbj5rYCTN5DLja7y fpbzzSBPklv5mO7WGIWo3E9zCaUkGR+5CLPU6R2VzUVcJrfcmNPxyuvacHfSSZLare4Vr2iYVMEnO gids1oMD+Zi/7vW5rEWiDpP0HRQgKFuPxE9IAZ7B8g0i9Zusx01bJB1yLyAcLmKgGiMbc2DvxGRbN FLw6LaASFAPdL/Gh5R1wfhofsJIyBu+CBeE9cLydK75AOXaDyUzU55Nxpx++OirCqKQcY+Vb8iWa9 /ORiYKcg==; Received: from mail-ot1-f53.google.com ([209.85.210.53]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leom1-006TzZ-Oo for linux-arm-kernel@lists.infradead.org; Fri, 07 May 2021 00:55:23 +0000 Received: by mail-ot1-f53.google.com with SMTP id r26-20020a056830121ab02902a5ff1c9b81so6563730otp.11 for ; Thu, 06 May 2021 17:55:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LOi26ePLcMhTv9NBLT2b9h8iasffGUoNExW6gEB59Hg=; b=R5Kdg8j8q0FXY0C9Lzp4xtXJxBNGeuu2OgzWksTZTlsVSxicXJx1IVC17FrH4aIj6g AnYdqf9vChKQJLKfJ8fGHHSR4Ly5NS5iMq7xfy5W5rbHUMpUS+6IxOfXy8+gebVoujQj dpFUL4CC3iBeUlMO3t/+ZMX2ARwIu75pvKKl3Gvt+Ith8ou7vyxDzH8AIZM7R3Eipy5F DCwt44O2JHoQ7EIL/M/OeYbqEVN6/RhyzfDdRC87Lwrmmbdfhdv4qe42DC19HEe4Fl63 IY1L/WeeJ9zuAxeXpxSm08/C0gagT3/YDtfv29ehMmgczCBjg2Kas1SSq+H65DwMgBTe DuSQ== X-Gm-Message-State: AOAM532uSWjyR9HxrnCgDKlJwYNfba/RaVgnyNApA+M0LSZFPfWAzvEZ I83/RwKc6iSCtcPd/Notaw== X-Google-Smtp-Source: ABdhPJxeyomDM66blWkjlzllouut9B4dA4muWExmIjhFAk5mmRPq+Z8eGugC9Zp/pbuJPuBLvSakTA== X-Received: by 2002:a9d:6244:: with SMTP id i4mr5796115otk.182.1620348919518; Thu, 06 May 2021 17:55:19 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g9sm805749oop.30.2021.05.06.17.55.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 17:55:18 -0700 (PDT) Received: (nullmailer pid 1101099 invoked by uid 1000); Fri, 07 May 2021 00:55:17 -0000 Date: Thu, 6 May 2021 19:55:17 -0500 From: Rob Herring To: Alain Volmat Cc: wsa@kernel.org, mark.rutland@arm.com, pierre-yves.mordret@foss.st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fabrice.gasnier@foss.st.com Subject: Re: [PATCH v4 1/2] i2c: add binding to mark a bus as supporting SMBus-Alert Message-ID: <20210507005517.GA1098665@robh.at.kernel.org> References: <1620220479-2647-1-git-send-email-alain.volmat@foss.st.com> <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1620220479-2647-2-git-send-email-alain.volmat@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_175521_833405_00CB970F X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 05, 2021 at 03:14:38PM +0200, Alain Volmat wrote: > Since SMBus-Alert is an optional feature of SMBUS which > requires an additional pin, the smbus binding cannot be > used to indicate its support. > > Add an additional smbus-alert binding specific for it and > update the description text of smbus to avoid mentioning > SMBus-Alert > > Signed-off-by: Alain Volmat > --- > Documentation/devicetree/bindings/i2c/i2c.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) This needs to be added to i2c-bus.yaml too. Acked-by: Rob Herring > > diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt > index df41f72afc87..b864916e087f 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c.txt > +++ b/Documentation/devicetree/bindings/i2c/i2c.txt > @@ -89,8 +89,11 @@ wants to support one of the below features, it should adapt these bindings. > > - smbus > states that additional SMBus restrictions and features apply to this bus. > - Examples of features are SMBusHostNotify and SMBusAlert. Examples of > - restrictions are more reserved addresses and timeout definitions. > + An example of feature is SMBusHostNotify. Examples of restrictions are > + more reserved addresses and timeout definitions. > + > +- smbus-alert > + states that the optional SMBus-Alert feature apply to this bus. > > Required properties (per child device) > -------------------------------------- > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel