All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <mripard@kernel.org>,
	linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-rpi-kernel@lists.infradead.org,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec
Date: Fri,  7 May 2021 16:03:23 +0200	[thread overview]
Message-ID: <20210507140334.204865-1-maxime@cerno.tech> (raw)

Hi,\r
\r
hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place,\r
it's missing a few controls to be able to provide HBR passthrough. This series\r
adds more infrastructure for the drivers, and leverages it in the vc4 HDMI\r
controller driver.\r
\r
One thing that felt a bit weird is that even though\r
https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif\r
mentions that the iec958 mask control should be a mixer control and the\r
default control should be a PCM one, it feels a bit weird to have two different\r
control type for two controls so similar, and other drivers are pretty\r
inconsistent with this. Should we update the documentation?\r
\r
Thanks!\r
Maxime\r
\r
Dom Cobley (5):\r
  drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET\r
  drm/vc4: hdmi: Set HDMI_MAI_FMT\r
  drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE\r
  drm/vc4: hdmi: Remove firmware logic for MAI threshold setting\r
  ARM: dts: bcm2711: Tune DMA parameters for HDMI audio\r
\r
Maxime Ripard (6):\r
  snd: iec958: split status creation and fill\r
  ASoC: hdmi-codec: Rework to support more controls\r
  ASoC: hdmi-codec: Add iec958 controls\r
  ASoC: hdmi-codec: Add a prepare hook\r
  drm/vc4: hdmi: Register HDMI codec\r
  drm/vc4: hdmi: Remove redundant variables\r
\r
 arch/arm/boot/dts/bcm2711.dtsi |   4 +-\r
 drivers/gpu/drm/vc4/Kconfig    |   1 +\r
 drivers/gpu/drm/vc4/vc4_hdmi.c | 322 ++++++++++++++-------------------\r
 drivers/gpu/drm/vc4/vc4_hdmi.h |   5 +-\r
 drivers/gpu/drm/vc4/vc4_regs.h |  30 +++\r
 include/sound/hdmi-codec.h     |  12 +-\r
 include/sound/pcm_iec958.h     |   8 +\r
 sound/core/pcm_iec958.c        | 131 +++++++++-----\r
 sound/soc/codecs/hdmi-codec.c  | 219 +++++++++++++++++-----\r
 9 files changed, 456 insertions(+), 276 deletions(-)\r
\r
-- \r
2.31.1\r
\r

WARNING: multiple messages have this Message-ID
From: Maxime Ripard <maxime@cerno.tech>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Dom Cobley <dom@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
	Eric Anholt <eric@anholt.net>, Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Daniel Vetter <daniel@ffwll.ch>,
	Phil Elwell <phil@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec
Date: Fri,  7 May 2021 16:03:23 +0200	[thread overview]
Message-ID: <20210507140334.204865-1-maxime@cerno.tech> (raw)

Hi,\r
\r
hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place,\r
it's missing a few controls to be able to provide HBR passthrough. This series\r
adds more infrastructure for the drivers, and leverages it in the vc4 HDMI\r
controller driver.\r
\r
One thing that felt a bit weird is that even though\r
https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif\r
mentions that the iec958 mask control should be a mixer control and the\r
default control should be a PCM one, it feels a bit weird to have two different\r
control type for two controls so similar, and other drivers are pretty\r
inconsistent with this. Should we update the documentation?\r
\r
Thanks!\r
Maxime\r
\r
Dom Cobley (5):\r
  drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET\r
  drm/vc4: hdmi: Set HDMI_MAI_FMT\r
  drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE\r
  drm/vc4: hdmi: Remove firmware logic for MAI threshold setting\r
  ARM: dts: bcm2711: Tune DMA parameters for HDMI audio\r
\r
Maxime Ripard (6):\r
  snd: iec958: split status creation and fill\r
  ASoC: hdmi-codec: Rework to support more controls\r
  ASoC: hdmi-codec: Add iec958 controls\r
  ASoC: hdmi-codec: Add a prepare hook\r
  drm/vc4: hdmi: Register HDMI codec\r
  drm/vc4: hdmi: Remove redundant variables\r
\r
 arch/arm/boot/dts/bcm2711.dtsi |   4 +-\r
 drivers/gpu/drm/vc4/Kconfig    |   1 +\r
 drivers/gpu/drm/vc4/vc4_hdmi.c | 322 ++++++++++++++-------------------\r
 drivers/gpu/drm/vc4/vc4_hdmi.h |   5 +-\r
 drivers/gpu/drm/vc4/vc4_regs.h |  30 +++\r
 include/sound/hdmi-codec.h     |  12 +-\r
 include/sound/pcm_iec958.h     |   8 +\r
 sound/core/pcm_iec958.c        | 131 +++++++++-----\r
 sound/soc/codecs/hdmi-codec.c  | 219 +++++++++++++++++-----\r
 9 files changed, 456 insertions(+), 276 deletions(-)\r
\r
-- \r
2.31.1\r
\r

WARNING: multiple messages have this Message-ID
From: Maxime Ripard <maxime@cerno.tech>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	Maxime Ripard <mripard@kernel.org>,
	linux-kernel@vger.kernel.org,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dom Cobley <dom@raspberrypi.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-rpi-kernel@lists.infradead.org,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec
Date: Fri,  7 May 2021 16:03:23 +0200	[thread overview]
Message-ID: <20210507140334.204865-1-maxime@cerno.tech> (raw)

Hi,

hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place,
it's missing a few controls to be able to provide HBR passthrough. This series
adds more infrastructure for the drivers, and leverages it in the vc4 HDMI
controller driver.

One thing that felt a bit weird is that even though
https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif
mentions that the iec958 mask control should be a mixer control and the
default control should be a PCM one, it feels a bit weird to have two different
control type for two controls so similar, and other drivers are pretty
inconsistent with this. Should we update the documentation?

Thanks!
Maxime

Dom Cobley (5):
  drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET
  drm/vc4: hdmi: Set HDMI_MAI_FMT
  drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE
  drm/vc4: hdmi: Remove firmware logic for MAI threshold setting
  ARM: dts: bcm2711: Tune DMA parameters for HDMI audio

Maxime Ripard (6):
  snd: iec958: split status creation and fill
  ASoC: hdmi-codec: Rework to support more controls
  ASoC: hdmi-codec: Add iec958 controls
  ASoC: hdmi-codec: Add a prepare hook
  drm/vc4: hdmi: Register HDMI codec
  drm/vc4: hdmi: Remove redundant variables

 arch/arm/boot/dts/bcm2711.dtsi |   4 +-
 drivers/gpu/drm/vc4/Kconfig    |   1 +
 drivers/gpu/drm/vc4/vc4_hdmi.c | 322 ++++++++++++++-------------------
 drivers/gpu/drm/vc4/vc4_hdmi.h |   5 +-
 drivers/gpu/drm/vc4/vc4_regs.h |  30 +++
 include/sound/hdmi-codec.h     |  12 +-
 include/sound/pcm_iec958.h     |   8 +
 sound/core/pcm_iec958.c        | 131 +++++++++-----
 sound/soc/codecs/hdmi-codec.c  | 219 +++++++++++++++++-----
 9 files changed, 456 insertions(+), 276 deletions(-)

-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID
From: Maxime Ripard <maxime@cerno.tech>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Maxime Ripard <maxime@cerno.tech>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	Dom Cobley <dom@raspberrypi.com>,
	Tim Gover <tim.gover@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	Phil Elwell <phil@raspberrypi.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec
Date: Fri,  7 May 2021 16:03:23 +0200	[thread overview]
Message-ID: <20210507140334.204865-1-maxime@cerno.tech> (raw)

Hi,\r
\r
hdmi-codec allows to have a lot of HDMI-audio related infrastructure in place,\r
it's missing a few controls to be able to provide HBR passthrough. This series\r
adds more infrastructure for the drivers, and leverages it in the vc4 HDMI\r
controller driver.\r
\r
One thing that felt a bit weird is that even though\r
https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-driver.html#iec958-s-pdif\r
mentions that the iec958 mask control should be a mixer control and the\r
default control should be a PCM one, it feels a bit weird to have two different\r
control type for two controls so similar, and other drivers are pretty\r
inconsistent with this. Should we update the documentation?\r
\r
Thanks!\r
Maxime\r
\r
Dom Cobley (5):\r
  drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET\r
  drm/vc4: hdmi: Set HDMI_MAI_FMT\r
  drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE\r
  drm/vc4: hdmi: Remove firmware logic for MAI threshold setting\r
  ARM: dts: bcm2711: Tune DMA parameters for HDMI audio\r
\r
Maxime Ripard (6):\r
  snd: iec958: split status creation and fill\r
  ASoC: hdmi-codec: Rework to support more controls\r
  ASoC: hdmi-codec: Add iec958 controls\r
  ASoC: hdmi-codec: Add a prepare hook\r
  drm/vc4: hdmi: Register HDMI codec\r
  drm/vc4: hdmi: Remove redundant variables\r
\r
 arch/arm/boot/dts/bcm2711.dtsi |   4 +-\r
 drivers/gpu/drm/vc4/Kconfig    |   1 +\r
 drivers/gpu/drm/vc4/vc4_hdmi.c | 322 ++++++++++++++-------------------\r
 drivers/gpu/drm/vc4/vc4_hdmi.h |   5 +-\r
 drivers/gpu/drm/vc4/vc4_regs.h |  30 +++\r
 include/sound/hdmi-codec.h     |  12 +-\r
 include/sound/pcm_iec958.h     |   8 +\r
 sound/core/pcm_iec958.c        | 131 +++++++++-----\r
 sound/soc/codecs/hdmi-codec.c  | 219 +++++++++++++++++-----\r
 9 files changed, 456 insertions(+), 276 deletions(-)\r
\r
-- \r
2.31.1\r
\r

             reply	other threads:[~2021-05-07 14:04 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 14:03 Maxime Ripard [this message]
2021-05-07 14:03 ` [PATCH 01/11] snd: iec958: split status creation and fill Maxime Ripard
2021-05-25  7:33   ` Takashi Iwai
2021-05-25  9:33     ` Maxime Ripard
2021-05-07 14:03 ` [PATCH 02/11] ASoC: hdmi-codec: Rework to support more controls Maxime Ripard
2021-05-07 14:03 ` [PATCH 03/11] ASoC: hdmi-codec: Add iec958 controls Maxime Ripard
2021-05-07 14:03 ` [PATCH 04/11] ASoC: hdmi-codec: Add a prepare hook Maxime Ripard
2021-05-07 14:03 ` [PATCH 05/11] drm/vc4: hdmi: Set HD_CTL_WHOLSMP and HD_CTL_CHALIGN_SET Maxime Ripard
2021-05-07 14:03 ` [PATCH 06/11] drm/vc4: hdmi: Set HDMI_MAI_FMT Maxime Ripard
2021-05-07 14:03 ` [PATCH 07/11] drm/vc4: hdmi: Set VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE Maxime Ripard
2021-05-07 14:03 ` [PATCH 08/11] drm/vc4: hdmi: Remove firmware logic for MAI threshold setting Maxime Ripard
2021-05-07 14:03 ` [PATCH 09/11] drm/vc4: hdmi: Register HDMI codec Maxime Ripard
2021-05-07 19:23   ` kernel test robot
2021-05-07 14:03 ` [PATCH 10/11] drm/vc4: hdmi: Remove redundant variables Maxime Ripard
2021-05-07 14:03 ` [PATCH 11/11] ARM: dts: bcm2711: Tune DMA parameters for HDMI audio Maxime Ripard
2021-05-24 13:39 ` [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Maxime Ripard
2021-05-25  8:35   ` Takashi Iwai
2021-05-25  9:23     ` Maxime Ripard
2021-05-25  9:27       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210507140334.204865-1-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=broonie@kernel.org \
    --cc=daniel.vetter@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dom@raspberrypi.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=perex@perex.cz \
    --cc=phil@raspberrypi.com \
    --cc=robh+dt@kernel.org \
    --cc=tim.gover@raspberrypi.com \
    --cc=tiwai@suse.com \
    --cc=tzimmermann@suse.de \
    --subject='Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.