All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 1/1] um: fix error return code in winch_tramp()
Date: Sat, 8 May 2021 11:22:39 +0800	[thread overview]
Message-ID: <20210508032239.2177-1-thunder.leizhen@huawei.com> (raw)

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 89df6bfc0405 ("uml: DEBUG_SHIRQ fixes")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/um/drivers/chan_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/um/drivers/chan_user.c b/arch/um/drivers/chan_user.c
index d8845d4aac6a..6040817c036f 100644
--- a/arch/um/drivers/chan_user.c
+++ b/arch/um/drivers/chan_user.c
@@ -256,7 +256,8 @@ static int winch_tramp(int fd, struct tty_port *port, int *fd_out,
 		goto out_close;
 	}
 
-	if (os_set_fd_block(*fd_out, 0)) {
+	err = os_set_fd_block(*fd_out, 0);
+	if (err) {
 		printk(UM_KERN_ERR "winch_tramp: failed to set thread_fd "
 		       "non-blocking.\n");
 		goto out_close;
-- 
2.25.1



WARNING: multiple messages have this Message-ID (diff)
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Jeff Dike <jdike@addtoit.com>,
	Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Eduard-Gabriel Munteanu <maxdamage@aladin.ro>,
	linux-um <linux-um@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 1/1] um: fix error return code in winch_tramp()
Date: Sat, 8 May 2021 11:22:39 +0800	[thread overview]
Message-ID: <20210508032239.2177-1-thunder.leizhen@huawei.com> (raw)

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 89df6bfc0405 ("uml: DEBUG_SHIRQ fixes")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 arch/um/drivers/chan_user.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/um/drivers/chan_user.c b/arch/um/drivers/chan_user.c
index d8845d4aac6a..6040817c036f 100644
--- a/arch/um/drivers/chan_user.c
+++ b/arch/um/drivers/chan_user.c
@@ -256,7 +256,8 @@ static int winch_tramp(int fd, struct tty_port *port, int *fd_out,
 		goto out_close;
 	}
 
-	if (os_set_fd_block(*fd_out, 0)) {
+	err = os_set_fd_block(*fd_out, 0);
+	if (err) {
 		printk(UM_KERN_ERR "winch_tramp: failed to set thread_fd "
 		       "non-blocking.\n");
 		goto out_close;
-- 
2.25.1



_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


             reply	other threads:[~2021-05-08  3:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  3:22 Zhen Lei [this message]
2021-05-08  3:22 ` [PATCH 1/1] um: fix error return code in winch_tramp() Zhen Lei
2021-05-08  9:13 ` Anton Ivanov
2021-05-08  9:13   ` Anton Ivanov
2022-03-23 19:41 ` Nathan Chancellor
2022-03-23 19:41   ` Nathan Chancellor
2022-03-24 12:40   ` Thorsten Leemhuis
2022-03-24 12:40     ` Thorsten Leemhuis
2022-05-31  8:17     ` [PATCH 1/1] um: fix error return code in winch_tramp() #forregzbot Thorsten Leemhuis
2022-04-10  8:41   ` [PATCH 1/1] um: fix error return code in winch_tramp() Thorsten Leemhuis
2022-04-10  8:41     ` Thorsten Leemhuis
2022-04-10  9:33     ` Richard Weinberger
2022-04-10  9:33       ` Richard Weinberger
2022-04-11 17:48       ` Nathan Chancellor
2022-04-11 17:48         ` Nathan Chancellor
2022-04-11 18:45         ` Richard Weinberger
2022-04-11 18:45           ` Richard Weinberger
2022-05-20  6:08           ` Thorsten Leemhuis
2022-05-20  6:08             ` Thorsten Leemhuis
2022-05-20 15:55             ` Nathan Chancellor
2022-05-20 15:55               ` Nathan Chancellor
2022-05-20 17:18               ` Johannes Berg
2022-05-20 17:18                 ` Johannes Berg
2022-05-20 17:31                 ` Nathan Chancellor
2022-05-20 17:31                   ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210508032239.2177-1-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=jdike@addtoit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=maxdamage@aladin.ro \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.