From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Jakub Kicinski <kuba@kernel.org>,
Joakim Zhang <qiangqing.zhang@nxp.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Cc: "peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"joabreu@synopsys.com" <joabreu@synopsys.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V4 net] net: stmmac: Fix MAC WoL not working if PHY does not support WoL
Date: Sat, 8 May 2021 17:05:29 +0800 [thread overview]
Message-ID: <20210508170529.2b7aedbd@xhacker.debian> (raw)
In-Reply-To: <20210507154624.31186614@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 7 May 2021 15:46:24 -0700 Jakub Kicinski wrote:
>
>
> On Fri, 7 May 2021 10:59:12 +0000 Joakim Zhang wrote:
> > > On Thu, 6 May 2021 13:06:58 +0800 Joakim Zhang wrote:
> > > > Both get and set WoL will check device_can_wakeup(), if MAC supports
> > > > PMT, it will set device wakeup capability. After commit 1d8e5b0f3f2c ("net:
> > > > stmmac: Support WOL with phy"), device wakeup capability will be
> > > > overwrite in stmmac_init_phy() according to phy's Wol feature. If phy
> > > > doesn't support WoL, then MAC will lose wakeup capability.
> > >
> > > Let's take a step back. Can we get a minimal fix for losing the config in
> > > stmmac_init_phy(), and then extend the support for WoL for devices which do
> > > support wake up themselves?
> >
> > Sure, please review the V1, I think this is a minimal fix, then we
> > can extend this as a new feature.
I lost the v1 patch in my email inbox, but I found it by searching it in
web and reviewed v1. If going this way(a minimal fix then make improvements
in net-next) feel free to add below reviewed-by tag for the v1 patch:
Reviewed-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
>
> Something like that, yes (you can pull the get_wol call into the same
> if block).
>
> Andrew, would that be acceptable to you? As limited as the either/or
> approach is it should not break any existing users, and the fix needs
> to go to longterm 5.10. We could make the improvements in net-next?
>
next prev parent reply other threads:[~2021-05-08 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 5:06 [PATCH V4 net] net: stmmac: Fix MAC WoL not working if PHY does not support WoL Joakim Zhang
2021-05-07 0:55 ` Jakub Kicinski
2021-05-07 10:59 ` Joakim Zhang
2021-05-07 22:46 ` Jakub Kicinski
2021-05-08 9:05 ` Jisheng Zhang [this message]
2021-05-08 18:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508170529.2b7aedbd@xhacker.debian \
--to=jisheng.zhang@synaptics.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.