All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Collingbourne <pcc@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	George Popescu <georgepope@android.com>,
	Elena Petrova <lenaptr@google.com>,
	Evgenii Stepanov <eugenis@google.com>,
	linux-mm@kvack.org, stable@vger.kernel.org
Subject: Re: [PATCH] kasan: fix unit tests with CONFIG_UBSAN_LOCAL_BOUNDS enabled
Date: Sat, 8 May 2021 17:30:09 -0700	[thread overview]
Message-ID: <20210508173009.781b8a401fefc2ab71cb3907@linux-foundation.org> (raw)
In-Reply-To: <20210506212025.815380-1-pcc@google.com>

On Thu,  6 May 2021 14:20:25 -0700 Peter Collingbourne <pcc@google.com> wrote:

> These tests deliberately access these arrays out of bounds,
> which will cause the dynamic local bounds checks inserted by
> CONFIG_UBSAN_LOCAL_BOUNDS to fail and panic the kernel. To avoid this
> problem, access the arrays via volatile pointers, which will prevent
> the compiler from being able to determine the array bounds.

Huh.  Is this use of volatile the official way of suppressing the
generation of the checking code or is it just something which happened
to work?  I'm wondering if this workaround should be formalized in some
fashion (presumably a wrapper) rather than mysteriously and
unexplainedly open-coding it like this.


  parent reply	other threads:[~2021-05-09  0:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 21:20 [PATCH] kasan: fix unit tests with CONFIG_UBSAN_LOCAL_BOUNDS enabled Peter Collingbourne
2021-05-06 21:20 ` Peter Collingbourne
2021-05-06 22:12 ` Andrey Konovalov
2021-05-06 22:12   ` Andrey Konovalov
2021-05-06 23:47   ` Peter Collingbourne
2021-05-06 23:47     ` Peter Collingbourne
2021-05-06 23:57     ` Andrey Konovalov
2021-05-06 23:57       ` Andrey Konovalov
2021-05-07  2:59       ` Peter Collingbourne
2021-05-07  2:59         ` Peter Collingbourne
2021-05-09  0:30 ` Andrew Morton [this message]
2021-05-10 17:16   ` Peter Collingbourne
2021-05-10 17:16     ` Peter Collingbourne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210508173009.781b8a401fefc2ab71cb3907@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=eugenis@google.com \
    --cc=georgepope@android.com \
    --cc=glider@google.com \
    --cc=lenaptr@google.com \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.