From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FDEC433B4 for ; Sun, 9 May 2021 15:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BB1661400 for ; Sun, 9 May 2021 15:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbhEIPMV (ORCPT ); Sun, 9 May 2021 11:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229618AbhEIPMV (ORCPT ); Sun, 9 May 2021 11:12:21 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252B0C061573; Sun, 9 May 2021 08:11:18 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id t4so20832276ejo.0; Sun, 09 May 2021 08:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uGbBfBDdd27ACbtuU1IcDMGTiO49DUlYvgrRV0jM4gc=; b=T36kbnA5q3XgUHp75M44R1ULfkZmAo7kFZXbv495VUupuO5EUgvagD5KdrXlK7W8PL LkKg3QE9Zneg5TOemZDjWspb9yzDp/3swh7kTvQE/QwkMKR/KY2yQkjrakwKE97deDGD mlopZn5CUDVVSvnmxZtRKbTfhb6OpXyS7CMW4TDgAgn6g81ipikMJNvXjC55QDLrtL1y az3p0t5SIt9BOeZuMBAR0tXJtlLllioQzhPVyllM5AfdADicsyPdGrAxq8IfV0eiGy7/ 8fv8zH/pXUbOUro2psS+FeznIUthRnGomQ7JpOHSne7es/FazGknXUsRDzdFZzA4kpaT yfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=uGbBfBDdd27ACbtuU1IcDMGTiO49DUlYvgrRV0jM4gc=; b=hL0iaz8vBtY7xs/NZ4WOUy7hLWu7Ohx1bu2PXZmtrbLbwUl12PYxol5ntGuZ6oByxY qm7MwF1egWWc2hRCa8lhn0K0llt34aXnn1gY7T5FhLm+ThqkTMyx1NzglP9FduvHXUpW 79pD9G7mMFgh5k1YH4U6ktwpHxH0IwTYOjMDnSKv3Re2U7vo/5Pmfg/NMw9I3l8jGwxV F2V+4lQGK8QtyzX3RKYSYW+75rkWq1CuMEwjAwtk/JRzHVqj5M8Uw6MMp87j80yaPrEs J4Ou2dX6y6V93Ugp6d8EwDVFUCF3wxTN+Gq2mxc1HDQD6mSQNxMCRWB0xe4a5Vdgrigc zf6Q== X-Gm-Message-State: AOAM533cU44RHkO0vGEVlDMTIQp2UBEaG/aeUQVwLSilBBaX+vXCa/Fe 37LnUk/ArLVcX4t+pgqa+BQ= X-Google-Smtp-Source: ABdhPJx2OrA83CaWegJKdEVv8+rk5M7JCtI80qpL4yLmEy2KKtTfcjWXrxOosouQnt/hRGBSO0aChA== X-Received: by 2002:a17:906:36da:: with SMTP id b26mr21532198ejc.8.1620573075316; Sun, 09 May 2021 08:11:15 -0700 (PDT) Received: from gmail.com (0526E777.dsl.pool.telekom.hu. [5.38.231.119]) by smtp.gmail.com with ESMTPSA id p13sm6901728ejr.87.2021.05.09.08.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 08:11:14 -0700 (PDT) Sender: Ingo Molnar Date: Sun, 9 May 2021 17:11:12 +0200 From: Ingo Molnar To: David Howells Cc: Valdis Kl=?utf-8?Q?=c4=93?=tnieks , David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 'make O=' indigestion with module signing Message-ID: <20210509151112.GA839293@gmail.com> References: <134696.1615510534@turing-police> <109018.1615463088@turing-police> <91190.1615444370@turing-police> <972381.1615459754@warthog.procyon.org.uk> <1486567.1615464259@warthog.procyon.org.uk> <2026575.1615539696@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2026575.1615539696@warthog.procyon.org.uk> Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org * David Howells wrote: > Valdis Klētnieks wrote: > > > So the root cause was: 'make mrproper doesn't clean certs/' out enough, > > and this chunk of certs/Makefile > > ... > > I admit not being sure how (or if) this should be fixed > > It's tricky because CONFIG_MODULE_SIG_KEY may not point to a file, let alone a > file that was autogenerated - it can be given a PKCS#11 URI, for instance. I > had to put in the autogeneration based on a magic config string value to stop > randconfig blowing up - but it only does the autogeneration if you don't put > in your own file there before building. > > Possibly I can add something like: > > clean-files := signing_key.pem x509.genkey > > inside the > > ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem") > ... > endif > > section. Note that this bug is now upstream in Linus's tree and has broken the deb-pkg distro kernel build method. Would be nice to make 'make mrproper' work again. Thanks, Ingo