From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5598C433B4 for ; Mon, 10 May 2021 03:18:18 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 5420060249 for ; Mon, 10 May 2021 03:18:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5420060249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18FCD40140; Mon, 10 May 2021 05:18:17 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D53B44003E for ; Mon, 10 May 2021 05:18:15 +0200 (CEST) IronPort-SDR: PAgVgbxzgJyTt8NMMEgaY3AR5eZ9zwoyMMXm2+Ys5DO1L/da2xOKRIqeivOJZfLCexw2EIkz6x KfNVH0LfOgwg== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="199150852" X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="199150852" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2021 20:18:14 -0700 IronPort-SDR: XrD8j6cLIsgy3M93F3iCOxD0CWfUjnt1MT8LVnPqMfuB+WXEdSdAQ4G1pqySuKh0iMElSDR+5i A3HpGbTWiiIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,286,1613462400"; d="scan'208";a="541049832" Received: from dpdk51.sh.intel.com ([10.67.111.142]) by orsmga004.jf.intel.com with ESMTP; 09 May 2021 20:18:13 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: dev@dpdk.org, Qi Zhang Date: Mon, 10 May 2021 11:21:55 +0800 Message-Id: <20210510032155.3162910-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Convery issue: 370613 Execution cannot reach this statement: "break;". Remove the unnecessary if branch. Fixes: 2913bc4155d2 ("net/ice/base: sign external device package programming") Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c index ac412a1aa7..cf0a7d4e7f 100644 --- a/drivers/net/ice/base/ice_common.c +++ b/drivers/net/ice/base/ice_common.c @@ -2009,9 +2009,6 @@ ice_parse_common_caps(struct ice_hw *hw, struct ice_hw_common_caps *caps, { u8 index = cap - ICE_AQC_CAPS_EXT_TOPO_DEV_IMG0; - if (index >= ICE_EXT_TOPO_DEV_IMG_COUNT) - break; - caps->ext_topo_dev_img_ver_high[index] = number; caps->ext_topo_dev_img_ver_low[index] = logical_id; caps->ext_topo_dev_img_part_num[index] = -- 2.26.2