All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"Karlsson, Magnus" <magnus.karlsson@intel.com>,
	"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	brouer@redhat.com, "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	"Toke Høiland-Jørgensen" <toke@redhat.com>
Subject: Re: [PATCH intel-net 0/5] i40e: ice: ixgbe: ixgbevf: igb: add correct exception tracing for XDP
Date: Mon, 10 May 2021 10:57:28 +0200	[thread overview]
Message-ID: <20210510105728.2eac4666@carbon> (raw)
In-Reply-To: <CAJ8uoz0Pgfn8kai34_MFGYv3m7c24bpo4DhjZ8oLgd4zaGMWsg@mail.gmail.com>

On Mon, 10 May 2021 08:06:00 +0200
Magnus Karlsson <magnus.karlsson@gmail.com> wrote:

> On Sat, May 8, 2021 at 12:58 AM Nguyen, Anthony L
> <anthony.l.nguyen@intel.com> wrote:
> >
> > On Fri, 2021-04-23 at 12:04 +0200, Magnus Karlsson wrote:  
> > > Add missing exception tracing to XDP when a number of different errors
> > > can occur. The support was only partial. Several errors where not
> > > logged which would confuse the user quite a lot not knowing where and
> > > why the packets disappeared.
> > >
> > > This patch set fixes this for all Intel drivers with XDP support.
> > >
> > > Thanks: Magnus  
> >
> > This doesn't apply anymore with the 5.13 patches. It looks like your
> > "optimize for XDP_REDIRECT in xsk path" patches are conflicting with
> > some of these. Did you want to rework them?  
> 
> I will rebase them and resubmit.

Thanks for working on this Magnus, highly appreciated.  This should
help end-users troubleshoot these kind of 'exception' packet drops.

We have people that will look at updating the sample/bpf/ programs
(that does XDP redirect) to report on these exception errors/drops.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


WARNING: multiple messages have this Message-ID
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH intel-net 0/5] i40e: ice: ixgbe: ixgbevf: igb: add correct exception tracing for XDP
Date: Mon, 10 May 2021 10:57:28 +0200	[thread overview]
Message-ID: <20210510105728.2eac4666@carbon> (raw)
In-Reply-To: <CAJ8uoz0Pgfn8kai34_MFGYv3m7c24bpo4DhjZ8oLgd4zaGMWsg@mail.gmail.com>

On Mon, 10 May 2021 08:06:00 +0200
Magnus Karlsson <magnus.karlsson@gmail.com> wrote:

> On Sat, May 8, 2021 at 12:58 AM Nguyen, Anthony L
> <anthony.l.nguyen@intel.com> wrote:
> >
> > On Fri, 2021-04-23 at 12:04 +0200, Magnus Karlsson wrote:  
> > > Add missing exception tracing to XDP when a number of different errors
> > > can occur. The support was only partial. Several errors where not
> > > logged which would confuse the user quite a lot not knowing where and
> > > why the packets disappeared.
> > >
> > > This patch set fixes this for all Intel drivers with XDP support.
> > >
> > > Thanks: Magnus  
> >
> > This doesn't apply anymore with the 5.13 patches. It looks like your
> > "optimize for XDP_REDIRECT in xsk path" patches are conflicting with
> > some of these. Did you want to rework them?  
> 
> I will rebase them and resubmit.

Thanks for working on this Magnus, highly appreciated.  This should
help end-users troubleshoot these kind of 'exception' packet drops.

We have people that will look at updating the sample/bpf/ programs
(that does XDP redirect) to report on these exception errors/drops.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer


  reply	other threads:[~2021-05-10  8:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 10:04 [PATCH intel-net 0/5] i40e: ice: ixgbe: ixgbevf: igb: add correct exception tracing for XDP Magnus Karlsson
2021-04-23 10:04 ` [Intel-wired-lan] " Magnus Karlsson
2021-04-23 10:04 ` [PATCH intel-net 1/5] i40e: " Magnus Karlsson
2021-04-23 10:04   ` [Intel-wired-lan] " Magnus Karlsson
2021-04-23 10:04 ` [PATCH intel-net 2/5] ice: " Magnus Karlsson
2021-04-23 10:04   ` [Intel-wired-lan] " Magnus Karlsson
2021-04-23 10:04 ` [PATCH intel-net 3/5] ixgbe: " Magnus Karlsson
2021-04-23 10:04   ` [Intel-wired-lan] " Magnus Karlsson
2021-05-21 11:39   ` Jambekar, Vishakha
2021-05-21 11:39     ` Jambekar, Vishakha
2021-04-23 10:04 ` [PATCH intel-net 4/5] igb " Magnus Karlsson
2021-04-23 10:04   ` [Intel-wired-lan] " Magnus Karlsson
2021-04-23 10:04 ` [PATCH intel-net 5/5] ixgbevf: " Magnus Karlsson
2021-04-23 10:04   ` [Intel-wired-lan] " Magnus Karlsson
2021-05-07 22:58 ` [PATCH intel-net 0/5] i40e: ice: ixgbe: ixgbevf: igb: " Nguyen, Anthony L
2021-05-07 22:58   ` [Intel-wired-lan] " Nguyen, Anthony L
2021-05-10  6:06   ` Magnus Karlsson
2021-05-10  6:06     ` [Intel-wired-lan] " Magnus Karlsson
2021-05-10  8:57     ` Jesper Dangaard Brouer [this message]
2021-05-10  8:57       ` Jesper Dangaard Brouer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510105728.2eac4666@carbon \
    --to=brouer@redhat.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=magnus.karlsson@intel.com \
    --cc=memxor@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.