From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A022BC433ED for ; Mon, 10 May 2021 14:23:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFC7D611BD for ; Mon, 10 May 2021 14:23:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFC7D611BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg6p8-0004Si-Uz for qemu-devel@archiver.kernel.org; Mon, 10 May 2021 10:23:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg6oW-0003Hc-0p for qemu-devel@nongnu.org; Mon, 10 May 2021 10:23:16 -0400 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:32084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg6oU-0007Qz-Ef for qemu-devel@nongnu.org; Mon, 10 May 2021 10:23:15 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-28UniGKtOkKqYsPFje6OZg-1; Mon, 10 May 2021 10:23:04 -0400 X-MC-Unique: 28UniGKtOkKqYsPFje6OZg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 729681922037; Mon, 10 May 2021 14:23:02 +0000 (UTC) Received: from bahia.lan (ovpn-112-152.ams2.redhat.com [10.36.112.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8D1D15D705; Mon, 10 May 2021 14:23:01 +0000 (UTC) Date: Mon, 10 May 2021 16:23:00 +0200 From: Greg Kurz To: "Dr. David Alan Gilbert" Subject: Re: [PATCH] virtiofsd: Fix check of chown()'s return value Message-ID: <20210510162300.546af5cb@bahia.lan> In-Reply-To: References: <162040394890.714971.15502455176528384778.stgit@bahia.lan> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=groug@kaod.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kaod.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Received-SPF: softfail client-ip=205.139.111.44; envelope-from=groug@kaod.org; helo=us-smtp-delivery-44.mimecast.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 10 May 2021 15:16:23 +0100 "Dr. David Alan Gilbert" wrote: > * Greg Kurz (groug@kaod.org) wrote: > > Otherwise you always get this warning when using --socket-group=3Dusers > >=20 > > vhost socket failed to set group to users (100) > >=20 > > While here, print out the error if chown() fails. > >=20 > > Signed-off-by: Greg Kurz >=20 > probably needs a fixes: but yes. >=20 Fixes: f6698f2b03b0 ("tools/virtiofsd: add support for --socket-group") > Reviewed-by: Dr. David Alan Gilbert >=20 > > --- > > tools/virtiofsd/fuse_virtio.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virti= o.c > > index 3e13997406bf..638d3ffe2f8a 100644 > > --- a/tools/virtiofsd/fuse_virtio.c > > +++ b/tools/virtiofsd/fuse_virtio.c > > @@ -978,9 +978,9 @@ static int fv_create_listen_socket(struct fuse_sess= ion *se) > > if (se->vu_socket_group) { > > struct group *g =3D getgrnam(se->vu_socket_group); > > if (g) { > > - if (!chown(se->vu_socket_path, -1, g->gr_gid)) { > > + if (chown(se->vu_socket_path, -1, g->gr_gid) =3D=3D -1) { > > fuse_log(FUSE_LOG_WARNING, > > - "vhost socket failed to set group to %s (%d)\= n", > > + "vhost socket failed to set group to %s (%d):= %m\n", > > se->vu_socket_group, g->gr_gid); > > } > > } > >=20 > >=20