From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, <linux-rtc@vger.kernel.org>, <linux-pwm@vger.kernel.org>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Alessandro Zummo <a.zummo@towertech.it>, Mark Brown <broonie@kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com>, Wolfram Sang <wsa@kernel.org>, "Oleksij Rempel" <o.rempel@pengutronix.de>, Ludovic Desroches <ludovic.desroches@microchip.com>, Thierry Reding <thierry.reding@gmail.com>, <kernel@pengutronix.de>, Andrew Morton <akpm@linux-foundation.org>, <linux-spi@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, <linux-clk@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Alexandru Ardelean <aardelean@deviqon.com> Subject: Re: [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks Date: Mon, 10 May 2021 18:07:27 +0100 [thread overview] Message-ID: <20210510180727.0000056d@Huawei.com> (raw) In-Reply-To: <20210510061724.940447-1-u.kleine-koenig@pengutronix.de> On Mon, 10 May 2021 08:17:18 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > this is just a resend as I didn't get any feedback in the two weeks > since the original v6 submission. Would be nice to hear something back, > I'm trying for more than half a year now to get feedback. :-\ I have a bunch of usecases in IIO, (many with local devm_add_action_or_reset() doing the same thing.) +CC Alex who sent out a series add more local handling of this case today. Code seems correct and clean to me, but whether the clk maintainers want to encourage this pattern is down to them (I've had similar discussions about regulators in the past where we've agreed to disagree on this topic). Jonathan > > Best regards > Uwe > > Uwe Kleine-König (6): > clk: generalize devm_clk_get() a bit > clk: Provide new devm_clk_helpers for prepared and enabled clocks > pwm: atmel: Simplify using devm_clk_get_prepared() > rtc: at91sam9: Simplify using devm_clk_get_enabled() > i2c: imx: Simplify using devm_clk_get_enabled() > spi: davinci: Simplify using devm_clk_get_enabled() > > drivers/clk/clk-devres.c | 96 ++++++++++++++++++++++++++++++------ > drivers/i2c/busses/i2c-imx.c | 12 +---- > drivers/pwm/pwm-atmel.c | 15 +----- > drivers/rtc/rtc-at91sam9.c | 22 ++------- > drivers/spi/spi-davinci.c | 11 +---- > include/linux/clk.h | 87 +++++++++++++++++++++++++++++++- > 6 files changed, 176 insertions(+), 67 deletions(-) > > > base-commit: a38fd8748464831584a19438cbb3082b5a2dab15
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com> To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, <linux-rtc@vger.kernel.org>, <linux-pwm@vger.kernel.org>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Alessandro Zummo <a.zummo@towertech.it>, Mark Brown <broonie@kernel.org>, Claudiu Beznea <claudiu.beznea@microchip.com>, Wolfram Sang <wsa@kernel.org>, "Oleksij Rempel" <o.rempel@pengutronix.de>, Ludovic Desroches <ludovic.desroches@microchip.com>, Thierry Reding <thierry.reding@gmail.com>, <kernel@pengutronix.de>, Andrew Morton <akpm@linux-foundation.org>, <linux-spi@vger.kernel.org>, Lee Jones <lee.jones@linaro.org>, <linux-clk@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, Alexandru Ardelean <aardelean@deviqon.com> Subject: Re: [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks Date: Mon, 10 May 2021 18:07:27 +0100 [thread overview] Message-ID: <20210510180727.0000056d@Huawei.com> (raw) In-Reply-To: <20210510061724.940447-1-u.kleine-koenig@pengutronix.de> On Mon, 10 May 2021 08:17:18 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > this is just a resend as I didn't get any feedback in the two weeks > since the original v6 submission. Would be nice to hear something back, > I'm trying for more than half a year now to get feedback. :-\ I have a bunch of usecases in IIO, (many with local devm_add_action_or_reset() doing the same thing.) +CC Alex who sent out a series add more local handling of this case today. Code seems correct and clean to me, but whether the clk maintainers want to encourage this pattern is down to them (I've had similar discussions about regulators in the past where we've agreed to disagree on this topic). Jonathan > > Best regards > Uwe > > Uwe Kleine-König (6): > clk: generalize devm_clk_get() a bit > clk: Provide new devm_clk_helpers for prepared and enabled clocks > pwm: atmel: Simplify using devm_clk_get_prepared() > rtc: at91sam9: Simplify using devm_clk_get_enabled() > i2c: imx: Simplify using devm_clk_get_enabled() > spi: davinci: Simplify using devm_clk_get_enabled() > > drivers/clk/clk-devres.c | 96 ++++++++++++++++++++++++++++++------ > drivers/i2c/busses/i2c-imx.c | 12 +---- > drivers/pwm/pwm-atmel.c | 15 +----- > drivers/rtc/rtc-at91sam9.c | 22 ++------- > drivers/spi/spi-davinci.c | 11 +---- > include/linux/clk.h | 87 +++++++++++++++++++++++++++++++- > 6 files changed, 176 insertions(+), 67 deletions(-) > > > base-commit: a38fd8748464831584a19438cbb3082b5a2dab15 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-10 17:09 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-10 6:17 [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 6:17 ` Uwe Kleine-König 2021-05-10 6:17 ` [PATCH v6 RESEND 1/6] clk: generalize devm_clk_get() a bit Uwe Kleine-König 2021-05-10 6:17 ` Uwe Kleine-König 2021-05-10 17:02 ` Jonathan Cameron 2021-05-10 17:02 ` Jonathan Cameron 2021-05-10 17:27 ` Uwe Kleine-König 2021-05-10 17:27 ` Uwe Kleine-König 2021-05-10 6:17 ` [PATCH v6 RESEND 2/6] clk: Provide new devm_clk_helpers for prepared and enabled clocks Uwe Kleine-König 2021-05-10 6:17 ` Uwe Kleine-König 2021-05-10 17:05 ` Jonathan Cameron 2021-05-10 17:05 ` Jonathan Cameron 2021-05-10 6:17 ` [PATCH v6 RESEND 3/6] pwm: atmel: Simplify using devm_clk_get_prepared() Uwe Kleine-König 2021-05-10 6:17 ` [PATCH v6 RESEND 4/6] rtc: at91sam9: Simplify using devm_clk_get_enabled() Uwe Kleine-König 2021-05-10 6:17 ` Uwe Kleine-König 2021-05-10 6:17 ` [PATCH v6 RESEND 5/6] i2c: imx: " Uwe Kleine-König 2021-05-10 6:17 ` Uwe Kleine-König 2021-05-10 6:17 ` [PATCH v6 RESEND 6/6] spi: davinci: " Uwe Kleine-König 2021-05-10 17:07 ` Jonathan Cameron [this message] 2021-05-10 17:07 ` [PATCH v6 RESEND 0/6] clk: provide new devm helpers for prepared and enabled clocks Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210510180727.0000056d@Huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=a.zummo@towertech.it \ --cc=aardelean@deviqon.com \ --cc=akpm@linux-foundation.org \ --cc=alexandre.belloni@bootlin.com \ --cc=broonie@kernel.org \ --cc=claudiu.beznea@microchip.com \ --cc=kernel@pengutronix.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=mturquette@baylibre.com \ --cc=o.rempel@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ --cc=wsa@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.