From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FA9C433ED for ; Mon, 10 May 2021 18:35:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79C1561483 for ; Mon, 10 May 2021 18:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232850AbhEJSgp (ORCPT ); Mon, 10 May 2021 14:36:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:60346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230186AbhEJSgl (ORCPT ); Mon, 10 May 2021 14:36:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF75D61483; Mon, 10 May 2021 18:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620671736; bh=B9SXyeC+hysLQ0q10lFZazvUoImWnEYseqN99FaOPq4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=G+UO8N2jvQH03gPeXoaM3Qsqo1k+W0p0ZTu4enq4CfX60YFMGXMtYHhgg7ZedukxU JvLD4na+1Z7SrnUOZOQQgo9K3OYPOitN6v+gk7gt0ZBBRiEf9NM1TO5+QvAlLkqfH6 MPr6rzTcZH7npPdpGjjXx9AJ9eQnNCLlGG6AYwAcmFLTmp7yEvfT4nO7mFAhhLJZzD RAGKmo50zoZuzd8OAGGPBTKkiwg5022DcP0gXvgMOSpF/4m0gb1ypyAzNTL9oWCCNs LZG9pRTFT7+00duB5kvlxLN9ltw4T7rEEBP46ueZW3zFRWgt/Th+i4egTjJGEus81R wqByp652Fdi0Q== Date: Mon, 10 May 2021 13:35:29 -0500 From: Bjorn Helgaas To: Linus Walleij Cc: Corentin Labbe , Bjorn Helgaas , Rob Herring , Hans Ulli Kroll , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-kernel , linux-pci Subject: Re: [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml Message-ID: <20210510183529.GA2289311@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 07, 2021 at 12:51:39PM +0200, Linus Walleij wrote: > On Thu, May 6, 2021 at 10:34 PM Bjorn Helgaas wrote: > > > I think it's nicer when content changes are in a separate patch from > > format conversion patches. Otherwise it's really hard to see the > > content changes in the patch. > > > > Maybe a preliminary patch could fix whatever is actually broken? > > > > Rob suggested a bunch of things that could be dropped. Maybe those > > could be removed in a second preliminary patch before the conversion? > > Or maybe the removals are only possible *because* of the conversion? > > I'm not a yaml expert. > > A bit of taste is involved. The old .txt bindings are for processing > by human brain power. Those lack regular syntax and strictness > because brains are designed for evolved natural languages. > > The YAML on the other hand is a chomsky type-3 strict regular > language and the .yaml file (and includes) defines this strict regular > grammar and as such admits less mistakes. The upside is that > it enforces some order. > > In the process of moving to YAML we often discover a slew of > mistakes and the initiative often comes with the ambition to add > or modernize something. > > In this case I wouldn't care with stepwise fixing because the > platform is modernized by a handful of people who all know > what is going on, so there is noone to confuse other than the > subsystem maintainer and the result will end up in the same > kernel release anyway. Haha, I'm in that large majority of people who lack deep knowledge of what's going on, so it definitely confuses me :) I think the stepwise fix would be helpful in making the patches more accessible to us non-experts, and I know it would save me time in reviewing. It may also be useful to people converting other bindings to YAML because it's more obvious what mistakes need to be fixed in the process. Also helpful: changing the subject line to match the existing convention, e.g., dt-bindings: PCI: ftpci100: Convert faraday,ftpci100 to YAML Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC870C433ED for ; Mon, 10 May 2021 18:37:22 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C400613CF for ; Mon, 10 May 2021 18:37:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C400613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References:List-Owner; bh=lc06n1K0mi5vlqdwoYv3Eyc381LZ+Xs46R+l52CsK9g=; b=DIfjPXvh4vIYWQq/zr6luoNHf k8u1L/Lqcld+2tonIC7wHkD3PlvoAHyCBIMUVCMfV81mI6uQdfvc/3ZwUJvdRaZ316kkGhS3DY4JH 5WIkgtv6ME/g9al7vba4htTwgDMcRL3L6fozRd/a4KoNpA6MAMsFtQDdcV4n7/rjHmH9VACitX3ge 6XkFWEXB9SrOKoPorNehgvSWXa7Vd8TL88l2MU1qPne9UuGA+/hpO2WZpd3aJH9vkLWPzEj6TgkVx E6qsmUywFnGo+z8f5VWT6Z+TJBJEfqdLEIGMdbUe/Ys/OVH7DPMz+tbLrhTINP5ycWDXJrVKgRN00 xUvH2TCdA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgAko-00FS3Q-FF; Mon, 10 May 2021 18:35:42 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgAkl-00FS3A-Sd for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 18:35:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding :Content-ID:Content-Description:References; bh=JLvWnka4xQJRHly3ltAuvj1EbJGdJXHxRgXwsfntwb8=; b=i3TfhkZOuXqRrCHHaxbsGJ3D99 JBz+1zkIu1AKrrDGVEVtYTncU87iM4EAs2rPY4dZEfFfEpfnm8xGu30pySOyJZ+D3Ahtlmkj2ueX8 hJFrmZ5MwKOF/7tMWSBLlTBgsizqdVma5BriNPZdcZPwIwk5wUj7EhYkNTlhcdySAGNlfTwYar2Fy tpn1Mc3ocifRBWl4GU6RM2Cgj0RMnvr4Rqd1o39rT2+96pezHBlhcH/5nNRaTlJgiqYmd0zpKRhZc opHs8gAH7PqBZkL4SkQuoFkQ+rVFvEyeNlVOWUVsw4KSAepIuhLHypRJ8zhPq7cxiS/+2y9namn7u 4wicMPOw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgAkj-0092Wa-Bh for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 18:35:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF75D61483; Mon, 10 May 2021 18:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620671736; bh=B9SXyeC+hysLQ0q10lFZazvUoImWnEYseqN99FaOPq4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=G+UO8N2jvQH03gPeXoaM3Qsqo1k+W0p0ZTu4enq4CfX60YFMGXMtYHhgg7ZedukxU JvLD4na+1Z7SrnUOZOQQgo9K3OYPOitN6v+gk7gt0ZBBRiEf9NM1TO5+QvAlLkqfH6 MPr6rzTcZH7npPdpGjjXx9AJ9eQnNCLlGG6AYwAcmFLTmp7yEvfT4nO7mFAhhLJZzD RAGKmo50zoZuzd8OAGGPBTKkiwg5022DcP0gXvgMOSpF/4m0gb1ypyAzNTL9oWCCNs LZG9pRTFT7+00duB5kvlxLN9ltw4T7rEEBP46ueZW3zFRWgt/Th+i4egTjJGEus81R wqByp652Fdi0Q== Date: Mon, 10 May 2021 13:35:29 -0500 From: Bjorn Helgaas To: Linus Walleij Cc: Corentin Labbe , Bjorn Helgaas , Rob Herring , Hans Ulli Kroll , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , linux-kernel , linux-pci Subject: Re: [PATCH 1/2] dt-bindings: pci: convert faraday,ftpci100 to yaml Message-ID: <20210510183529.GA2289311@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_113537_485074_E21F3DFE X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 07, 2021 at 12:51:39PM +0200, Linus Walleij wrote: > On Thu, May 6, 2021 at 10:34 PM Bjorn Helgaas wrote: > > > I think it's nicer when content changes are in a separate patch from > > format conversion patches. Otherwise it's really hard to see the > > content changes in the patch. > > > > Maybe a preliminary patch could fix whatever is actually broken? > > > > Rob suggested a bunch of things that could be dropped. Maybe those > > could be removed in a second preliminary patch before the conversion? > > Or maybe the removals are only possible *because* of the conversion? > > I'm not a yaml expert. > > A bit of taste is involved. The old .txt bindings are for processing > by human brain power. Those lack regular syntax and strictness > because brains are designed for evolved natural languages. > > The YAML on the other hand is a chomsky type-3 strict regular > language and the .yaml file (and includes) defines this strict regular > grammar and as such admits less mistakes. The upside is that > it enforces some order. > > In the process of moving to YAML we often discover a slew of > mistakes and the initiative often comes with the ambition to add > or modernize something. > > In this case I wouldn't care with stepwise fixing because the > platform is modernized by a handful of people who all know > what is going on, so there is noone to confuse other than the > subsystem maintainer and the result will end up in the same > kernel release anyway. Haha, I'm in that large majority of people who lack deep knowledge of what's going on, so it definitely confuses me :) I think the stepwise fix would be helpful in making the patches more accessible to us non-experts, and I know it would save me time in reviewing. It may also be useful to people converting other bindings to YAML because it's more obvious what mistakes need to be fixed in the process. Also helpful: changing the subject line to match the existing convention, e.g., dt-bindings: PCI: ftpci100: Convert faraday,ftpci100 to YAML Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel