CC: kbuild-all(a)lists.01.org In-Reply-To: References: TO: Matti Vaittinen , Matti Vaittinen TO: Matti Vaittinen , Matti Vaittinen CC: Mark Brown CC: Kees Cook CC: Andy Shevchenko CC: Zhang Rui CC: Guenter Roeck CC: "agross(a)kernel.org" CC: "devicetree(a)vger.kernel.org" CC: "linux-power" CC: "linux-kernel(a)vger.kernel.org" Hi Matti, I love your patch! Perhaps something to improve: [auto build test WARNING on 6efb943b8616ec53a5e444193dccf1af9ad627b5] url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125 base: 6efb943b8616ec53a5e444193dccf1af9ad627b5 :::::: branch date: 2 hours ago :::::: commit date: 2 hours ago config: i386-randconfig-s002-20210510 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.3-341-g8af24329-dirty # https://github.com/0day-ci/linux/commit/904edb46fa37ac86bc1e7a1629141e037f45ebed git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matti-Vaittinen/Extend-regulator-notification-support/20210510-203125 git checkout 904edb46fa37ac86bc1e7a1629141e037f45ebed # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): In file included from include/linux/kernel.h:12, from arch/x86/include/asm/percpu.h:27, from arch/x86/include/asm/current.h:6, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from drivers/regulator/irq_helpers.c:10: drivers/regulator/irq_helpers.c: In function 'regulator_notifier_isr': >> include/linux/bitops.h:35:2: warning: this 'for' clause does not guard... [-Wmisleading-indentation] 35 | for ((bit) = find_first_bit((addr), (size)); \ | ^~~ drivers/regulator/irq_helpers.c:242:3: note: in expansion of macro 'for_each_set_bit' 242 | for_each_set_bit(j, &stat->notifs, BITS_PER_TYPE(stat->notifs)) | ^~~~~~~~~~~~~~~~ drivers/regulator/irq_helpers.c:244:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'for' 244 | pr_dbg("Sending regulator notification EVT 0x%lx\r\n", | ^~~~~~ drivers/regulator/irq_helpers.c:244:4: error: implicit declaration of function 'pr_dbg'; did you mean 'pr_debug'? [-Werror=implicit-function-declaration] 244 | pr_dbg("Sending regulator notification EVT 0x%lx\r\n", | ^~~~~~ | pr_debug cc1: some warnings being treated as errors vim +/for +35 include/linux/bitops.h ^1da177e4c3f41 Linus Torvalds 2005-04-16 33 984b3f5746ed2c Akinobu Mita 2010-03-05 34 #define for_each_set_bit(bit, addr, size) \ 3e037454bcfa4b Shannon Nelson 2007-10-16 @35 for ((bit) = find_first_bit((addr), (size)); \ 3e037454bcfa4b Shannon Nelson 2007-10-16 36 (bit) < (size); \ 3e037454bcfa4b Shannon Nelson 2007-10-16 37 (bit) = find_next_bit((addr), (size), (bit) + 1)) 3e037454bcfa4b Shannon Nelson 2007-10-16 38 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org