From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 944E3C433ED for ; Tue, 11 May 2021 07:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69CBC61482 for ; Tue, 11 May 2021 07:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229964AbhEKHTh (ORCPT ); Tue, 11 May 2021 03:19:37 -0400 Received: from mail109.syd.optusnet.com.au ([211.29.132.80]:37938 "EHLO mail109.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKHTh (ORCPT ); Tue, 11 May 2021 03:19:37 -0400 Received: from dread.disaster.area (pa49-179-143-157.pa.nsw.optusnet.com.au [49.179.143.157]) by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 0F58C65E2D; Tue, 11 May 2021 17:18:29 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1lgMex-00DUgf-VK; Tue, 11 May 2021 17:18:27 +1000 Date: Tue, 11 May 2021 17:18:27 +1000 From: Dave Chinner To: Brian Foster Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 01/22] xfs: move xfs_perag_get/put to xfs_ag.[ch] Message-ID: <20210511071827.GQ63242@dread.disaster.area> References: <20210506072054.271157-1-david@fromorbit.com> <20210506072054.271157-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=Tu+Yewfh c=1 sm=1 tr=0 a=I9rzhn+0hBG9LkCzAun3+g==:117 a=I9rzhn+0hBG9LkCzAun3+g==:17 a=kj9zAlcOel0A:10 a=5FLXtPjwQuUA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=dFrUeFZAEYESspmLrHcA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, May 10, 2021 at 08:52:56AM -0400, Brian Foster wrote: > On Thu, May 06, 2021 at 05:20:33PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > They are AG functions, not superblock functions, so move them to the > > appropriate location. > > > > Signed-off-by: Dave Chinner > > --- > ... > > > > diff --git a/fs/xfs/libxfs/xfs_ag.c b/fs/xfs/libxfs/xfs_ag.c > > index c68a36688474..2ca31dc46fe8 100644 > > --- a/fs/xfs/libxfs/xfs_ag.c > > +++ b/fs/xfs/libxfs/xfs_ag.c > > @@ -27,6 +27,141 @@ > > #include "xfs_defer.h" > > #include "xfs_log_format.h" > > #include "xfs_trans.h" > > +#include "xfs_trace.h" > > The corresponding xfs_trace.h include can now be removed from > libxfs/xfs_sb.c. Otherwise looks like a straightforward move: fixed. -- Dave Chinner david@fromorbit.com