From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Harman Kalra <hkalra@marvell.com>,
Harini Ramakrishnan <haramakr@microsoft.com>,
ranjit.menon@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] eal/windows: cleanup interrupt resources
Date: Tue, 11 May 2021 10:59:34 +0300 [thread overview]
Message-ID: <20210511105934.104bbca5@sovereign> (raw)
In-Reply-To: <2970635.tDqZXrgMp7@thomas>
2021-05-11 09:41 (UTC+0200), Thomas Monjalon:
> 02/05/2021 04:33, Dmitry Kozlyuk:
> > Interrupt manager in Windows EAL allocates on IOCP and starts
> > a control thread that runs indefinitely. At DPDK cleanup
> > this thread was not stopped and IOCP handle was not closed.
> >
> > Gracefully stop interrupt-handling in rte_eal_cleanup().
> > The thread already closes IOCP handle before exiting.
> >
> > Fixes: 5c016fc0205a ("eal/windows: add interrupt thread skeleton")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > lib/eal/windows/eal.c | 1 +
> > lib/eal/windows/eal_interrupts.c | 26 ++++++++++++++++++++++++--
> > lib/eal/windows/eal_windows.h | 5 +++++
> > 3 files changed, 30 insertions(+), 2 deletions(-)
>
> It seems nobody reviewed.
> To be on the safe side, I'll merge this series after DPDK 21.05 is released.
> Or am I missing any critical issue?
IIRC Windows DPDK is not shipped anywhere yet, so the fix can be postponed.
Without fix in 2/3 rte_eal_alarm_set() will start failing after some
thousands of calls (i40e calls every 50 ms, mlx5 call every 1 sec or less).
For mlx5 it seems to break flow counters (mlx5_flow_query_alarm function).
next prev parent reply other threads:[~2021-05-11 7:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 2:33 [dpdk-dev] [PATCH 1/3] eal/windows: fix use of incorrect thread ID Dmitry Kozlyuk
2021-05-02 2:33 ` [dpdk-dev] [PATCH 2/3] eal/windows: fix interrupt thread handle leakage Dmitry Kozlyuk
2021-05-13 1:15 ` Kadam, Pallavi
2021-05-02 2:33 ` [dpdk-dev] [PATCH 3/3] eal/windows: cleanup interrupt resources Dmitry Kozlyuk
2021-05-11 7:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-11 7:59 ` Dmitry Kozlyuk [this message]
2021-05-11 17:21 ` Ranjit Menon
2021-05-12 14:56 ` Thomas Monjalon
2021-05-11 17:24 ` [dpdk-dev] " Ranjit Menon
2021-05-28 17:33 ` Jie Zhou
2021-06-23 7:08 ` Thomas Monjalon
2021-05-04 0:08 ` [dpdk-dev] [PATCH 1/3] eal/windows: fix use of incorrect thread ID Tyler Retzlaff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511105934.104bbca5@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=haramakr@microsoft.com \
--cc=hkalra@marvell.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.