From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BF9DC433B4 for ; Tue, 11 May 2021 12:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D344A61075 for ; Tue, 11 May 2021 12:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231658AbhEKMxD (ORCPT ); Tue, 11 May 2021 08:53:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231459AbhEKMxB (ORCPT ); Tue, 11 May 2021 08:53:01 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46B09C061574 for ; Tue, 11 May 2021 05:51:54 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id j10so2523330ejb.3 for ; Tue, 11 May 2021 05:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Vz3NVjeSduBFGcr7e4KNuJw+YQxjHIZNkFnnUo3vhA=; b=TfrLT7I8hBPUsbCgT5nmLrSnP1r7AhcYkJEB3XXNnc8qRQW9Q8HnoPYQGyuiQK2TbQ EbaJARNMC1mqSnRB/2XcZ5olBFCG8P97ocjZbFGdBWyqpV0ql08dGRPgcdB31t61zodP +L0p8pjCMHASUzN9j3WA9u3dEiiOc+15mKk4V8EnEV/Nny9eK78nOR9odhelbo2Cnukf 0kKKLqlTKlMG00Azf2556mgpDOnXYS0RH8RYThM6giyQLFwpeFuJeWmV3u5RvksJkKbc G8ruV+xoxRHwSwGUK4yEsoo2+XEKFPsUYoM0se+KJEOFMxf1iG5DFmaU/AJSkRFLnMkC Xi6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Vz3NVjeSduBFGcr7e4KNuJw+YQxjHIZNkFnnUo3vhA=; b=MWJuovmONKIuH6Qd3Tp42IyEj1hhNdyafgGtd/JsG2Pyj0DbeBrducdJh0YphLLw1h xVFGASi02wSLLKmPW8xb4L6qJcnTmfelH2TToV1z3c0sVwRuCw5S01LFrdQrg+gsfxs6 8MdP+xp8P6bpRF0vmVHKbWKz3JtqL0x7XpuXREEZyvyfrLV29ha2ezV4p6dv92kXqDRS Olw8g6PpozqOfD3XtBj30wYCjGKA+D/1pL4lsvdXFOYrafG5BxTdzdn9HPzkQPIiOKrd VVXBqHnLOdRghKJgtEkRRT9RuCS1ZsTjLYVBIAUIL+Yp3C2ghYlYwtkMzKdisxd3zupo 8ILQ== X-Gm-Message-State: AOAM530vGp1wNWA3OrXN94gWKOqnsvC99Ydfp1KhmTgH42xVRphEPwP2 BqY9HbsFAKaqiNZE3xzM/3U= X-Google-Smtp-Source: ABdhPJyXRhNHpJwPFimIfNRvAdJwYclnTh5DYMJmV8PxCXAGY/nYbXtvLNcUy0Zh6uqXOd1GETbfTg== X-Received: by 2002:a17:906:f56:: with SMTP id h22mr31470771ejj.366.1620737512992; Tue, 11 May 2021 05:51:52 -0700 (PDT) Received: from spectre.. (host-79-47-116-73.retail.telecomitalia.it. [79.47.116.73]) by smtp.gmail.com with ESMTPSA id h4sm13093391edv.97.2021.05.11.05.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 05:51:52 -0700 (PDT) From: Elia Devito Cc: Elia Devito , Jaroslav Kysela , Takashi Iwai , Kailang Yang , Jian-Hong Pan , Hui Wang , Chris Chiu , Huacai Chen , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx Date: Tue, 11 May 2021 14:46:49 +0200 Message-Id: <20210511124651.4802-1-eliadevito@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably on similar models. 0x14 pin config override is required to enable all speakers and alc285-speaker2-to-dac1 fixup to enable volume adjustment. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331 Signed-off-by: Elia Devito --- v2: Put the quirk entry in the PCI SSID order sound/pci/hda/patch_realtek.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b4b71609dff1..3e269de84079 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6542,6 +6542,7 @@ enum { ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST, ALC295_FIXUP_ASUS_DACS, ALC295_FIXUP_HP_OMEN, + ALC285_FIXUP_HP_SPECTRE_X360, }; static const struct hda_fixup alc269_fixups[] = { @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED, }, + [ALC285_FIXUP_HP_SPECTRE_X360] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x14, 0x90170110 }, /* enable top speaker */ + {} + }, + .chained = true, + .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -8259,6 +8269,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN), SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3), + SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO), SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED), @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"}, {.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"}, {.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"}, + {.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"}, {} }; #define ALC225_STANDARD_PINS \ -- 2.31.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AAE3C433ED for ; Tue, 11 May 2021 12:52:52 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91A1961921 for ; Tue, 11 May 2021 12:52:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91A1961921 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1C27717BB; Tue, 11 May 2021 14:51:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1C27717BB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620737568; bh=repLIb2OVydqXuT1AwYdJsrB7hRd7eM7lHMZ+tL84zA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=duP0ni1QHjLnXFIQMlZwDg5BZzD9bm/nDTdHjU9WxBZBIY/ow4f0Zg7Eh2Lk88WjQ eTqlr3UKjWE24pC5VOdASgdGHN9N2nhS0dQuokewNBkuWQJkmUkW/q7vCYz7qdvDtz j78gcp3pvxeNaQ8YUyfd0pGEpfimY9PK0dYsG6EE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A3320F80129; Tue, 11 May 2021 14:51:57 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6DBABF80163; Tue, 11 May 2021 14:51:56 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 05D10F80129 for ; Tue, 11 May 2021 14:51:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 05D10F80129 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TfrLT7I8" Received: by mail-ej1-x632.google.com with SMTP id w3so29600635ejc.4 for ; Tue, 11 May 2021 05:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Vz3NVjeSduBFGcr7e4KNuJw+YQxjHIZNkFnnUo3vhA=; b=TfrLT7I8hBPUsbCgT5nmLrSnP1r7AhcYkJEB3XXNnc8qRQW9Q8HnoPYQGyuiQK2TbQ EbaJARNMC1mqSnRB/2XcZ5olBFCG8P97ocjZbFGdBWyqpV0ql08dGRPgcdB31t61zodP +L0p8pjCMHASUzN9j3WA9u3dEiiOc+15mKk4V8EnEV/Nny9eK78nOR9odhelbo2Cnukf 0kKKLqlTKlMG00Azf2556mgpDOnXYS0RH8RYThM6giyQLFwpeFuJeWmV3u5RvksJkKbc G8ruV+xoxRHwSwGUK4yEsoo2+XEKFPsUYoM0se+KJEOFMxf1iG5DFmaU/AJSkRFLnMkC Xi6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Vz3NVjeSduBFGcr7e4KNuJw+YQxjHIZNkFnnUo3vhA=; b=SWc0zsjDcha1hKJmuPyrMByGFnOC7eI3JO0G2e8CcVdVPV5mki9/4Qzzh9gsexsLjL 6ib11Ob4KNYE3v7glmJkrC4DxEa0uwbSKZokC8qZovY4qAC+afLiLQPSKSV0Id8i29B1 xQOH7/uxndY2dQ251uSdo6wbzGGo8gyyc3rwvE9F7lnL6AU5Ch2OM5fMjqI6mpvOv+Al nQl9Emb6MrcYPseJxSZBjXd+3vTP/OM5/7dbZBrusv6cjzL6Im1c1peKwfTYz4Agi6B2 /z7zTEy6DRNbEHEzPHe0Nkcz5DHTd6IB684wnOetDo3gh0cO9YIB6Tj2qH1kZ/NCwcIj SALw== X-Gm-Message-State: AOAM533v/vXV/xkwIryJXNI1gKKpoamvo117JttPdDJ5f51Yx6RHg0Em PmyBFrQgJJ0l6DqWga+MBTG0QNHT+KApQEoO X-Google-Smtp-Source: ABdhPJyXRhNHpJwPFimIfNRvAdJwYclnTh5DYMJmV8PxCXAGY/nYbXtvLNcUy0Zh6uqXOd1GETbfTg== X-Received: by 2002:a17:906:f56:: with SMTP id h22mr31470771ejj.366.1620737512992; Tue, 11 May 2021 05:51:52 -0700 (PDT) Received: from spectre.. (host-79-47-116-73.retail.telecomitalia.it. [79.47.116.73]) by smtp.gmail.com with ESMTPSA id h4sm13093391edv.97.2021.05.11.05.51.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 05:51:52 -0700 (PDT) From: Elia Devito To: Subject: [PATCH v2] ALSA: hda/realtek: Add fixup for HP Spectre x360 15-df0xxx Date: Tue, 11 May 2021 14:46:49 +0200 Message-Id: <20210511124651.4802-1-eliadevito@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: Chris Chiu , alsa-devel@alsa-project.org, Kailang Yang , linux-kernel@vger.kernel.org, Elia Devito , Jian-Hong Pan , Takashi Iwai , Hui Wang , Huacai Chen X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Fixup to enable all 4 speaker on HP Spectre x360 15-df0xxx and probably on similar models. 0x14 pin config override is required to enable all speakers and alc285-speaker2-to-dac1 fixup to enable volume adjustment. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=189331 Signed-off-by: Elia Devito --- v2: Put the quirk entry in the PCI SSID order sound/pci/hda/patch_realtek.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index b4b71609dff1..3e269de84079 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -6542,6 +6542,7 @@ enum { ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST, ALC295_FIXUP_ASUS_DACS, ALC295_FIXUP_HP_OMEN, + ALC285_FIXUP_HP_SPECTRE_X360, }; static const struct hda_fixup alc269_fixups[] = { @@ -8099,6 +8100,15 @@ static const struct hda_fixup alc269_fixups[] = { .chained = true, .chain_id = ALC269_FIXUP_HP_LINE1_MIC1_LED, }, + [ALC285_FIXUP_HP_SPECTRE_X360] = { + .type = HDA_FIXUP_PINS, + .v.pins = (const struct hda_pintbl[]) { + { 0x14, 0x90170110 }, /* enable top speaker */ + {} + }, + .chained = true, + .chain_id = ALC285_FIXUP_SPEAKER2_TO_DAC1, + }, }; static const struct snd_pci_quirk alc269_fixup_tbl[] = { @@ -8259,6 +8269,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3), SND_PCI_QUIRK(0x103c, 0x84da, "HP OMEN dc0019-ur", ALC295_FIXUP_HP_OMEN), SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3), + SND_PCI_QUIRK(0x103c, 0x8519, "HP Spectre x360 15-df0xxx", ALC285_FIXUP_HP_SPECTRE_X360), SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED), SND_PCI_QUIRK(0x103c, 0x86c7, "HP Envy AiO 32", ALC274_FIXUP_HP_ENVY_GPIO), SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED), @@ -8665,6 +8676,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = { {.id = ALC274_FIXUP_HP_MIC, .name = "alc274-hp-mic-detect"}, {.id = ALC245_FIXUP_HP_X360_AMP, .name = "alc245-hp-x360-amp"}, {.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"}, + {.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"}, {} }; #define ALC225_STANDARD_PINS \ -- 2.31.1