From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2801CC433B4 for ; Tue, 11 May 2021 21:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F289E6191A for ; Tue, 11 May 2021 21:31:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbhEKVcK (ORCPT ); Tue, 11 May 2021 17:32:10 -0400 Received: from elvis.franken.de ([193.175.24.41]:50509 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbhEKVcK (ORCPT ); Tue, 11 May 2021 17:32:10 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lgZy2-0004Ah-00; Tue, 11 May 2021 23:31:02 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 5E38BC0E6B; Tue, 11 May 2021 23:13:59 +0200 (CEST) Date: Tue, 11 May 2021 23:13:59 +0200 From: Thomas Bogendoerfer To: Linus Walleij Cc: Bartosz Golaszewski , Rob Herring , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel Subject: Re: [PATCH v4 2/2] dt-bindings: gpio: Add devicetree binding for IDT 79RC32434 GPIO controller Message-ID: <20210511211359.GA19043@alpha.franken.de> References: <20210426095426.118356-1-tsbogend@alpha.franken.de> <20210426095426.118356-2-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, May 01, 2021 at 02:13:35PM +0200, Linus Walleij wrote: > On Mon, Apr 26, 2021 at 11:54 AM Thomas Bogendoerfer > wrote: > > > Add YAML devicetree binding for IDT 79RC32434 GPIO controller > > > > Signed-off-by: Thomas Bogendoerfer > > --- > > Changes in v4: > > - renamed to idt,32434-gpio this time for real > > Overall looks good to me. > > > +required: > (...) > > + - ngpios > > Is there a *technical* reason why this is required? > > Can't the driver just default to 32 gpios when not specified? sure, I make it optional. > > + - interrupt-controller > > + - "#interrupt-cells" > > + - interrupts > > Why can't interrupt support be made optional? > > It is fine if the driver errors out if not provided, but > for the bindings this feels optional. I'll make them optional. > Or does the thing break unless you handle the IRQs? no, they could be used just as GPIOs. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]