From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5290BC433B4 for ; Tue, 11 May 2021 23:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2909861288 for ; Tue, 11 May 2021 23:23:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhEKXYJ (ORCPT ); Tue, 11 May 2021 19:24:09 -0400 Received: from gate.crashing.org ([63.228.1.57]:37194 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229714AbhEKXYI (ORCPT ); Tue, 11 May 2021 19:24:08 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 14BNGbGN018678; Tue, 11 May 2021 18:16:37 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 14BNGZlW018677; Tue, 11 May 2021 18:16:35 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 11 May 2021 18:16:35 -0500 From: Segher Boessenkool To: Alexey Kardashevskiy Cc: Michal Marek , linux-kbuild@vger.kernel.org, Masahiro Yamada , Nick Desaulniers , linux-kernel@vger.kernel.org, Nicholas Piggin , Nathan Chancellor , clang-built-linux@googlegroups.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor Message-ID: <20210511231635.GR10366@gate.crashing.org> References: <20210511044812.267965-1-aik@ozlabs.ru> <20210511112019.GK10366@gate.crashing.org> <1795b9efa40.27bb.1ca38dd7e845b990cd13d431eb58563d@ozlabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1795b9efa40.27bb.1ca38dd7e845b990cd13d431eb58563d@ozlabs.ru> User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2021 at 11:30:17PM +1000, Alexey Kardashevskiy wrote: > >In any case, please mention the reasoning (and the fact that you are > >removing these flags!) in the commit message. Thanks! > > but i did mention this, the last paragraph... they are duplicated. Oh! I completely missed those few lines. Sorry for that :-( To compensate a bit: > It still puzzles me why we need -C > (preserve comments in the preprocessor output) flag here. It is so that a human can look at the output and read it. Comments are very significant to human readers :-) Segher