From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAAA8C433B4 for ; Wed, 12 May 2021 04:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 805B761584 for ; Wed, 12 May 2021 04:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbhELERT (ORCPT ); Wed, 12 May 2021 00:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbhELERT (ORCPT ); Wed, 12 May 2021 00:17:19 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8CDDC061574; Tue, 11 May 2021 21:16:11 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id o127so12181647wmo.4; Tue, 11 May 2021 21:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JCncdDjE7Srd7BUCB3CPtEnkitbRPaUmqjcTmdGK2+s=; b=aipHKNVyb/XjRKn46VmjkCzFRB+Thi4NQbiuj/K5+hduiPoWM4YPwjPcbDpqgS0zVt jaus4A20Am5DwCf+cwp43X5JILZHguFZDjjvYr2e8rpoOEvtPOUYJhb/f7MPFVOd4zAv tSO4Ih+xzNKFhLPc/ExIDfa8l4oTaIyEIUfNZdpB9cvUpuboGg6Zum/l82/PmX4fVuyj SLTuG4mAcdkiypRZH5p9WIxUgywwytHURcH61exNne2yXxNNghHBPiNSWqcR67qGE0dn n4A4tep+UjwTvZaZOTVYUeqybQT2rMg5dALmwRccSLz1x+uPiIO8o8obrdtKVTrXGjph 2pKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=JCncdDjE7Srd7BUCB3CPtEnkitbRPaUmqjcTmdGK2+s=; b=CAvOZp3ZJ5yvw/QJpJkeREmUzN/r/SlPd4KVciNWcz3S9fd6KktsMm1xA05EqRbEBA TNAwbFC45L8Jkel6PoLkMm6t5DeRvPkOVVpDyoX5ZUxHb3nK+HruGVMdgXg+E3CkPwqv JxYSkTPS1XV1nnCnQxed5Lca3jWlheojMT2dE3znsJjuyUftadQKpk30aiz4lS824nGX OXINnz4knGgYBNOKm4ctJ1GkJf/RuJogLm6e/zYQrRDyY5zdxcuL6V2q+udnYHB2MWBN QqDr3OwIPSQL43QiW3IHmaiF4oJe4ZV73UQSiO7pZZ9JPR6jfSmV2NFQGubvP1jAwJHz 78Tw== X-Gm-Message-State: AOAM531NYnclXB+b9ZxyTzIcRLsyFR794ZBuOqXPo9bwp9Umd+ZFPfuZ Dv41Rle9zySdOKxXKNAiVIRwUY9ohYW82g== X-Google-Smtp-Source: ABdhPJxON1Uvwty2GZz67IASvmlU0zxVGLrQUop9ggaCt5KNqRk9zVyImtJ4y0WSrtFpcUfe/5T6rQ== X-Received: by 2002:a1c:750b:: with SMTP id o11mr9186963wmc.188.1620792970259; Tue, 11 May 2021 21:16:10 -0700 (PDT) Received: from lorien (lorien.valinor.li. [2a01:4f8:192:61d5::2]) by smtp.gmail.com with ESMTPSA id f1sm2438168wrr.63.2021.05.11.21.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 21:16:09 -0700 (PDT) Sender: Salvatore Bonaccorso Date: Wed, 12 May 2021 06:16:08 +0200 From: Salvatore Bonaccorso To: oss-security@lists.openwall.com Cc: netdev@vger.kernel.org, socketcan@hartkopp.net, mkl@pengutronix.de, alex.popov@linux.com, linux-can@vger.kernel.org, seth.arnold@canonical.com, steve.beattie@canonical.com, cascardo@canonical.com Subject: Re: [oss-security] Linux kernel: net/can/isotp: race condition leads to local privilege escalation Message-ID: <20210512041608.GA1420@lorien.valinor.li> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi, On Wed, May 12, 2021 at 12:00:33AM +0200, Norbert Slusarek wrote: > A race condition in the CAN ISOTP networking protocol was discovered which > allows forbidden changing of socket members after binding the socket. > > In particular, the lack of locking behavior in isotp_setsockopt() makes it > feasible to assign the flag CAN_ISOTP_SF_BROADCAST to the socket, despite having > previously registered a can receiver. After closing the isotp socket, the can > receiver will still be registered and use-after-free's can be triggered in > isotp_rcv() on the freed isotp_sock structure. > This leads to arbitrary kernel execution by overwriting the sk_error_report() > pointer, which can be misused in order to execute a user-controlled ROP chain to > gain root privileges. > > The vulnerability was introduced with the introduction of SF_BROADCAST support > in commit 921ca574cd38 ("can: isotp: add SF_BROADCAST support for functional > addressing") in 5.11-rc1. > In fact, commit 323a391a220c ("can: isotp: isotp_setsockopt(): > block setsockopt on bound sockets") did not effectively prevent isotp_setsockopt() > from modifying socket members before isotp_bind(). > > The requested CVE ID will be revealed along with further exploitation details > as a response to this notice on 13th May of 2021. > > Credits: Norbert Slusarek > > *** exploit log *** > > Adjusted to work with openSUSE Tumbleweed. > > noprivs@suse:~/expl> uname -a > Linux suse 5.12.0-1-default #1 SMP Mon Apr 26 04:25:46 UTC 2021 (5d43652) x86_64 x86_64 x86_64 GNU/Linux > noprivs@suse:~/expl> ./lpe > [+] entering setsockopt > [+] entering bind > [+] left bind with ret = 0 > [+] left setsockopt with flags = 838 > [+] race condition hit, closing and spraying socket > [+] sending msg to run softirq with isotp_rcv() > [+] check sudo su for root rights > noprivs@suse:~/expl> sudo su > suse:/home/noprivs/expl # id > uid=0(root) gid=0(root) groups=0(root) > suse:/home/noprivs/expl # cat /root/check > high school student living in germany looking for an internship in info sec. > if interested please reach out to nslusarek@gmx.net. FTR, this issue has CVE-2021-32606[1] assigned. [1]: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-32606 Regards, Salvatore