All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@gmail.com>
To: rostedt@goodmis.org
Cc: linux-trace-devel@vger.kernel.org
Subject: [PATCH v3 20/25] trace-cmd library: Track the offset in the option section in the trace file
Date: Wed, 12 May 2021 09:38:18 +0300	[thread overview]
Message-ID: <20210512063823.324610-21-tz.stoyanov@gmail.com> (raw)
In-Reply-To: <20210512063823.324610-1-tz.stoyanov@gmail.com>

When reading / writing trace file, store the offset of the option
section in the file. A new internal API is added, to get the offset of
the option section from an input file handler:
 tracecmd_get_options_offset()

These changes are needed for compression of the option section from
the trace file.

Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
---
 lib/trace-cmd/include/private/trace-cmd-private.h |  1 +
 lib/trace-cmd/trace-input.c                       | 11 +++++++++++
 lib/trace-cmd/trace-output.c                      |  2 ++
 3 files changed, 14 insertions(+)

diff --git a/lib/trace-cmd/include/private/trace-cmd-private.h b/lib/trace-cmd/include/private/trace-cmd-private.h
index d7488346..a9b66736 100644
--- a/lib/trace-cmd/include/private/trace-cmd-private.h
+++ b/lib/trace-cmd/include/private/trace-cmd-private.h
@@ -239,6 +239,7 @@ tracecmd_get_cursor(struct tracecmd_input *handle, int cpu);
 unsigned long tracecmd_get_file_version(struct tracecmd_input *handle);
 int tracecmd_get_file_compress_proto(struct tracecmd_input *handle,
 				     const char **name, const char **version);
+size_t tracecmd_get_options_offset(struct tracecmd_input *handle);
 
 int tracecmd_ftrace_overrides(struct tracecmd_input *handle, struct tracecmd_ftrace *finfo);
 bool tracecmd_get_use_trace_clock(struct tracecmd_input *handle);
diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c
index 5088a059..78581789 100644
--- a/lib/trace-cmd/trace-input.c
+++ b/lib/trace-cmd/trace-input.c
@@ -157,6 +157,7 @@ struct tracecmd_input {
 	size_t			header_files_start;
 	size_t			ftrace_files_start;
 	size_t			event_files_start;
+	size_t			options_start;
 	size_t			total_file_size;
 
 	/* For custom profilers. */
@@ -2759,6 +2760,7 @@ static int handle_options(struct tracecmd_input *handle)
 
 	/* By default, use usecs, unless told otherwise */
 	handle->flags |= TRACECMD_FL_IN_USECS;
+	handle->options_start = lseek64(handle->fd, 0, SEEK_CUR);
 
 	for (;;) {
 		if (do_read_check(handle, &option, 2))
@@ -4215,6 +4217,15 @@ bool tracecmd_get_use_trace_clock(struct tracecmd_input *handle)
 	return handle->use_trace_clock;
 }
 
+/**
+ * tracecmd_get_options_offset - get offset of the options sections in the file
+ * @handle: input handle for the trace.dat file
+ */
+size_t tracecmd_get_options_offset(struct tracecmd_input *handle)
+{
+	return handle->options_start;
+}
+
 /**
  * tracecmd_get_show_data_func - return the show data func
  * @handle: input handle for the trace.dat file
diff --git a/lib/trace-cmd/trace-output.c b/lib/trace-cmd/trace-output.c
index 57b11493..1bd2351f 100644
--- a/lib/trace-cmd/trace-output.c
+++ b/lib/trace-cmd/trace-output.c
@@ -66,6 +66,7 @@ struct tracecmd_output {
 	bool			quiet;
 	unsigned long		file_state;
 	unsigned long		file_version;
+	size_t			options_start;
 
 	bool			do_compress;
 	struct tracecmd_compression *compress;
@@ -1854,6 +1855,7 @@ struct tracecmd_output *tracecmd_get_output_handle_fd(int fd)
 	tep_ref(handle->pevent);
 	handle->page_size = tracecmd_page_size(ihandle);
 	handle->file_version = tracecmd_get_file_version(ihandle);
+	handle->options_start = tracecmd_get_options_offset(ihandle);
 	list_head_init(&handle->options);
 	list_head_init(&handle->buffers);
 
-- 
2.31.1


  parent reply	other threads:[~2021-05-12  6:38 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  6:37 [PoC PATCH v3 00/25] Add trace file compression Tzvetomir Stoyanov (VMware)
2021-05-12  6:37 ` [PATCH v3 01/25] trace-cmd library: Remove unused private APIs for creating trace files Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 02/25] trace-cmd library: Remove unused API tracecmd_update_option Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 03/25] trace-cmd: Check if file version is supported Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 04/25] trace-cmd library: Add new API to get file version of input handler Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 05/25] trace-cmd library: Select the file version when writing trace file Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 06/25] trace-cmd: Add APIs for library initialization and free Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 07/25] trace-cmd library: Add support for compression algorithms Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 08/25] trace-cmd list: Show supported " Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 09/25] trace-cmd library: Bump the trace file version to 7 Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 10/25] trace-cmd library: Compress part of the trace file Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 11/25] trace-cmd library: Read compressed " Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 12/25] trace-cmd library: Add new API to get compression of input handler Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 13/25] trace-cmd library: Inherit compression algorithm from input file Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 14/25] trace-cmd library: Extend the create file APIs to support different compression Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 15/25] trace-cmd record: Add new parameter --compression Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 16/25] trace-cmd dump: Add support for trace files version 7 Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 17/25] trace-cmd library: Add support for zlib compression library Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 18/25] trace-cmd library: Hide the logic for updating buffer offset Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 19/25] trace-cmd: Move buffers description outside of options Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` Tzvetomir Stoyanov (VMware) [this message]
2021-05-12  6:38 ` [PATCH v3 21/25] trace-cmd library: Add compression of the option section of the trace file Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 22/25] trace-cmd library: Refactor the logic for writing trace data in the file Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 23/25] trace-cmd library: Add APIs for read and write compressed data in chunks Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 24/25] trace-cmd: Compress trace data Tzvetomir Stoyanov (VMware)
2021-05-12  6:38 ` [PATCH v3 25/25] trace-cmd: Read compressed " Tzvetomir Stoyanov (VMware)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512063823.324610-21-tz.stoyanov@gmail.com \
    --to=tz.stoyanov@gmail.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.