From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95E3FC433ED for ; Wed, 12 May 2021 13:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61BCB613DE for ; Wed, 12 May 2021 13:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhELNiZ (ORCPT ); Wed, 12 May 2021 09:38:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:47594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230343AbhELNiW (ORCPT ); Wed, 12 May 2021 09:38:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C13F961396; Wed, 12 May 2021 13:37:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620826634; bh=WZWUVJv6wHBuiJ8L9DgzRbddiGUflgyKMlK3SlEXGQ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gri7qyNUIpzL2n+4B8s5R6cR3nvN/HIOeVeEd9RBoPAXl7KfzzycxFmYns61POedw xVfxZk0d/UEliWP0zHUyAan9yBBvwIzytEj5NwxeIGXRQOq5uaBygBTIt4L3EU01CN eswcEtqQoLm7ynjb1HFMEl9DoseCNUEp/NZRbEgfQHw001GK44nLiwd3tWduuW+JFt 7Xx44kdMVnnOB+54OG7bzkiYh9KmemjwQhkOgW5RBubK8U5p+NywUa6+YQX83fG1Yi IvLkcZqJiwKfvXm3MpWwyTLy1CJXmoGU6hL+rH82Gx8Wack4p8AsLpxT4lS1X52Ljy mujMnPEjWiNVQ== Date: Wed, 12 May 2021 15:37:10 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, Julia Lawall , "Rafael J . Wysocki" , Jonathan Cameron , Sean Nyekjaer Subject: Re: [PATCH 05/28] iio: accel: mma8452: Balance runtime pm + use pm_runtime_resume_and_get() Message-ID: <20210512153710.6d8957a2@coco.lan> In-Reply-To: <20210509113354.660190-6-jic23@kernel.org> References: <20210509113354.660190-1-jic23@kernel.org> <20210509113354.660190-6-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Em Sun, 9 May 2021 12:33:31 +0100 Jonathan Cameron escreveu: > From: Jonathan Cameron > > Remove() callback calls pm_runtime_put_noidle() but there it is not > balancing a get. No actual affect because the runtime pm core prevents > the reference count going negative. > > Whilst here use pm_runtime_resume_and_get() rather than open coded version. > Again, coccinelle script missed this one due to more complex code > structure. > > Signed-off-by: Jonathan Cameron > Cc: Sean Nyekjaer LGTM. Reviewed-by: Mauro Carvalho Chehab > --- > drivers/iio/accel/mma8452.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 464a6bfe6746..715b8138fb71 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -221,7 +221,7 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) > int ret; > > if (on) { > - ret = pm_runtime_get_sync(&client->dev); > + ret = pm_runtime_resume_and_get(&client->dev); > } else { > pm_runtime_mark_last_busy(&client->dev); > ret = pm_runtime_put_autosuspend(&client->dev); > @@ -230,8 +230,6 @@ static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) > if (ret < 0) { > dev_err(&client->dev, > "failed to change power state to %d\n", on); > - if (on) > - pm_runtime_put_noidle(&client->dev); > > return ret; > } > @@ -1711,7 +1709,6 @@ static int mma8452_remove(struct i2c_client *client) > > pm_runtime_disable(&client->dev); > pm_runtime_set_suspended(&client->dev); > - pm_runtime_put_noidle(&client->dev); > > iio_triggered_buffer_cleanup(indio_dev); > mma8452_trigger_cleanup(indio_dev); Thanks, Mauro