From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67490C43619 for ; Wed, 12 May 2021 20:12:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2725F61422 for ; Wed, 12 May 2021 20:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343825AbhELT7R (ORCPT ); Wed, 12 May 2021 15:59:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:55186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349973AbhELSKR (ORCPT ); Wed, 12 May 2021 14:10:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 684F96193E; Wed, 12 May 2021 18:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620842729; bh=84ey2UjrGv61T0itePr91cHQ3aTRkpF+WMV1VJ404U4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hxvFUaoQyUjjghhZt4BRIvt5bawWTXHW0OxRmlBssxJsYMIc4v2TXp+Hb4zndBWnO urj/NDAniJdGfpyll4sy+2tYIyqgeL4bFx75Xv2/chrEvceDi8wYbBjiQUryJLLEob DB6pJnTsGIQbmmlhi0mHqvTUEPrDfNIcfdvawesY3WMC6LUs4R6R13ujFpYcNa2K5K sgcSQ2Ipnx0eEku9aduRq7dXc9Usg4rw9aLXiRo8O4h2/s3OHb6uHnacviuMmq348G cWsmgx+No+e2uvkalEjru/grJg6tx1RpRgcC7bho63i00DDx+if3QcjL+SIdmc6H4a 9J7TfAjraas2A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Feilong Lin , Zhiqiang Liu , Bjorn Helgaas , "Rafael J . Wysocki" , Sasha Levin , linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 04/12] ACPI / hotplug / PCI: Fix reference count leak in enable_slot() Date: Wed, 12 May 2021 14:05:14 -0400 Message-Id: <20210512180522.665788-4-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210512180522.665788-1-sashal@kernel.org> References: <20210512180522.665788-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Feilong Lin [ Upstream commit 3bbfd319034ddce59e023837a4aa11439460509b ] In enable_slot(), if pci_get_slot() returns NULL, we clear the SLOT_ENABLED flag. When pci_get_slot() finds a device, it increments the device's reference count. In this case, we did not call pci_dev_put() to decrement the reference count, so the memory of the device (struct pci_dev type) will eventually leak. Call pci_dev_put() to decrement its reference count when pci_get_slot() returns a PCI device. Link: https://lore.kernel.org/r/b411af88-5049-a1c6-83ac-d104a1f429be@huawei.com Signed-off-by: Feilong Lin Signed-off-by: Zhiqiang Liu Signed-off-by: Bjorn Helgaas Reviewed-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/pci/hotplug/acpiphp_glue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index f2c1008e0f76..40e936e3a480 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -509,6 +509,7 @@ static void enable_slot(struct acpiphp_slot *slot) slot->flags &= (~SLOT_ENABLED); continue; } + pci_dev_put(dev); } } -- 2.30.2