All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: hdanton@sina.com, mgorman@suse.de, mhocko@suse.com,
	mm-commits@vger.kernel.org, npiggin@gmail.com,
	oleksiy.avramchenko@sonymobile.com, rostedt@goodmis.org,
	sfr@canb.auug.org.au, urezki@gmail.com, willy@infradead.org
Subject: [failures] mm-vmalloc-print-a-warning-message-first-on-failure.patch removed from -mm tree
Date: Wed, 12 May 2021 13:29:52 -0700	[thread overview]
Message-ID: <20210512202952.PRR7JClh8%akpm@linux-foundation.org> (raw)


The patch titled
     Subject: mm/vmalloc: print a warning message first on failure
has been removed from the -mm tree.  Its filename was
     mm-vmalloc-print-a-warning-message-first-on-failure.patch

This patch was dropped because it had testing failures

------------------------------------------------------
From: Uladzislau Rezki <urezki@gmail.com>
Subject: mm/vmalloc: print a warning message first on failure

When a memory allocation for array of pages are not succeed emit a warning
message as a first step and then perform the further cleanup.

The reason it should be done in a right order is the clean up function
which is free_vm_area() can potentially also follow its error paths what
can lead to confusion what was broken first.

Link: https://lkml.kernel.org/r/20210510103342.GA2169@pc638.lan
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Hillf Danton <hdanton@sina.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/vmalloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/mm/vmalloc.c~mm-vmalloc-print-a-warning-message-first-on-failure
+++ a/mm/vmalloc.c
@@ -2780,11 +2780,11 @@ static void *__vmalloc_area_node(struct
 	}
 
 	if (!area->pages) {
-		free_vm_area(area);
 		warn_alloc(gfp_mask, NULL,
 			   "vmalloc size %lu allocation failure: "
 			   "page array size %lu allocation failed",
 			   nr_small_pages * PAGE_SIZE, array_size);
+		free_vm_area(area);
 		return NULL;
 	}
 
_

Patches currently in -mm which might be from urezki@gmail.com are



             reply	other threads:[~2021-05-12 21:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 20:29 akpm [this message]
2021-05-12 22:56 ` [failures] mm-vmalloc-print-a-warning-message-first-on-failure.patch removed from -mm tree Stephen Rothwell
2021-05-13 10:31   ` Uladzislau Rezki
2021-05-13 11:11     ` Mel Gorman
2021-05-13 12:46       ` Uladzislau Rezki
2021-05-13 13:24         ` Uladzislau Rezki
2021-05-13 14:18           ` Mel Gorman
     [not found]             ` <CA+KHdyXwdkosDYk4bKtRLVodrwUJnq3NN39xuRQzKJSPTn7+bQ@mail.gmail.com>
2021-05-13 15:51               ` Mel Gorman
2021-05-13 20:18                 ` Uladzislau Rezki
2021-05-14 10:19                   ` Mel Gorman
2021-05-14 11:45                     ` Uladzislau Rezki
2021-05-14 13:45                       ` Mel Gorman
2021-05-14 14:50                         ` Uladzislau Rezki
2021-05-14 15:41                           ` Mel Gorman
2021-05-14 17:16                             ` Uladzislau Rezki
2021-05-16 17:17                               ` Mel Gorman
2021-05-16 20:31                                 ` Uladzislau Rezki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512202952.PRR7JClh8%akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=oleksiy.avramchenko@sonymobile.com \
    --cc=rostedt@goodmis.org \
    --cc=sfr@canb.auug.org.au \
    --cc=urezki@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.