All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	hverkuil-cisco@xs4all.nl
Subject: Re: [bug report] media: tuners: fix error return code of hybrid_tuner_request_state()
Date: Thu, 13 May 2021 10:29:31 +0300	[thread overview]
Message-ID: <20210513072931.GF1922@kadam> (raw)
In-Reply-To: <ec6ac4ef-057f-22a2-f2be-1773b2c50c8e@gmail.com>

On Thu, May 13, 2021 at 10:20:08AM +0800, Jia-Ju Bai wrote:
> Hi Dan,
> 
> Thanks for your report.
> I check the code again, and find that returning zero should indicate an
> error here.
> Good catch of Smatch :)
> 
> Sorry for my mistake in my patch...
> Please revert the incorrect change caused by my patch b9302fa7ed97.

I don't think Mauro and Hans are necessarily going to see this.  Please
send a proper patch that they can apply.  :P

regards,
dan carpenter


      reply	other threads:[~2021-05-13  7:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 14:03 [bug report] media: tuners: fix error return code of hybrid_tuner_request_state() Dan Carpenter
2021-05-12 14:16 ` Dan Carpenter
2021-05-13  2:20   ` Jia-Ju Bai
2021-05-13  7:29     ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513072931.GF1922@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=baijiaju1990@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.