All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hyeonggon Yoo <42.hyeyoo@gmail.com>
To: Marco Elver <elver@google.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	David Rientjes <rientjes@google.com>,
	Pekka Enberg <penberg@kernel.org>,
	Christoph Lameter <cl@linux.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time
Date: Thu, 13 May 2021 21:38:22 +0900	[thread overview]
Message-ID: <20210513123822.GA776220@hyeyoo> (raw)
In-Reply-To: <CANpmjNP9AQ2PH9wtZbZ3bT=0YAqnaPpxAN0LgrjBO_PhzG5tjQ@mail.gmail.com>

On Thu, May 13, 2021 at 02:29:13PM +0200, Marco Elver wrote:
> On Thu, 13 May 2021 at 14:03, Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote:
> > On Thu, May 13, 2021 at 12:31:38PM +0200, Marco Elver wrote:
> [...]
> > what about checking size it on top of kmalloc_index? because by definition of
> > KMALLOC_SHIFT_HIGH, it's not always 25. it can be less than 25. for some
> > situations.
> >
> > below is what I suggested beofre. for just reference:
> 
> This doesn't solve the problem. We want the compiler to complain
> whenever kmalloc_index() is used with non-constant in normal code.

in the beginning, I thought kmalloc_index is called only from kmalloc.
but if kmalloc_index is called from other place, I think it should
correctly check its size. that's what kmalloc_index should do.

or... should it be solved as another patch?

  reply	other threads:[~2021-05-13 12:38 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 17:34 [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Hyeonggon Yoo
2021-05-11 17:38 ` Hyeonggon Yoo
2021-05-11 18:08 ` Vlastimil Babka
2021-05-13  2:52 ` Andrew Morton
2021-05-13  3:12   ` Hyeonggon Yoo
2021-05-13  3:40     ` Andrew Morton
2021-05-13  6:28       ` Hyeonggon Yoo
2021-05-13  8:46         ` Marco Elver
2021-05-13  8:46           ` Marco Elver
2021-05-13  8:51         ` Vlastimil Babka
2021-05-13 10:31           ` Marco Elver
2021-05-13 11:37             ` Vlastimil Babka
2021-05-13 12:08               ` Hyeonggon Yoo
2021-05-13 12:10                 ` Hyeonggon Yoo
2021-05-13 12:03             ` Hyeonggon Yoo
2021-05-13 12:29               ` Marco Elver
2021-05-13 12:29                 ` Marco Elver
2021-05-13 12:38                 ` Hyeonggon Yoo [this message]
2021-05-13 13:08                 ` Hyeonggon Yoo
2021-05-13 12:44   ` [PATCH] kfence: test: fix for "mm, slub: change run-time assertion in kmalloc_index() to compile-time" Marco Elver
2021-05-15 21:09 ` [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Hyeonggon Yoo
2021-05-15 21:24   ` Vlastimil Babka
2021-05-15 21:56     ` Hyeonggon Yoo
2021-05-16  6:34     ` Nathan Chancellor
2021-05-18  0:38       ` Hyeonggon Yoo
2021-05-18  0:43         ` Nathan Chancellor
2021-05-18  1:53           ` Hyeonggon Yoo
2021-05-18  9:28           ` Vlastimil Babka
2021-05-18 11:18             ` Hyeonggon Yoo
2021-05-18 11:34               ` Vlastimil Babka
2021-05-19  5:45                 ` Hyeonggon Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210513123822.GA776220@hyeyoo \
    --to=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=elver@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.