From: Alan Stern <stern@rowland.harvard.edu>
To: Gopalakrishnan Santhanam <gsanthan@cisco.com>
Cc: danielwa@cisco.com, hramdasi@cisco.com,
christian.engelmayer@frequentis.com, xe-linux-external@cisco.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fsl-usb: add need_oc_pp_cycle flag for 85xx also
Date: Thu, 13 May 2021 10:42:06 -0400 [thread overview]
Message-ID: <20210513144206.GG967812@rowland.harvard.edu> (raw)
In-Reply-To: <20210513083225.68912-1-gsanthan@cisco.com>
On Thu, May 13, 2021 at 02:02:25PM +0530, Gopalakrishnan Santhanam wrote:
> Commit e6604a7fd71f9 ("EHCI: Quirk flag for port power handling
> on overcurrent.") activated the quirks handling (flag need_oc_pp_cycle)
> for Freescale 83xx based boards.
> Activate same for 85xx based boards as well.
>
> Cc: xe-linux-external@cisco.com
> Signed-off-by: Gopalakrishnan Santhanam <gsanthan@cisco.com>
> Signed-off-by: Daniel Walker <danielwa@cisco.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ehci-fsl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 6f7bd6641694..385be30baad3 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -387,11 +387,11 @@ static int ehci_fsl_setup(struct usb_hcd *hcd)
> /* EHCI registers start at offset 0x100 */
> ehci->caps = hcd->regs + 0x100;
>
> -#ifdef CONFIG_PPC_83xx
> +#if defined(CONFIG_PPC_83xx) || defined(CONFIG_PPC_85xx)
> /*
> - * Deal with MPC834X that need port power to be cycled after the power
> - * fault condition is removed. Otherwise the state machine does not
> - * reflect PORTSC[CSC] correctly.
> + * Deal with MPC834X/85XX that need port power to be cycled
> + * after the power fault condition is removed. Otherwise the
> + * state machine does not reflect PORTSC[CSC] correctly.
> */
> ehci->need_oc_pp_cycle = 1;
> #endif
> --
> 2.26.2.Cisco
>
prev parent reply other threads:[~2021-05-13 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 17:23 [PATCH] fsl-usb: add need_oc_pp_cycle flag for 85xx also Daniel Walker
2021-05-07 17:36 ` Alan Stern
2021-05-11 13:19 ` Gopalakrishnan Santhanam -X (gsanthan - Altran ACT S.A.S at Cisco)
2021-05-13 8:32 ` [PATCH v2] " Gopalakrishnan Santhanam
2021-05-13 14:42 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513144206.GG967812@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=christian.engelmayer@frequentis.com \
--cc=danielwa@cisco.com \
--cc=gregkh@linuxfoundation.org \
--cc=gsanthan@cisco.com \
--cc=hramdasi@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.