From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6206CC433B4 for ; Thu, 13 May 2021 15:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2518C6142E for ; Thu, 13 May 2021 15:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234999AbhEMPnO (ORCPT ); Thu, 13 May 2021 11:43:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:43566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234865AbhEMPnK (ORCPT ); Thu, 13 May 2021 11:43:10 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD3D46101B; Thu, 13 May 2021 15:41:58 +0000 (UTC) Date: Thu, 13 May 2021 16:43:07 +0100 From: Jonathan Cameron To: Chunyan Zhang Cc: linux-iio@vger.kernel.org, Baolin Wang , linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang Subject: Re: [PATCH] iio: adc: Add missing MODULE_DEVICE_TABLE Message-ID: <20210513164307.5e22ee4b@jic23-huawei> In-Reply-To: <20210512093844.243245-1-zhang.lyra@gmail.com> References: <20210512093844.243245-1-zhang.lyra@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 May 2021 17:38:44 +0800 Chunyan Zhang wrote: > From: Chunyan Zhang > > MODULE_DEVICE_TABLE is used to extract the device information out of the > driver and builds a table when being compiled. If using this macro, > kernel can find the driver if available when the device is plugged in, > and then loads that driver and initializes the device. > > Signed-off-by: Chunyan Zhang Applied to the togreg branch of iio.git and pushed out as testing to see if 0-day can find anything we missed. Thanks, Jonathan > --- > drivers/iio/adc/sc27xx_adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/sc27xx_adc.c b/drivers/iio/adc/sc27xx_adc.c > index 301cf66de695..00098caf6d9e 100644 > --- a/drivers/iio/adc/sc27xx_adc.c > +++ b/drivers/iio/adc/sc27xx_adc.c > @@ -549,6 +549,7 @@ static const struct of_device_id sc27xx_adc_of_match[] = { > { .compatible = "sprd,sc2731-adc", }, > { } > }; > +MODULE_DEVICE_TABLE(of, sc27xx_adc_of_match); > > static struct platform_driver sc27xx_adc_driver = { > .probe = sc27xx_adc_probe,