From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Glass Date: Thu, 13 May 2021 19:39:23 -0600 Subject: [PATCH v2 07/16] test: Avoid random numbers in dm_test_devm_regmap() In-Reply-To: <20210513193923.v2.1.I85633a7354c5b2ad5c55257607280392d069d70c@changeid> References: <20210513193923.v2.1.I85633a7354c5b2ad5c55257607280392d069d70c@changeid> Message-ID: <20210514014011.2832707-5-sjg@chromium.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de There is no good reason to use a sequence from rand() here. We may as well invent our own sequence. This should molify Coverity which does not use rand() being used. Signed-off-by: Simon Glass Reported-by: Coverity (CID: 312949) --- (no changes since v1) test/dm/regmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/dm/regmap.c b/test/dm/regmap.c index 372a73ca0c3..04bb1645d1b 100644 --- a/test/dm/regmap.c +++ b/test/dm/regmap.c @@ -306,9 +306,8 @@ static int dm_test_devm_regmap(struct unit_test_state *uts) &dev)); priv = dev_get_priv(dev); - srand(get_ticks() + rand()); for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) { - pattern[i] = rand(); + pattern[i] = i * 0x87654321; ut_assertok(regmap_write(priv->cfg_regmap, i, pattern[i])); } for (i = 0; i < REGMAP_TEST_BUF_SZ; i++) { -- 2.31.1.751.gd2f1c929bd-goog