From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2716C433ED for ; Fri, 14 May 2021 06:37:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 63A4061447 for ; Fri, 14 May 2021 06:37:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63A4061447 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 95FE86B0036; Fri, 14 May 2021 02:37:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9103D6B006E; Fri, 14 May 2021 02:37:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B0BC6B0070; Fri, 14 May 2021 02:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 45A046B0036 for ; Fri, 14 May 2021 02:37:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CAF948249980 for ; Fri, 14 May 2021 06:37:40 +0000 (UTC) X-FDA: 78138880680.28.D481490 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf29.hostedemail.com (Postfix) with ESMTP id 874E73CD for ; Fri, 14 May 2021 06:37:38 +0000 (UTC) IronPort-SDR: Nwu+kVmWLmkEyPoR95K1EVNNe2AJVKip1bJ0emqC2wCH9dmpT/Q9KX1chzffcdrwqVss+QtRR7 wG5cRrRNs3DA== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="264046202" X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="264046202" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 23:37:35 -0700 IronPort-SDR: wscgVNGBJLOC/mNX4ksFs5fO8tb4iiGPVN8MiK39odVDln8yC0uaJqEaU0JAHzujy9dux89cVe M3QF3lj+beVQ== X-IronPort-AV: E=Sophos;i="5.82,299,1613462400"; d="scan'208";a="626697305" Received: from shao2-debian.sh.intel.com (HELO localhost) ([10.239.13.11]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 23:37:34 -0700 Date: Fri, 14 May 2021 14:36:22 +0800 From: kernel test robot To: Florent Revest Cc: kbuild-all@lists.01.org, Linux Memory Management List , Alexei Starovoitov Subject: [linux-next:master 2296/2770] kernel/bpf/helpers.c:713:43: warning: Uninitialized variable: bufs [uninitvar] Message-ID: <20210514063622.GU2687475@shao2-debian> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 874E73CD Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none); spf=none (imf29.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam04 X-Stat-Signature: oybxfjfcuhpcwi9egot7s1pjadzgn7zk X-HE-Tag: 1620974258-466655 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: ec2618180c3450d06a6a4ba951d4c9a2c689b517 commit: e2d5b2bb769fa5f500760caba76436ba3a10a895 [2296/2770] bpf: Fix nested bpf_bprintf_prepare with more per-cpu buffers compiler: sparc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> kernel/bpf/helpers.c:713:43: warning: Uninitialized variable: bufs [uninitvar] if (WARN_ON_ONCE(nest_level > ARRAY_SIZE(bufs->tmp_bufs))) { ^ kernel/bpf/helpers.c:408:20: warning: Possible null pointer dereference: storage [nullPointer] ptr = &READ_ONCE(storage->buf)->data[0]; ^ kernel/bpf/helpers.c:395:39: note: Assignment 'storage=NULL', assigned value is 0 struct bpf_cgroup_storage *storage = NULL; ^ kernel/bpf/helpers.c:408:20: note: Null pointer dereference ptr = &READ_ONCE(storage->buf)->data[0]; ^ vim +713 kernel/bpf/helpers.c d9c9e4db186ab4 Florent Revest 2021-04-19 705 d9c9e4db186ab4 Florent Revest 2021-04-19 706 static int try_get_fmt_tmp_buf(char **tmp_buf) d9c9e4db186ab4 Florent Revest 2021-04-19 707 { e2d5b2bb769fa5 Florent Revest 2021-05-11 708 struct bpf_bprintf_buffers *bufs; e2d5b2bb769fa5 Florent Revest 2021-05-11 709 int nest_level; d9c9e4db186ab4 Florent Revest 2021-04-19 710 d9c9e4db186ab4 Florent Revest 2021-04-19 711 preempt_disable(); e2d5b2bb769fa5 Florent Revest 2021-05-11 712 nest_level = this_cpu_inc_return(bpf_bprintf_nest_level); e2d5b2bb769fa5 Florent Revest 2021-05-11 @713 if (WARN_ON_ONCE(nest_level > ARRAY_SIZE(bufs->tmp_bufs))) { e2d5b2bb769fa5 Florent Revest 2021-05-11 714 this_cpu_dec(bpf_bprintf_nest_level); d9c9e4db186ab4 Florent Revest 2021-04-19 715 preempt_enable(); d9c9e4db186ab4 Florent Revest 2021-04-19 716 return -EBUSY; d9c9e4db186ab4 Florent Revest 2021-04-19 717 } e2d5b2bb769fa5 Florent Revest 2021-05-11 718 bufs = this_cpu_ptr(&bpf_bprintf_bufs); e2d5b2bb769fa5 Florent Revest 2021-05-11 719 *tmp_buf = bufs->tmp_bufs[nest_level - 1]; d9c9e4db186ab4 Florent Revest 2021-04-19 720 d9c9e4db186ab4 Florent Revest 2021-04-19 721 return 0; d9c9e4db186ab4 Florent Revest 2021-04-19 722 } d9c9e4db186ab4 Florent Revest 2021-04-19 723 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7330552081958965614==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [linux-next:master 2296/2770] kernel/bpf/helpers.c:713:43: warning: Uninitialized variable: bufs [uninitvar] Date: Fri, 14 May 2021 14:36:22 +0800 Message-ID: <20210514063622.GU2687475@shao2-debian> List-Id: --===============7330552081958965614== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git= master head: ec2618180c3450d06a6a4ba951d4c9a2c689b517 commit: e2d5b2bb769fa5f500760caba76436ba3a10a895 [2296/2770] bpf: Fix neste= d bpf_bprintf_prepare with more per-cpu buffers compiler: sparc64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >> kernel/bpf/helpers.c:713:43: warning: Uninitialized variable: bufs [unin= itvar] if (WARN_ON_ONCE(nest_level > ARRAY_SIZE(bufs->tmp_bufs))) { ^ kernel/bpf/helpers.c:408:20: warning: Possible null pointer dereference:= storage [nullPointer] ptr =3D &READ_ONCE(storage->buf)->data[0]; ^ kernel/bpf/helpers.c:395:39: note: Assignment 'storage=3DNULL', assigned= value is 0 struct bpf_cgroup_storage *storage =3D NULL; ^ kernel/bpf/helpers.c:408:20: note: Null pointer dereference ptr =3D &READ_ONCE(storage->buf)->data[0]; ^ vim +713 kernel/bpf/helpers.c d9c9e4db186ab4 Florent Revest 2021-04-19 705 = d9c9e4db186ab4 Florent Revest 2021-04-19 706 static int try_get_fmt_tmp_b= uf(char **tmp_buf) d9c9e4db186ab4 Florent Revest 2021-04-19 707 { e2d5b2bb769fa5 Florent Revest 2021-05-11 708 struct bpf_bprintf_buffers = *bufs; e2d5b2bb769fa5 Florent Revest 2021-05-11 709 int nest_level; d9c9e4db186ab4 Florent Revest 2021-04-19 710 = d9c9e4db186ab4 Florent Revest 2021-04-19 711 preempt_disable(); e2d5b2bb769fa5 Florent Revest 2021-05-11 712 nest_level =3D this_cpu_inc= _return(bpf_bprintf_nest_level); e2d5b2bb769fa5 Florent Revest 2021-05-11 @713 if (WARN_ON_ONCE(nest_level= > ARRAY_SIZE(bufs->tmp_bufs))) { e2d5b2bb769fa5 Florent Revest 2021-05-11 714 this_cpu_dec(bpf_bprintf_n= est_level); d9c9e4db186ab4 Florent Revest 2021-04-19 715 preempt_enable(); d9c9e4db186ab4 Florent Revest 2021-04-19 716 return -EBUSY; d9c9e4db186ab4 Florent Revest 2021-04-19 717 } e2d5b2bb769fa5 Florent Revest 2021-05-11 718 bufs =3D this_cpu_ptr(&bpf_= bprintf_bufs); e2d5b2bb769fa5 Florent Revest 2021-05-11 719 *tmp_buf =3D bufs->tmp_bufs= [nest_level - 1]; d9c9e4db186ab4 Florent Revest 2021-04-19 720 = d9c9e4db186ab4 Florent Revest 2021-04-19 721 return 0; d9c9e4db186ab4 Florent Revest 2021-04-19 722 } d9c9e4db186ab4 Florent Revest 2021-04-19 723 = --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============7330552081958965614==--