From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30CC1C433B4 for ; Fri, 14 May 2021 12:46:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 835BB613F5 for ; Fri, 14 May 2021 12:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 835BB613F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhXCv-0006kn-KY for qemu-devel@archiver.kernel.org; Fri, 14 May 2021 08:46:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhWmH-0004ZI-9e for qemu-devel@nongnu.org; Fri, 14 May 2021 08:18:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:24842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhWmB-0006QE-IA for qemu-devel@nongnu.org; Fri, 14 May 2021 08:18:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620994721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q7cXMKEdJZFbDVFprwV9+XsHnkyz2f8IxOho+xf2q+8=; b=gJxn84JcmLSeyAyyF9JMwHyYtqBWVDxDiFVBqkoqHt5FYvdKsgrBiFWMF3LIrcJm1mlbbK vC8HbULlAIXgIHcfVWp/5WL72GgOcDXRaLi1mWUzcDp/Oq+zHK6p/f4QFBuSqiIQkO3mAa A8EfJM81Qfgqc5nxXGUDBPVjq5VaCFE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-128-Sy4p6XMcMxuKmr9m4moNSw-1; Fri, 14 May 2021 08:18:39 -0400 X-MC-Unique: Sy4p6XMcMxuKmr9m4moNSw-1 Received: by mail-wr1-f69.google.com with SMTP id 93-20020adf80e60000b0290106fab45006so12676242wrl.20 for ; Fri, 14 May 2021 05:18:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=q7cXMKEdJZFbDVFprwV9+XsHnkyz2f8IxOho+xf2q+8=; b=CKSx/xJWmKPFqAg0at0wl3aZqh9nATdPul8OJZ1j3OS0tn36OYKSDCJrKZJwEY7bCc h9DJc+NkRYQiCTccwQJjB8xNiGqVd1oGIVGjDmSideaq/iOeqMN3nAXIzkI048jp+Dpe a3fu7VV8xZoUZAxQYXA3WRTlhhIoHKIlSrkP56hnfZVRo44PmeWCEO7A7DgDaXUEHlUG nVwVPv57+QYF84IDR+SiMXvMWfq/2LERsQVIFk8foAPyoJNN1kRL6gtxBW0Shx5YCTTb Mn4Ciky545RdDL7nOPrrtLD75jAMpUdUdXpkLxc8XjYhA1wBHfug0vU1vCpAat1JFsr5 oFhQ== X-Gm-Message-State: AOAM532+JR0QxfYgPMP3GUEwRTJW3/sk/E0axm42sRoAlMVMfZ30TBGa 4EC7SuTDqk/XeO2uvnwYoj9vB0fYiZx98vTT0L6VzXSVSY6prZX4eg9wPb3oBBr3x5kAn1/6WQJ HpZu6lB5B7gTUeJg= X-Received: by 2002:a1c:2743:: with SMTP id n64mr9080499wmn.76.1620994717544; Fri, 14 May 2021 05:18:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvtIEFnM8uOhZzvufFUed79Hqu7Q47uEVqMKyn2R8Z7DnWpvwerAvFcZFRHhx6uUfoSBQ6FA== X-Received: by 2002:a1c:2743:: with SMTP id n64mr9080475wmn.76.1620994717348; Fri, 14 May 2021 05:18:37 -0700 (PDT) Received: from redhat.com ([2a10:800c:1fa6:0:3809:fe0c:bb87:250e]) by smtp.gmail.com with ESMTPSA id r5sm5927223wmh.23.2021.05.14.05.18.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 05:18:36 -0700 (PDT) Date: Fri, 14 May 2021 08:18:33 -0400 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH v6 00/12] qtests: Check accelerator available at runtime via QMP 'query-accels' Message-ID: <20210514081728-mutt-send-email-mst@kernel.org> References: <20210503211020.894589-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210503211020.894589-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-devel@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, Igor Mammedov , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, May 03, 2021 at 11:10:08PM +0200, Philippe Mathieu-Daudé wrote: > Missing review: 10-12 (bios-tables-test) So the main functional changes is ARM stuff I think? Pls use that tree to merge. Reviewed-by: Michael S. Tsirkin > Hi, > > This series aims at having accelerator-independent qtests > by querying a QEMU instance at runtime to check the list > of built-in accelerators. > > First we add the 'query-accels' QMP command, > then we add the qtest_has_accel() method to libqtest, > finally we use this new method to allow running > bios-tables-test on KVM-only builds. > > Since v5: > - Rename bios-tables tests (Igor) > - Do not restrict bios-tables tests to TCG (Igor) > - Reset bios-tables-test R-b tags > > Since v4: > - Removed patch 10 (Markus, patch justification not clear) > 'qtest/qmp-cmd-test: Make test build-independent from accelerator' > - Removed patch 12 (Alex, icount / record/replay issue) > 'tests/meson: Only build softfloat objects if TCG is selected (again)' > - Sorted @Accelerator QAPI enum (Eric) > - Added R-b/T-b > > Since v3: > - Added Markus review comments > - Added R-b/A-b tags > > Since v2: > - Addressed Markus & Drew review comments > - Added qtest/migration-test patch > > Since v1: > - Addressed Eric & Paolo review comments > > Since v0: > - kept over-engineered union (I don't how to do simple enum) > - dropped arm-cpu-features patches for now > - fixed typos (Eric) > - rename qtest_has_accel (Thomas) > - probe accel with machine none previous qtest (Paolo) > - iterate over QAPI enum (Markus) > > Eric's suggestion of conditional QAPI didn't worked out, > as accelerator definitions are poisoned. > > Phil. > > Philippe Mathieu-Daudé (12): > MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section > accel: Introduce 'query-accels' QMP command > qtest: Add qtest_has_accel() method > qtest/arm-cpu-features: Use generic qtest_has_accel() to check for KVM > qtest/arm-cpu-features: Restrict sve_tests_sve_off_kvm test to KVM > qtest/arm-cpu-features: Remove TCG fallback to KVM specific tests > qtest/arm-cpu-features: Use generic qtest_has_accel() to check for TCG > qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64 > qtest/bios-tables-test: Rename tests not TCG specific > qtest/bios-tables-test: Rename TCG specific tests > qtest/bios-tables-test: Make test build-independent from accelerator > qtest: Do not restrict bios-tables-test to Aarch64 hosts anymore > > qapi/machine.json | 47 ++++++++++ > tests/qtest/libqos/libqtest.h | 8 ++ > accel/accel-qmp.c | 49 +++++++++++ > tests/qtest/arm-cpu-features.c | 55 ++++-------- > tests/qtest/bios-tables-test.c | 156 ++++++++++++++++----------------- > tests/qtest/libqtest.c | 29 ++++++ > tests/qtest/migration-test.c | 4 +- > MAINTAINERS | 1 + > accel/meson.build | 2 +- > tests/qtest/meson.build | 3 +- > 10 files changed, 232 insertions(+), 122 deletions(-) > create mode 100644 accel/accel-qmp.c > > -- > 2.26.3 >